[ovn-octavia-provider] Fix member update according to the Octavia API definition

[Fernando Royo]

Nowadays member parameters are checked in an update that are not able to modify by Octavia API, such as address, port or subnet_id for an existing member. According to the definition of the member update (and batch_update) the parameters supported by the ovn-provider is only the admin_state_up of the member, so it seems coherent to clean the code to just analyze this one.

In fact, the current checks performed on the attributes (not editable in an update operation) trigger an error and the update does not finish correctly.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/880945

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/880945
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/8beeeb9112f6c61758f844774bfe4c5d6e8c6a08
Submitter: "Zuul (22348)"
Branch: master

commit 8beeeb9112f6c61758f844774bfe4c5d6e8c6a08
Author: Fernando Royo <email address hidden>
Date: Thu Apr 20 13:04:33 2023 +0200

    Fix update member action

    Upon receipt of a member update request, certain attribute checks
    are done, which may result in an error and prevent the update from
    being successfully completed.

    As per [1], only the "admin_state_up" attribute holds significance
    in enabling or disabling members on the ovn-provider side during
    an update operation.

    This patch remove other checks are deemed unnecessary.

    [1] https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=update-a-member-detail,list-pools-detail,create-pool-detail,batch-update-members-detail#update-a-member

    Closes-Bug: 2017127
    Change-Id: I388284968e27e0ad8ec7bb0a522aa2925b560146

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/883509

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/883510

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/883511

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/883512

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/883513

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/883509
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/d3e395ac61b7696c227ad0e9621c82a98a43bd85
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit d3e395ac61b7696c227ad0e9621c82a98a43bd85
Author: Fernando Royo <email address hidden>
Date: Thu Apr 20 13:04:33 2023 +0200

    Fix update member action

    Upon receipt of a member update request, certain attribute checks
    are done, which may result in an error and prevent the update from
    being successfully completed.

    As per [1], only the "admin_state_up" attribute holds significance
    in enabling or disabling members on the ovn-provider side during
    an update operation.

    This patch remove other checks are deemed unnecessary.

    [1] https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=update-a-member-detail,list-pools-detail,create-pool-detail,batch-update-members-detail#update-a-member

    Closes-Bug: 2017127
    Change-Id: I388284968e27e0ad8ec7bb0a522aa2925b560146
    (cherry picked from commit 8beeeb9112f6c61758f844774bfe4c5d6e8c6a08)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/883510
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/187d3fcc4f1d8278f35802e0d9e65fc50c8c540d
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 187d3fcc4f1d8278f35802e0d9e65fc50c8c540d
Author: Fernando Royo <email address hidden>
Date: Thu Apr 20 13:04:33 2023 +0200

    Fix update member action

    Upon receipt of a member update request, certain attribute checks
    are done, which may result in an error and prevent the update from
    being successfully completed.

    As per [1], only the "admin_state_up" attribute holds significance
    in enabling or disabling members on the ovn-provider side during
    an update operation.

    This patch remove other checks are deemed unnecessary.

    [1] https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=update-a-member-detail,list-pools-detail,create-pool-detail,batch-update-members-detail#update-a-member

    Closes-Bug: 2017127
    Change-Id: I388284968e27e0ad8ec7bb0a522aa2925b560146
    (cherry picked from commit 8beeeb9112f6c61758f844774bfe4c5d6e8c6a08)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/883511
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/f6ce0a2dd45acad2e4ed0cbf86d42e5f10026151
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit f6ce0a2dd45acad2e4ed0cbf86d42e5f10026151
Author: Fernando Royo <email address hidden>
Date: Thu Apr 20 13:04:33 2023 +0200

    Fix update member action

    Upon receipt of a member update request, certain attribute checks
    are done, which may result in an error and prevent the update from
    being successfully completed.

    As per [1], only the "admin_state_up" attribute holds significance
    in enabling or disabling members on the ovn-provider side during
    an update operation.

    This patch remove other checks are deemed unnecessary.

    [1] https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=update-a-member-detail,list-pools-detail,create-pool-detail,batch-update-members-detail#update-a-member

    Closes-Bug: 2017127
    Change-Id: I388284968e27e0ad8ec7bb0a522aa2925b560146
    (cherry picked from commit 8beeeb9112f6c61758f844774bfe4c5d6e8c6a08)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/883512
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/8a46ce4f078a524be849eafd6dd853cebe92c1d5
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 8a46ce4f078a524be849eafd6dd853cebe92c1d5
Author: Fernando Royo <email address hidden>
Date: Thu Apr 20 13:04:33 2023 +0200

    Fix update member action

    Upon receipt of a member update request, certain attribute checks
    are done, which may result in an error and prevent the update from
    being successfully completed.

    As per [1], only the "admin_state_up" attribute holds significance
    in enabling or disabling members on the ovn-provider side during
    an update operation.

    This patch remove other checks are deemed unnecessary.

    [1] https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=update-a-member-detail,list-pools-detail,create-pool-detail,batch-update-members-detail#update-a-member

    Closes-Bug: 2017127
    Change-Id: I388284968e27e0ad8ec7bb0a522aa2925b560146
    (cherry picked from commit 8beeeb9112f6c61758f844774bfe4c5d6e8c6a08)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/883513
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/ff20040a28f2db4ef07974f0b18d5ee43e4d5148
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit ff20040a28f2db4ef07974f0b18d5ee43e4d5148
Author: Fernando Royo <email address hidden>
Date: Thu Apr 20 13:04:33 2023 +0200

    Fix update member action

    Upon receipt of a member update request, certain attribute checks
    are done, which may result in an error and prevent the update from
    being successfully completed.

    As per [1], only the "admin_state_up" attribute holds significance
    in enabling or disabling members on the ovn-provider side during
    an update operation.

    This patch remove other checks are deemed unnecessary.

    [1] https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=update-a-member-detail,list-pools-detail,create-pool-detail,batch-update-members-detail#update-a-member

    Conflicts:
          ovn_octavia_provider/helper.py

    Closes-Bug: 2017127
    Change-Id: I388284968e27e0ad8ec7bb0a522aa2925b560146
    (cherry picked from commit 8beeeb9112f6c61758f844774bfe4c5d6e8c6a08)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 4.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 3.1.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 2.1.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 5.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider wallaby-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider xena-eom release.