UTs "TestMeteringPlugin" failing with new neutron-lib 3.5.0 release

[Rodolfo Alonso]

neutron-lib 3.5.0 released yesterday.

Patch affected: https://review.opendev.org/c/openstack/requirements/+/880278

Logs: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_1c2/880278/1/check/cross-neutron-py310/1c2bbc3/testr_results.html

Snippet: https://paste.opendev.org/show/bwRYjJB54O20iK4b8n1d/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/880309

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/880338

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/880340

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/880341

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/880338
Committed: https://opendev.org/openstack/neutron/commit/c7ef8249419ecbefdc4a604a98d4b23554c78dae
Submitter: "Zuul (22348)"
Branch: master

commit c7ef8249419ecbefdc4a604a98d4b23554c78dae
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Apr 13 17:54:47 2023 +0200

    Do not check the context object in ``TestMeteringPlugin``

    Since [1], the admin context is not ``Context`` object created
    but the new one created in ``ContextBase.elevated``. This method
    copies the object itself (creating a new one), adds the "admin"
    role (if not present) and returns this new object.

    Because this method always returns a new object, it is not possible
    to check the ``Context`` object used to make the function call, as
    long as the test doesn't store the elevated context used in the call
    (apart from the reference stored in the mock object).

    [1]https://review.opendev.org/c/openstack/neutron-lib/+/880143

    Closes-Bug: #2016144
    Change-Id: I5d7eb73606428841caa24ce1e38d1bebd5db0a9b

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/880340
Committed: https://opendev.org/openstack/neutron/commit/6efae0b110af0ea6ee92a9ef774cd702db3b834e
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 6efae0b110af0ea6ee92a9ef774cd702db3b834e
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Apr 13 17:54:47 2023 +0200

    Do not check the context object in ``TestMeteringPlugin``

    Since [1], the admin context is not ``Context`` object created
    but the new one created in ``ContextBase.elevated``. This method
    copies the object itself (creating a new one), adds the "admin"
    role (if not present) and returns this new object.

    Because this method always returns a new object, it is not possible
    to check the ``Context`` object used to make the function call, as
    long as the test doesn't store the elevated context used in the call
    (apart from the reference stored in the mock object).

    [1]https://review.opendev.org/c/openstack/neutron-lib/+/880143

    Closes-Bug: #2016144
    Change-Id: I5d7eb73606428841caa24ce1e38d1bebd5db0a9b
    (cherry picked from commit c7ef8249419ecbefdc4a604a98d4b23554c78dae)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/880341
Committed: https://opendev.org/openstack/neutron/commit/b43c9a6ec053336af8bf6a4b0188cbd4ea2e7cb6
Submitter: "Zuul (22348)"
Branch: stable/zed

commit b43c9a6ec053336af8bf6a4b0188cbd4ea2e7cb6
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Apr 13 17:54:47 2023 +0200

    Do not check the context object in ``TestMeteringPlugin``

    Since [1], the admin context is not ``Context`` object created
    but the new one created in ``ContextBase.elevated``. This method
    copies the object itself (creating a new one), adds the "admin"
    role (if not present) and returns this new object.

    Because this method always returns a new object, it is not possible
    to check the ``Context`` object used to make the function call, as
    long as the test doesn't store the elevated context used in the call
    (apart from the reference stored in the mock object).

    [1]https://review.opendev.org/c/openstack/neutron-lib/+/880143

    Closes-Bug: #2016144
    Change-Id: I5d7eb73606428841caa24ce1e38d1bebd5db0a9b
    (cherry picked from commit c7ef8249419ecbefdc4a604a98d4b23554c78dae)

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Brian Haley <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/880309
Reason: Doesn't seem necessary any more, https://review.opendev.org/c/openstack/neutron/+/880338 fixed the issue.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 23.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 22.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 21.1.1 release.