ovn qos extension: update router does not remove no longer present qos rules

[Frode Nordahl]

Let's say you set up both ingress and egress QoS rules for a project and then create a router. If you then subsequently remove one or both of the rules and update a router, these rules will not be removed from the OVN database.

If you update QoS rules for a project and update the router, those rules are also updated, so that part works as expected.

The expected outcome is that if one or both of the rules are removed, a call to update router should remove those rules from the OVN database.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/877603

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Hello Frode:

Please check [1]. There was a little mistake in the test. I've tested manually with this code and is working fine. I've also manually tested adding, updating and removing QoS policies and rules from a router and I see how the QoS registers, related to the GW port, are correctly updated.

Regards.

[1]https://review.opendev.org/c/openstack/neutron/+/877603/7..8/neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/ovsdb/extensions/test_qos.py