Startup times for large OVN dbs is greatly increased by frozen_row() calls

Bug #2011590 reported by Terry Wilson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Unassigned

Bug Description

On a large OVN DB, frozen_row() calls for the event notification processing can add 10ms up to 40ms or more depending on the size of the row (as compared to 4usec for just passing the Row object). This can easily make startup times w/ large DBs increase by a factor of 3 or more.

We are currently calling frozen_row() for every event, but we really only need it for the events that we have registered.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/877383

Changed in neutron:
status: New → In Progress
Changed in neutron:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/877517

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/877518

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/877519

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/877520

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/877521

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/877383
Committed: https://opendev.org/openstack/neutron/commit/dea48cfc0a491c63e5a3f899e545b3e8768cbb80
Submitter: "Zuul (22348)"
Branch: master

commit dea48cfc0a491c63e5a3f899e545b3e8768cbb80
Author: Terry Wilson <email address hidden>
Date: Tue Mar 14 09:39:32 2023 -0500

    Only create a frozen Row on matching events

    It is very wasteful to create a frozen row copy for every event
    that we process. It can dramatically increase the time to process
    the initial events from connecting to the database.

    Closes-bug: #2011590
    Change-Id: Ic4bf26d9b1f937073ddc6d0c3e9d22a777912ebf

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/877517
Committed: https://opendev.org/openstack/neutron/commit/8c89c3e5d0157fdf2ad49b18b1a4be043e29d30a
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 8c89c3e5d0157fdf2ad49b18b1a4be043e29d30a
Author: Terry Wilson <email address hidden>
Date: Tue Mar 14 09:39:32 2023 -0500

    Only create a frozen Row on matching events

    It is very wasteful to create a frozen row copy for every event
    that we process. It can dramatically increase the time to process
    the initial events from connecting to the database.

    Closes-bug: #2011590
    Change-Id: Ic4bf26d9b1f937073ddc6d0c3e9d22a777912ebf
    (cherry picked from commit dea48cfc0a491c63e5a3f899e545b3e8768cbb80)

tags: added: in-stable-zed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/877518
Committed: https://opendev.org/openstack/neutron/commit/0091a25ea65e14bbc56c0b816617f61a74bb35aa
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 0091a25ea65e14bbc56c0b816617f61a74bb35aa
Author: Terry Wilson <email address hidden>
Date: Tue Mar 14 09:39:32 2023 -0500

    Only create a frozen Row on matching events

    It is very wasteful to create a frozen row copy for every event
    that we process. It can dramatically increase the time to process
    the initial events from connecting to the database.

    Closes-bug: #2011590
    Change-Id: Ic4bf26d9b1f937073ddc6d0c3e9d22a777912ebf
    (cherry picked from commit dea48cfc0a491c63e5a3f899e545b3e8768cbb80)

tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/877519
Committed: https://opendev.org/openstack/neutron/commit/0152a6087f202d6c0b2b821ff9b9bd352805adb7
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 0152a6087f202d6c0b2b821ff9b9bd352805adb7
Author: Terry Wilson <email address hidden>
Date: Tue Mar 14 09:39:32 2023 -0500

    Only create a frozen Row on matching events

    It is very wasteful to create a frozen row copy for every event
    that we process. It can dramatically increase the time to process
    the initial events from connecting to the database.

    Closes-bug: #2011590
    Change-Id: Ic4bf26d9b1f937073ddc6d0c3e9d22a777912ebf
    (cherry picked from commit dea48cfc0a491c63e5a3f899e545b3e8768cbb80)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/877520
Committed: https://opendev.org/openstack/neutron/commit/7ca09bfc2e7b489bd541895a6d35164022905284
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 7ca09bfc2e7b489bd541895a6d35164022905284
Author: Terry Wilson <email address hidden>
Date: Tue Mar 14 09:39:32 2023 -0500

    Only create a frozen Row on matching events

    It is very wasteful to create a frozen row copy for every event
    that we process. It can dramatically increase the time to process
    the initial events from connecting to the database.

    Closes-bug: #2011590
    Change-Id: Ic4bf26d9b1f937073ddc6d0c3e9d22a777912ebf
    (cherry picked from commit dea48cfc0a491c63e5a3f899e545b3e8768cbb80)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/877521
Committed: https://opendev.org/openstack/neutron/commit/e941180b68659a53c3c68705915a92552d3fe25c
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit e941180b68659a53c3c68705915a92552d3fe25c
Author: Terry Wilson <email address hidden>
Date: Tue Mar 14 09:39:32 2023 -0500

    Only create a frozen Row on matching events

    It is very wasteful to create a frozen row copy for every event
    that we process. It can dramatically increase the time to process
    the initial events from connecting to the database.

    Closes-bug: #2011590
    Change-Id: Ic4bf26d9b1f937073ddc6d0c3e9d22a777912ebf
    (cherry picked from commit dea48cfc0a491c63e5a3f899e545b3e8768cbb80)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 22.0.0.0rc2

This issue was fixed in the openstack/neutron 22.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 19.7.0

This issue was fixed in the openstack/neutron 19.7.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 23.0.0.0b2

This issue was fixed in the openstack/neutron 23.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 21.1.1

This issue was fixed in the openstack/neutron 21.1.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 20.3.1

This issue was fixed in the openstack/neutron 20.3.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron wallaby-eom

This issue was fixed in the openstack/neutron wallaby-eom release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.