neutron

[OVS] Error during OVS agent start

Bug #2009215 reported by Rodolfo Alonso on 2023-03-03

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	neutron	Fix Released	High	Sahid Orentino

Bug Description

During the OVS agent initialization, in the first loop, all the ports present in the OVS are processed. In [1]->[2]->[3]...->[4]->[5], the vlan manager raises an exception "MappingNotFound" that is not catch by the try/except context. This exception was handled before [6].

The vlan manager is updated after this first loop and the network is added to the vlan manager dictionary.

This exception [7] should be handled properly.

[1]https://github.com/openstack/neutron/blob/0a214b0437874fd7f5379ec94fd07ef5d3ff4bbe/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L2794
[2]https://github.com/openstack/neutron/blob/0a214b0437874fd7f5379ec94fd07ef5d3ff4bbe/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L2190
[3]https://github.com/openstack/neutron/blob/0a214b0437874fd7f5379ec94fd07ef5d3ff4bbe/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L1990
[4]https://github.com/openstack/neutron/blob/0a214b0437874fd7f5379ec94fd07ef5d3ff4bbe/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L688
[5]https://github.com/openstack/neutron/blob/0a214b0437874fd7f5379ec94fd07ef5d3ff4bbe/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L501
[6]https://review.opendev.org/c/openstack/neutron/+/839479
[7]https://paste.opendev.org/show/bp3Q5J3rUlhx5CwGzdtc/

Tags:

Rodolfo Alonso (rodolfo-alonso-hernandez) on 2023-03-03

Changed in neutron:
importance:	Undecided → High

Lajos Katona (lajos-katona) on 2023-03-06

tags:

added: ovs

Sahid Orentino (sahid-ferdjaoui) on 2023-03-06

Changed in neutron:
assignee:	nobody → Sahid Orentino (sahid-ferdjaoui)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-03-06: Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/876570

Changed in neutron:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-03-07: Change abandoned on neutron (master)

Change abandoned by "Sahid Orentino Ferdjaoui <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/876570

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-03-07: Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/876570
Committed: https://opendev.org/openstack/neutron/commit/cf96bd8bdf9751c54ba8d47569e4a1269fc61e9e
Submitter: "Zuul (22348)"
Branch: master

commit cf96bd8bdf9751c54ba8d47569e4a1269fc61e9e
Author: Sahid Orentino Ferdjaoui <email address hidden>
Date: Mon Mar 6 13:55:31 2023 +0100

ovs: fix regression when vlan mapping is not already registered

    Bug introduced by Ic3c147136549b17aea0fe78e930a41a5b33ab9d8, when a
    VLAN mapping is not registered during a call to
    update_network_segement, the function should return None.

    Closes-Bug: #2009215
    Signed-off-by: Sahid Orentino Ferdjaoui <email address hidden>
    Change-Id: I91f8e8bd18d9956216e5715c658dfb408a2cbf07

Changed in neutron:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-03-08: Fix proposed to neutron (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/876803

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-03-08: Fix proposed to neutron (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/876804

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-03-08: Fix merged to neutron (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/876803
Committed: https://opendev.org/openstack/neutron/commit/2e1adff90e64964f7026fb8584eae786007e9eac
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 2e1adff90e64964f7026fb8584eae786007e9eac
Author: Sahid Orentino Ferdjaoui <email address hidden>
Date: Mon Mar 6 13:55:31 2023 +0100

ovs: fix regression when vlan mapping is not already registered

    Bug introduced by Ic3c147136549b17aea0fe78e930a41a5b33ab9d8, when a
    VLAN mapping is not registered during a call to
    update_network_segement, the function should return None.

    Closes-Bug: #2009215
    Signed-off-by: Sahid Orentino Ferdjaoui <email address hidden>
    Change-Id: I91f8e8bd18d9956216e5715c658dfb408a2cbf07
    (cherry picked from commit cf96bd8bdf9751c54ba8d47569e4a1269fc61e9e)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-03-10: Fix merged to neutron (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/876804
Committed: https://opendev.org/openstack/neutron/commit/44cd883728b385fcbbd3f4100c609006588913cc
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 44cd883728b385fcbbd3f4100c609006588913cc
Author: Sahid Orentino Ferdjaoui <email address hidden>
Date: Mon Mar 6 13:55:31 2023 +0100

ovs: fix regression when vlan mapping is not already registered

    Bug introduced by Ic3c147136549b17aea0fe78e930a41a5b33ab9d8, when a
    VLAN mapping is not registered during a call to
    update_network_segement, the function should return None.