[sqlalchemy-20][vnpaas] SQL execution without transaction in progress

Bug #2008767 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Rodolfo Alonso

Bug Description

The following methods are not called from inside a DB context:
* ``VPNPluginDb.get_ikepolicy``
* ``VPNPluginDb.get_ikepolicies``
* ``VPNPluginDb.get_ipsecpolicy``
* ``VPNPluginDb.get_ipsecpolicies``
* ``VPNPluginDb._get_vpnservice``
* ``VPNPluginDb.get_vpnservice``
* ``VPNPluginDb.get_vpnservices``
* ``VPNPluginDb.get_endpoint_group``
* ``VPNPluginDb.get_endpoint_groups``

Logs: https://paste.opendev.org/show/bNT4RdGsrx0DlI6ja2tS/

Changed in neutron:
importance: Undecided → High
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-vpnaas (master)
Changed in neutron:
status: New → In Progress
Revision history for this message
Lajos Katona (lajos-katona) wrote :

Not sure but perhaps duplicate of this one:
https://bugs.launchpad.net/neutron/+bug/2008001

tags: added: vpn
tags: added: sqlalchemy2.0 vpnaas
removed: vpn
description: updated
description: updated
Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :

Hi Lajos:

Not exactly, actually LP#2008775 is a duplicate of LP#2008001

Regards.

Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-vpnaas (master)

Reviewed: https://review.opendev.org/c/openstack/neutron-vpnaas/+/875626
Committed: https://opendev.org/openstack/neutron-vpnaas/commit/792f2c65ec34b63ae8037a5328b7622320c4e1c4
Submitter: "Zuul (22348)"
Branch: master

commit 792f2c65ec34b63ae8037a5328b7622320c4e1c4
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Feb 28 09:34:05 2023 +0000

    [sqlalchemy-20] Add reader context to ``VPNPluginDb`` get methods

    The following methods are now called from inside a reader context:
    * ``VPNPluginDb.get_ikepolicy``
    * ``VPNPluginDb.get_ikepolicies``
    * ``VPNPluginDb.get_ipsecpolicy``
    * ``VPNPluginDb.get_ipsecpolicies``
    * ``VPNPluginDb._get_vpnservice``
    * ``VPNPluginDb.get_vpnservice``
    * ``VPNPluginDb.get_vpnservices``
    * ``VPNPluginDb.get_endpoint_group``
    * ``VPNPluginDb.get_endpoint_groups``

    This patch is also adding the writer context to
    ``BaseIPsecVPNDriver.create_vpnservice``.

    Closes-Bug: #2008767
    Closes-Bug: #2008001
    Change-Id: Ic22eb356c3157713a53cd71a366b946aa57ab042

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron-vpnaas 22.0.0.0rc1

This issue was fixed in the openstack/neutron-vpnaas 22.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.