[neutron-vpnaas] SQL error during the "vpnservice" creation

[Rodolfo Alonso]

During the VPN service creation, the Neutron API raises an SQL error [1].

That happens when executing:
  $ openstack vpn service create vpn --router router

[1]https://paste.opendev.org/show/bnOLzHQNLRgkhoJMXw0g/

[Bernard Cafarelli (bcafarel)]

Also seen in CI neutron-tempest-plugin-vpnaas jobs:
https://zuul.opendev.org/t/openstack/build/bffc7ebc67b34be3bab2eca80a50732f/log/controller/logs/screen-q-svc.txt?severity=0#526 (from https://review.opendev.org/c/openstack/neutron-vpnaas/+/765353)

neutron-vpnaas works after that so not setting high priority, but nice one to fix

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Marked https://bugs.launchpad.net/neutron/+bug/2008775 as duplicate of this LP bug.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron-vpnaas/+/875628

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Rodolfo Alonso <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/neutron-vpnaas/+/875628
Reason: Superseded by https://review.opendev.org/c/openstack/neutron-vpnaas/+/875626. We need to combine both patches in one to pass the CI.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron-vpnaas/+/875626
Committed: https://opendev.org/openstack/neutron-vpnaas/commit/792f2c65ec34b63ae8037a5328b7622320c4e1c4
Submitter: "Zuul (22348)"
Branch: master

commit 792f2c65ec34b63ae8037a5328b7622320c4e1c4
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Feb 28 09:34:05 2023 +0000

    [sqlalchemy-20] Add reader context to ``VPNPluginDb`` get methods

    The following methods are now called from inside a reader context:
    * ``VPNPluginDb.get_ikepolicy``
    * ``VPNPluginDb.get_ikepolicies``
    * ``VPNPluginDb.get_ipsecpolicy``
    * ``VPNPluginDb.get_ipsecpolicies``
    * ``VPNPluginDb._get_vpnservice``
    * ``VPNPluginDb.get_vpnservice``
    * ``VPNPluginDb.get_vpnservices``
    * ``VPNPluginDb.get_endpoint_group``
    * ``VPNPluginDb.get_endpoint_groups``

    This patch is also adding the writer context to
    ``BaseIPsecVPNDriver.create_vpnservice``.

    Closes-Bug: #2008767
    Closes-Bug: #2008001
    Change-Id: Ic22eb356c3157713a53cd71a366b946aa57ab042

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-vpnaas 22.0.0.0rc1 release candidate.