neutron

[OVN] OVN trunk driver is not setting the OVN LSP "external_ids:neutron:device_owner" value

Bug #2006735 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Rodolfo Alonso

Bug Description

The methods ``OVNTrunkHandler._set_binding_profile`` and ``OVNTrunkHandler._unset_binding_profile`` are not updating the OVN LSP device owner value (stored in "external_ids") when setting or removing the binding profile.

Rodolfo Alonso (rodolfo-alonso-hernandez)
Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
Slawek Kaplonski (slaweq)
Changed in neutron:
importance: Undecided → High
tags: added: ovn trunk
Changed in neutron:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/873247

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/873608

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/873609

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/873610

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/873611

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/873608
Committed: https://opendev.org/openstack/neutron/commit/7d8c28907ae8b67dda44ff84bdb2b64ee44c7598
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 7d8c28907ae8b67dda44ff84bdb2b64ee44c7598
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Feb 9 12:57:25 2023 +0100

    [OVN] Add missing LSP device_owner info in trunk driver

    The ``OVNTrunkHandler`` class updates the port binding profile of the
    trunk subports. The methods ``_set_binding_profile`` and
    ``_unset_binding_profile`` update both the OVN LSP register and the
    Neutron DB port register. This patch adds the missing field
    "neutron:device_owner" from the LSP external_ids dictionary.

    This patch also updates ``OvsdbNbOvnIdl.set_lswitch_port`` API method.
    The method now accepts "external_ids_update" kwarg. This dictionary
    allows to update (or add) individually each LSP.external_ids
    dictionary key, instead of overwritting the whole variable.

    NOTE: ``set_lswitch_port`` is not used outside Neutron now so this is
    safe to change the API method signature.

    Closes-Bug: #2006735
    Change-Id: I985f3294b2ca7ab5989022ec1b904c8e29354e07
    (cherry picked from commit d83e243c6d54f29ded7a0bea6e5538772fff3a8e)

tags: added: in-stable-zed
tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/873609
Committed: https://opendev.org/openstack/neutron/commit/86e2aa859dbfb2574194c185d73087f38bbfefca
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 86e2aa859dbfb2574194c185d73087f38bbfefca
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Feb 9 12:57:25 2023 +0100

    [OVN] Add missing LSP device_owner info in trunk driver

    The ``OVNTrunkHandler`` class updates the port binding profile of the
    trunk subports. The methods ``_set_binding_profile`` and
    ``_unset_binding_profile`` update both the OVN LSP register and the
    Neutron DB port register. This patch adds the missing field
    "neutron:device_owner" from the LSP external_ids dictionary.

    This patch also updates ``OvsdbNbOvnIdl.set_lswitch_port`` API method.
    The method now accepts "external_ids_update" kwarg. This dictionary
    allows to update (or add) individually each LSP.external_ids
    dictionary key, instead of overwritting the whole variable.

    NOTE: ``set_lswitch_port`` is not used outside Neutron now so this is
    safe to change the API method signature.

    Closes-Bug: #2006735
    Change-Id: I985f3294b2ca7ab5989022ec1b904c8e29354e07
    (cherry picked from commit d83e243c6d54f29ded7a0bea6e5538772fff3a8e)
    (cherry picked from commit 7d8c28907ae8b67dda44ff84bdb2b64ee44c7598)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/873610
Committed: https://opendev.org/openstack/neutron/commit/f597154473281233f63b9bc32cb607e801c368a3
Submitter: "Zuul (22348)"
Branch: stable/xena

commit f597154473281233f63b9bc32cb607e801c368a3
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Feb 9 12:57:25 2023 +0100

    [OVN] Add missing LSP device_owner info in trunk driver

    The ``OVNTrunkHandler`` class updates the port binding profile of the
    trunk subports. The methods ``_set_binding_profile`` and
    ``_unset_binding_profile`` update both the OVN LSP register and the
    Neutron DB port register. This patch adds the missing field
    "neutron:device_owner" from the LSP external_ids dictionary.

    This patch also updates ``OvsdbNbOvnIdl.set_lswitch_port`` API method.
    The method now accepts "external_ids_update" kwarg. This dictionary
    allows to update (or add) individually each LSP.external_ids
    dictionary key, instead of overwritting the whole variable.

    NOTE: ``set_lswitch_port`` is not used outside Neutron now so this is
    safe to change the API method signature.

    Closes-Bug: #2006735
    Change-Id: I985f3294b2ca7ab5989022ec1b904c8e29354e07
    (cherry picked from commit d83e243c6d54f29ded7a0bea6e5538772fff3a8e)
    (cherry picked from commit 7d8c28907ae8b67dda44ff84bdb2b64ee44c7598)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/873611
Committed: https://opendev.org/openstack/neutron/commit/570e65381bca90c23445d2e9ce6a1676ed327d90
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 570e65381bca90c23445d2e9ce6a1676ed327d90
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Feb 9 12:57:25 2023 +0100

    [OVN] Add missing LSP device_owner info in trunk driver

    The ``OVNTrunkHandler`` class updates the port binding profile of the
    trunk subports. The methods ``_set_binding_profile`` and
    ``_unset_binding_profile`` update both the OVN LSP register and the
    Neutron DB port register. This patch adds the missing field
    "neutron:device_owner" from the LSP external_ids dictionary.

    This patch also updates ``OvsdbNbOvnIdl.set_lswitch_port`` API method.
    The method now accepts "external_ids_update" kwarg. This dictionary
    allows to update (or add) individually each LSP.external_ids
    dictionary key, instead of overwritting the whole variable.

    NOTE: ``set_lswitch_port`` is not used outside Neutron now so this is
    safe to change the API method signature.

    Closes-Bug: #2006735
    Change-Id: I985f3294b2ca7ab5989022ec1b904c8e29354e07
    (cherry picked from commit d83e243c6d54f29ded7a0bea6e5538772fff3a8e)
    (cherry picked from commit 7d8c28907ae8b67dda44ff84bdb2b64ee44c7598)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/873247
Committed: https://opendev.org/openstack/neutron/commit/d83e243c6d54f29ded7a0bea6e5538772fff3a8e
Submitter: "Zuul (22348)"
Branch: master

commit d83e243c6d54f29ded7a0bea6e5538772fff3a8e
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Feb 9 12:57:25 2023 +0100

    [OVN] Add missing LSP device_owner info in trunk driver

    The ``OVNTrunkHandler`` class updates the port binding profile of the
    trunk subports. The methods ``_set_binding_profile`` and
    ``_unset_binding_profile`` update both the OVN LSP register and the
    Neutron DB port register. This patch adds the missing field
    "neutron:device_owner" from the LSP external_ids dictionary.

    This patch also updates ``OvsdbNbOvnIdl.set_lswitch_port`` API method.
    The method now accepts "external_ids_update" kwarg. This dictionary
    allows to update (or add) individually each LSP.external_ids
    dictionary key, instead of overwritting the whole variable.

    NOTE: ``set_lswitch_port`` is not used outside Neutron now so this is
    safe to change the API method signature.

    Closes-Bug: #2006735
    Change-Id: I985f3294b2ca7ab5989022ec1b904c8e29354e07

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 22.0.0.0rc1

This issue was fixed in the openstack/neutron 22.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 19.6.0

This issue was fixed in the openstack/neutron 19.6.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 20.3.0

This issue was fixed in the openstack/neutron 20.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 21.1.0

This issue was fixed in the openstack/neutron 21.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron wallaby-eom

This issue was fixed in the openstack/neutron wallaby-eom release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.