[ovn] MTU issues due to centralized vlan provider networks

[Luis Tomas Bolivar]

After this change was added [1] the traffic gets centralized not only for vlan tenant networks, but also for vlan provider networks. This means that extra reduction on the MTU size needs to be done to account for the geneve encapsulation due to traffic going through the networker node instead of directly from the node

[1] https://opendev.org/openstack/networking-ovn/commit/1440207c0d568068a37a306a7f03a81ad58e468f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/871252

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/871252
Committed: https://opendev.org/openstack/neutron/commit/acb809eea422f417d4bfb2d46918839d7d379e4c
Submitter: "Zuul (22348)"
Branch: master

commit acb809eea422f417d4bfb2d46918839d7d379e4c
Author: Luis Tomas Bolivar <email address hidden>
Date: Fri Jan 20 12:16:06 2023 +0100

    [OVN] Ensure traffic for provider vlan networks is not tunneled

    This patch adds an extra checking to ensure the
    "reside-on-redirect-chassis" is set to true for the logical
    router port associated to vlan provider network despite having
    the "ovn_distributed_floating_ip" enabled or not. This is needed
    as there is an OVN bug [1] making it not work as expected.

    Note setting this to true has implications as the traffic will be
    centrallized (but not tunneled) through the node with the gateway
    port.

    The expected behavior of this flag, once [1] is fixed is:
    - reside-on-redirect-chassis flag to False: means traffic goes
      tunneled to the controller with the gateway port. Means it requires
      extra MTU reduction to work.
    - reside-on-redirect-chassis flag to True: means traffic is not
      tunneled to the controller with the gateway port, but the traffic is
      centralized through the controller with the gateway port. Thus it
      does not require extra MTU reduction.
    - reside-on-redirect-chassis to False, but with ovn-chassis-mac-mappings
      configured: means the traffic is fully distributed and it is not being
      tunneled, nor sent, through the controller with the gateway port. This
      is the preferred option as it does not require MTU reduction and it
      avoids the extra hop. However it is not working as expected, therefore
      the fallback to set reside-on-redirect-chassis to True.

    [1] https://bugzilla.redhat.com/show_bug.cgi?id=2162756

    Closes-Bug: #2003455
    Change-Id: I662cb30c842e54bb9f7dabac5519283aa7c7f8d0

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/875673

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/875674

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/875675

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/875676

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/875673
Committed: https://opendev.org/openstack/neutron/commit/390d617d3d3c4d12284028247f5cbf19a925fc9b
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 390d617d3d3c4d12284028247f5cbf19a925fc9b
Author: Luis Tomas Bolivar <email address hidden>
Date: Fri Jan 20 12:16:06 2023 +0100

    [OVN] Ensure traffic for provider vlan networks is not tunneled

    This patch adds an extra checking to ensure the
    "reside-on-redirect-chassis" is set to true for the logical
    router port associated to vlan provider network despite having
    the "ovn_distributed_floating_ip" enabled or not. This is needed
    as there is an OVN bug [1] making it not work as expected.

    Note setting this to true has implications as the traffic will be
    centrallized (but not tunneled) through the node with the gateway
    port.

    The expected behavior of this flag, once [1] is fixed is:
    - reside-on-redirect-chassis flag to False: means traffic goes
      tunneled to the controller with the gateway port. Means it requires
      extra MTU reduction to work.
    - reside-on-redirect-chassis flag to True: means traffic is not
      tunneled to the controller with the gateway port, but the traffic is
      centralized through the controller with the gateway port. Thus it
      does not require extra MTU reduction.
    - reside-on-redirect-chassis to False, but with ovn-chassis-mac-mappings
      configured: means the traffic is fully distributed and it is not being
      tunneled, nor sent, through the controller with the gateway port. This
      is the preferred option as it does not require MTU reduction and it
      avoids the extra hop. However it is not working as expected, therefore
      the fallback to set reside-on-redirect-chassis to True.

    [1] https://bugzilla.redhat.com/show_bug.cgi?id=2162756

    Closes-Bug: #2003455
    Change-Id: I662cb30c842e54bb9f7dabac5519283aa7c7f8d0
    (cherry picked from commit acb809eea422f417d4bfb2d46918839d7d379e4c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/875674
Committed: https://opendev.org/openstack/neutron/commit/334f7733f5b655b4f06d101752c2c192640a1f14
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 334f7733f5b655b4f06d101752c2c192640a1f14
Author: Luis Tomas Bolivar <email address hidden>
Date: Fri Jan 20 12:16:06 2023 +0100

    [OVN] Ensure traffic for provider vlan networks is not tunneled

    This patch adds an extra checking to ensure the
    "reside-on-redirect-chassis" is set to true for the logical
    router port associated to vlan provider network despite having
    the "ovn_distributed_floating_ip" enabled or not. This is needed
    as there is an OVN bug [1] making it not work as expected.

    Note setting this to true has implications as the traffic will be
    centrallized (but not tunneled) through the node with the gateway
    port.

    The expected behavior of this flag, once [1] is fixed is:
    - reside-on-redirect-chassis flag to False: means traffic goes
      tunneled to the controller with the gateway port. Means it requires
      extra MTU reduction to work.
    - reside-on-redirect-chassis flag to True: means traffic is not
      tunneled to the controller with the gateway port, but the traffic is
      centralized through the controller with the gateway port. Thus it
      does not require extra MTU reduction.
    - reside-on-redirect-chassis to False, but with ovn-chassis-mac-mappings
      configured: means the traffic is fully distributed and it is not being
      tunneled, nor sent, through the controller with the gateway port. This
      is the preferred option as it does not require MTU reduction and it
      avoids the extra hop. However it is not working as expected, therefore
      the fallback to set reside-on-redirect-chassis to True.

    [1] https://bugzilla.redhat.com/show_bug.cgi?id=2162756

    Closes-Bug: #2003455
    Change-Id: I662cb30c842e54bb9f7dabac5519283aa7c7f8d0
    (cherry picked from commit acb809eea422f417d4bfb2d46918839d7d379e4c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/875675
Committed: https://opendev.org/openstack/neutron/commit/80933556beb303d093304c0f27394a39210becc9
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 80933556beb303d093304c0f27394a39210becc9
Author: Luis Tomas Bolivar <email address hidden>
Date: Fri Jan 20 12:16:06 2023 +0100

    [OVN] Ensure traffic for provider vlan networks is not tunneled

    This patch adds an extra checking to ensure the
    "reside-on-redirect-chassis" is set to true for the logical
    router port associated to vlan provider network despite having
    the "ovn_distributed_floating_ip" enabled or not. This is needed
    as there is an OVN bug [1] making it not work as expected.

    Note setting this to true has implications as the traffic will be
    centrallized (but not tunneled) through the node with the gateway
    port.

    The expected behavior of this flag, once [1] is fixed is:
    - reside-on-redirect-chassis flag to False: means traffic goes
      tunneled to the controller with the gateway port. Means it requires
      extra MTU reduction to work.
    - reside-on-redirect-chassis flag to True: means traffic is not
      tunneled to the controller with the gateway port, but the traffic is
      centralized through the controller with the gateway port. Thus it
      does not require extra MTU reduction.
    - reside-on-redirect-chassis to False, but with ovn-chassis-mac-mappings
      configured: means the traffic is fully distributed and it is not being
      tunneled, nor sent, through the controller with the gateway port. This
      is the preferred option as it does not require MTU reduction and it
      avoids the extra hop. However it is not working as expected, therefore
      the fallback to set reside-on-redirect-chassis to True.

    [1] https://bugzilla.redhat.com/show_bug.cgi?id=2162756

    Closes-Bug: #2003455
    Change-Id: I662cb30c842e54bb9f7dabac5519283aa7c7f8d0
    (cherry picked from commit acb809eea422f417d4bfb2d46918839d7d379e4c)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/875644

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 22.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/875676
Committed: https://opendev.org/openstack/neutron/commit/b8bff331b43acb9b95ec7f0997d28d0588fdc722
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit b8bff331b43acb9b95ec7f0997d28d0588fdc722
Author: Luis Tomas Bolivar <email address hidden>
Date: Fri Jan 20 12:16:06 2023 +0100

    [OVN] Ensure traffic for provider vlan networks is not tunneled

    This patch adds an extra checking to ensure the
    "reside-on-redirect-chassis" is set to true for the logical
    router port associated to vlan provider network despite having
    the "ovn_distributed_floating_ip" enabled or not. This is needed
    as there is an OVN bug [1] making it not work as expected.

    Note setting this to true has implications as the traffic will be
    centrallized (but not tunneled) through the node with the gateway
    port.

    The expected behavior of this flag, once [1] is fixed is:
    - reside-on-redirect-chassis flag to False: means traffic goes
      tunneled to the controller with the gateway port. Means it requires
      extra MTU reduction to work.
    - reside-on-redirect-chassis flag to True: means traffic is not
      tunneled to the controller with the gateway port, but the traffic is
      centralized through the controller with the gateway port. Thus it
      does not require extra MTU reduction.
    - reside-on-redirect-chassis to False, but with ovn-chassis-mac-mappings
      configured: means the traffic is fully distributed and it is not being
      tunneled, nor sent, through the controller with the gateway port. This
      is the preferred option as it does not require MTU reduction and it
      avoids the extra hop. However it is not working as expected, therefore
      the fallback to set reside-on-redirect-chassis to True.

    [1] https://bugzilla.redhat.com/show_bug.cgi?id=2162756

    Closes-Bug: #2003455
    Change-Id: I662cb30c842e54bb9f7dabac5519283aa7c7f8d0
    (cherry picked from commit acb809eea422f417d4bfb2d46918839d7d379e4c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/875644
Committed: https://opendev.org/openstack/neutron/commit/8e3bddbf8bc5296143357d3df7fd27aeb9bb9bd9
Submitter: "Zuul (22348)"
Branch: master

commit 8e3bddbf8bc5296143357d3df7fd27aeb9bb9bd9
Author: Luis Tomas Bolivar <email address hidden>
Date: Thu Mar 2 11:04:11 2023 +0100

    Ensure vlan network traffic is not centralized

    This patch partly reverts the workaround introduced at [1].

    In patch [1] the reside-on-redirect-chassis was forced for vlan provider
    networks to force centralized but not tunneled traffic for those
    network. In this patch we are making use of the "redirect-type" flag
    instead so that the traffic can be distributed and still not tunneled.
    This flag needs to be set on the router gateway port (port connecting
    the router to the external network) unlike the previous one that was set
    on the router interface port (port connecting the (vlan) internal
    network to the router). In this patch we are setting it on all ovn
    gateway ports if DVR is enabled, as:
    - It is needed for vlan (provider) network to have their traffic
      distributed instead of tunneled to the controller where the cr-lrp is
      associated
    - It is not having any effect on the geneve tenant networks as it only
      applies to network that has a localnet port associated to them.

    [1] https://review.opendev.org/c/openstack/neutron/+/871252

    Closes-Bug: #2003455
    Change-Id: Ia05416df88904e864d4fc9760ffcdc97a4651f9f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/877253

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/877254

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/877255

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/877257

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/877258

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/877258
Committed: https://opendev.org/openstack/neutron/commit/15053cae8461a8314249d3bc667f5bcaadb7994e
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 15053cae8461a8314249d3bc667f5bcaadb7994e
Author: Luis Tomas Bolivar <email address hidden>
Date: Thu Mar 2 11:04:11 2023 +0100

    Ensure vlan network traffic is not centralized

    This patch partly reverts the workaround introduced at [1].

    In patch [1] the reside-on-redirect-chassis was forced for vlan provider
    networks to force centralized but not tunneled traffic for those
    network. In this patch we are making use of the "redirect-type" flag
    instead so that the traffic can be distributed and still not tunneled.
    This flag needs to be set on the router gateway port (port connecting
    the router to the external network) unlike the previous one that was set
    on the router interface port (port connecting the (vlan) internal
    network to the router). In this patch we are setting it on all ovn
    gateway ports if DVR is enabled, as:
    - It is needed for vlan (provider) network to have their traffic
      distributed instead of tunneled to the controller where the cr-lrp is
      associated
    - It is not having any effect on the geneve tenant networks as it only
      applies to network that has a localnet port associated to them.

    [1] https://review.opendev.org/c/openstack/neutron/+/871252

    Closes-Bug: #2003455
    Change-Id: Ia05416df88904e864d4fc9760ffcdc97a4651f9f
    (cherry picked from commit 8e3bddbf8bc5296143357d3df7fd27aeb9bb9bd9)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/877254
Committed: https://opendev.org/openstack/neutron/commit/f83a97dea21c4d60cb2da16984fffcfb231fc239
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit f83a97dea21c4d60cb2da16984fffcfb231fc239
Author: Luis Tomas Bolivar <email address hidden>
Date: Thu Mar 2 11:04:11 2023 +0100

    Ensure vlan network traffic is not centralized

    This patch partly reverts the workaround introduced at [1].

    In patch [1] the reside-on-redirect-chassis was forced for vlan provider
    networks to force centralized but not tunneled traffic for those
    network. In this patch we are making use of the "redirect-type" flag
    instead so that the traffic can be distributed and still not tunneled.
    This flag needs to be set on the router gateway port (port connecting
    the router to the external network) unlike the previous one that was set
    on the router interface port (port connecting the (vlan) internal
    network to the router). In this patch we are setting it on all ovn
    gateway ports if DVR is enabled, as:
    - It is needed for vlan (provider) network to have their traffic
      distributed instead of tunneled to the controller where the cr-lrp is
      associated
    - It is not having any effect on the geneve tenant networks as it only
      applies to network that has a localnet port associated to them.

    [1] https://review.opendev.org/c/openstack/neutron/+/871252

    Closes-Bug: #2003455
    Change-Id: Ia05416df88904e864d4fc9760ffcdc97a4651f9f
    (cherry picked from commit 8e3bddbf8bc5296143357d3df7fd27aeb9bb9bd9)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/877255
Committed: https://opendev.org/openstack/neutron/commit/fe0ffa1a2ea147835a1c55cb4c18cbb1c497c7e6
Submitter: "Zuul (22348)"
Branch: stable/xena

commit fe0ffa1a2ea147835a1c55cb4c18cbb1c497c7e6
Author: Luis Tomas Bolivar <email address hidden>
Date: Thu Mar 2 11:04:11 2023 +0100

    Ensure vlan network traffic is not centralized

    This patch partly reverts the workaround introduced at [1].

    In patch [1] the reside-on-redirect-chassis was forced for vlan provider
    networks to force centralized but not tunneled traffic for those
    network. In this patch we are making use of the "redirect-type" flag
    instead so that the traffic can be distributed and still not tunneled.
    This flag needs to be set on the router gateway port (port connecting
    the router to the external network) unlike the previous one that was set
    on the router interface port (port connecting the (vlan) internal
    network to the router). In this patch we are setting it on all ovn
    gateway ports if DVR is enabled, as:
    - It is needed for vlan (provider) network to have their traffic
      distributed instead of tunneled to the controller where the cr-lrp is
      associated
    - It is not having any effect on the geneve tenant networks as it only
      applies to network that has a localnet port associated to them.

    [1] https://review.opendev.org/c/openstack/neutron/+/871252

    Closes-Bug: #2003455
    Change-Id: Ia05416df88904e864d4fc9760ffcdc97a4651f9f
    (cherry picked from commit 8e3bddbf8bc5296143357d3df7fd27aeb9bb9bd9)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/877257
Committed: https://opendev.org/openstack/neutron/commit/786d89fee0dca2914a0fce2dc39761c55c917f81
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 786d89fee0dca2914a0fce2dc39761c55c917f81
Author: Luis Tomas Bolivar <email address hidden>
Date: Thu Mar 2 11:04:11 2023 +0100

    Ensure vlan network traffic is not centralized

    This patch partly reverts the workaround introduced at [1].

    In patch [1] the reside-on-redirect-chassis was forced for vlan provider
    networks to force centralized but not tunneled traffic for those
    network. In this patch we are making use of the "redirect-type" flag
    instead so that the traffic can be distributed and still not tunneled.
    This flag needs to be set on the router gateway port (port connecting
    the router to the external network) unlike the previous one that was set
    on the router interface port (port connecting the (vlan) internal
    network to the router). In this patch we are setting it on all ovn
    gateway ports if DVR is enabled, as:
    - It is needed for vlan (provider) network to have their traffic
      distributed instead of tunneled to the controller where the cr-lrp is
      associated
    - It is not having any effect on the geneve tenant networks as it only
      applies to network that has a localnet port associated to them.

    [1] https://review.opendev.org/c/openstack/neutron/+/871252

    Closes-Bug: #2003455
    Change-Id: Ia05416df88904e864d4fc9760ffcdc97a4651f9f
    (cherry picked from commit 8e3bddbf8bc5296143357d3df7fd27aeb9bb9bd9)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 19.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 20.3.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/877253
Committed: https://opendev.org/openstack/neutron/commit/a415bb4c98fa0a7b30f36cf9d2811576181fadf5
Submitter: "Zuul (22348)"
Branch: stable/zed

commit a415bb4c98fa0a7b30f36cf9d2811576181fadf5
Author: Luis Tomas Bolivar <email address hidden>
Date: Thu Mar 2 11:04:11 2023 +0100

    Ensure vlan network traffic is not centralized

    This patch partly reverts the workaround introduced at [1].

    In patch [1] the reside-on-redirect-chassis was forced for vlan provider
    networks to force centralized but not tunneled traffic for those
    network. In this patch we are making use of the "redirect-type" flag
    instead so that the traffic can be distributed and still not tunneled.
    This flag needs to be set on the router gateway port (port connecting
    the router to the external network) unlike the previous one that was set
    on the router interface port (port connecting the (vlan) internal
    network to the router). In this patch we are setting it on all ovn
    gateway ports if DVR is enabled, as:
    - It is needed for vlan (provider) network to have their traffic
      distributed instead of tunneled to the controller where the cr-lrp is
      associated
    - It is not having any effect on the geneve tenant networks as it only
      applies to network that has a localnet port associated to them.

    [1] https://review.opendev.org/c/openstack/neutron/+/871252

    Closes-Bug: #2003455
    Change-Id: Ia05416df88904e864d4fc9760ffcdc97a4651f9f
    (cherry picked from commit 8e3bddbf8bc5296143357d3df7fd27aeb9bb9bd9)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 21.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 22.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 19.7.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 23.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 21.1.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 20.3.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron wallaby-eom release.