[OVN] Cannot update network with external ports

[Bartosz Bezak]

[OVN] Cannot update networks with external ports, and Maintenance task for availability zones changes is failing:

stable/zed

Maintenance task: Failed to fix resource 4ec5215b-1599-4c66-a7d1-5a75f26bcb41 (type: networks): AttributeError: 'str' object has no attribute 'external_ids'
2022-12-28 13:16:33.919 34 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance Traceback (most recent call last):
2022-12-28 13:16:33.919 34 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance File "/var/lib/kolla/venv/lib/python3.6/site-packages/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py", line 397, in check_for_inconsistencies
2022-12-28 13:16:33.919 34 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance self._fix_create_update(admin_context, row)
2022-12-28 13:16:33.919 34 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance File "/var/lib/kolla/venv/lib/python3.6/site-packages/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py", line 255, in _fix_create_update
2022-12-28 13:16:33.919 34 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance res_map['ovn_update'](context, n_obj)
2022-12-28 13:16:33.919 34 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance File "/var/lib/kolla/venv/lib/python3.6/site-packages/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py", line 1993, in update_network
2022-12-28 13:16:33.919 34 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance ovn_ls_azs = lswitch_name.external_ids.get(
2022-12-28 13:16:33.919 34 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance AttributeError: 'str' object has no attribute 'external_ids'
2022-12-28 13:16:33.919 34 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance

[Bence Romsics (bence-romsics)]

Thanks for working on this!

Let me link your proposed change here:
https://review.opendev.org/c/openstack/neutron/+/868746

[Bartosz Bezak (bbezak)]

In addition the impact is that one cannot update network with ovn external ports (SRIOV, Baremetal) it got introduced with https://review.opendev.org/c/openstack/neutron/+/762550, impacting xena onwards.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/869111

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/869112

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/869113

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/868746
Committed: https://opendev.org/openstack/neutron/commit/5e19eaadbb298aaf58b5389fea74c9b8064d0f41
Submitter: "Zuul (22348)"
Branch: master

commit 5e19eaadbb298aaf58b5389fea74c9b8064d0f41
Author: Bartosz Bezak <email address hidden>
Date: Wed Dec 28 14:47:21 2022 +0100

    [OVN] Fix availability zones changes check

    Closes-Bug: #2000634

    Change-Id: Id5f34ec858a940d2fc4a03b9290adc6161aa9db3

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/869111
Committed: https://opendev.org/openstack/neutron/commit/c5532b6c6b5257e58995087baf3127cbc4ba2d5a
Submitter: "Zuul (22348)"
Branch: stable/zed

commit c5532b6c6b5257e58995087baf3127cbc4ba2d5a
Author: Bartosz Bezak <email address hidden>
Date: Wed Dec 28 14:47:21 2022 +0100

    [OVN] Fix availability zones changes check

    Closes-Bug: #2000634

    Change-Id: Id5f34ec858a940d2fc4a03b9290adc6161aa9db3
    (cherry picked from commit 5e19eaadbb298aaf58b5389fea74c9b8064d0f41)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/869112
Committed: https://opendev.org/openstack/neutron/commit/2bf242a375933bc819493ee80f3aad98854f8e78
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 2bf242a375933bc819493ee80f3aad98854f8e78
Author: Bartosz Bezak <email address hidden>
Date: Wed Dec 28 14:47:21 2022 +0100

    [OVN] Fix availability zones changes check

    Closes-Bug: #2000634

    Change-Id: Id5f34ec858a940d2fc4a03b9290adc6161aa9db3
    (cherry picked from commit 5e19eaadbb298aaf58b5389fea74c9b8064d0f41)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/869113
Committed: https://opendev.org/openstack/neutron/commit/8bd833185d2795f42fa3369321a3eba072d84a45
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 8bd833185d2795f42fa3369321a3eba072d84a45
Author: Bartosz Bezak <email address hidden>
Date: Wed Dec 28 14:47:21 2022 +0100

    [OVN] Fix availability zones changes check

    Closes-Bug: #2000634

    Change-Id: Id5f34ec858a940d2fc4a03b9290adc6161aa9db3
    (cherry picked from commit 5e19eaadbb298aaf58b5389fea74c9b8064d0f41)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 19.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 22.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 20.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 21.1.0 release.