tox4 is breaking Neutron CI (most of the jobs)

[Rodolfo Alonso]

With [1], still not merged, the Neutron CI jobs do not install Neutron project.

Infra folks suspect that we need to change tox variable "usedevelop" to "use_develop", to make the project editable (access to the Neutron code from the local repository directory).

[1]https://review.opendev.org/c/zuul/zuul-jobs/+/866943

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

The rootwrap_deploy.sh script is failing with tox4. This is because:
1) Since [1], we consider that the $dst_rootwrap_path variable is a relative patch and we make it absolute.
2) With tox4, the $toxinidir directory is absolute (with tox3 was relative). E.g. (from functional CI tests):
* tox3: https://paste.opendev.org/show/bdrCH1AQKxdzFP6xKdgm/
* tox4: https://paste.opendev.org/show/bo2QQEJY0efNW2thWUpi/

In order to be compatible with both versions, we need to check if $dst_rootwrap_path is absolute or not.

[1]https://review.opendev.org/c/openstack/neutron/+/707697

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Patch: https://review.opendev.org/c/openstack/neutron/+/867554

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/867977

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/867977
Committed: https://opendev.org/openstack/neutron/commit/8bcaf1632f93633925a6f6bb2647b4007e2562f9
Submitter: "Zuul (22348)"
Branch: master

commit 8bcaf1632f93633925a6f6bb2647b4007e2562f9
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat Dec 10 16:34:48 2022 +0100

    Limit tox version to <4

    This patch is a workaround until we find why fullstack job is failing
    with tox 4.

    Depends-On: https://review.opendev.org/c/zuul/zuul-jobs/+/866943

    Related-Bug: #1999558
    Change-Id: I9c62d429bb819336da05055fecd08e3816986bf8

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/868515

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/868516

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/868517

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/868518

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/868519

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/868520

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/868379
Committed: https://opendev.org/openstack/neutron/commit/08e485d0cd97123ac8eb43b6a93b315273f70c91
Submitter: "Zuul (22348)"
Branch: master

commit 08e485d0cd97123ac8eb43b6a93b315273f70c91
Author: Slawek Kaplonski <email address hidden>
Date: Thu Dec 22 10:15:02 2022 +0100

    Ignore python warnings in the neutron-status functional tests

    There is functional test which asserts on the stderr of the
    neutron-status command. We should ensure that there is no any python
    warning about e.g. deprecation printed there as that may cause test
    failure.

    Related-Bug: #1999558
    Change-Id: Ifb958f174f8173b330d3cf7a8a8afa182c52a421

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/868517
Committed: https://opendev.org/openstack/neutron/commit/b5da174aa3c24e77a56ceb6e98020a96ece64aab
Submitter: "Zuul (22348)"
Branch: stable/xena

commit b5da174aa3c24e77a56ceb6e98020a96ece64aab
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat Dec 10 16:34:48 2022 +0100

    Limit tox version to <4

    This patch limitis the tox version to <4 in stable/xena.

    Related-Bug: #1999558
    Change-Id: I9c62d429bb819336da05055fecd08e3816986bf8

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/868516
Committed: https://opendev.org/openstack/neutron/commit/0e18664513d579ac25c92240d8be52f513a85895
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 0e18664513d579ac25c92240d8be52f513a85895
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat Dec 10 16:34:48 2022 +0100

    Limit tox version to <4

    This patch limitis the tox version to <4 in stable/yoga.

    Related-Bug: #1999558
    Change-Id: I9c62d429bb819336da05055fecd08e3816986bf8

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/868515
Committed: https://opendev.org/openstack/neutron/commit/44ffbc97b72e60f46a8f471d7f5c56b424618213
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 44ffbc97b72e60f46a8f471d7f5c56b424618213
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat Dec 10 16:34:48 2022 +0100

    Limit tox version to <4

    This patch limitis the tox version to <4 in stable/zed.

    Related-Bug: #1999558
    Change-Id: I9c62d429bb819336da05055fecd08e3816986bf8

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/868520
Committed: https://opendev.org/openstack/neutron/commit/e99d5b66ef00a6e16038cea5792d0b2ab78aa8f5
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit e99d5b66ef00a6e16038cea5792d0b2ab78aa8f5
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat Dec 10 16:34:48 2022 +0100

    Limit tox version to <4

    This patch limitis the tox version to <4 in stable/ussuri.

    Related-Bug: #1999558
    Change-Id: I9c62d429bb819336da05055fecd08e3816986bf8

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/868519
Committed: https://opendev.org/openstack/neutron/commit/778c807e4941e93724115725051c30c4ec005f80
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 778c807e4941e93724115725051c30c4ec005f80
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat Dec 10 16:34:48 2022 +0100

    Limit tox version to <4

    This patch limitis the tox version to <4 in stable/victoria.

    Related-Bug: #1999558
    Change-Id: I9c62d429bb819336da05055fecd08e3816986bf8

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/868518
Committed: https://opendev.org/openstack/neutron/commit/723a2ef36a22e00f768c9ef5a59e710f7df0d9ce
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 723a2ef36a22e00f768c9ef5a59e710f7df0d9ce
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat Dec 10 16:34:48 2022 +0100

    Limit tox version to <4

    This patch limitis the tox version to <4 in stable/wallaby.

    Related-Bug: #1999558
    Change-Id: I9c62d429bb819336da05055fecd08e3816986bf8

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/867554
Committed: https://opendev.org/openstack/neutron/commit/c93c31852b060b748106b90b1105132d7f4e7fe7
Submitter: "Zuul (22348)"
Branch: master

commit c93c31852b060b748106b90b1105132d7f4e7fe7
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat Dec 10 11:11:35 2022 +0100

    Adapt deploy_rootwrap filters path for tox4

    This patch also fixes the issue of the deploy_rootwrap.sh script related
    to the rootwrap filters path. This path checks if the path is absolute
    (tox3) or relative (tox4) and makes it absolute in the second case.

    [1]https://github.com/tox-dev/tox/issues/2730

    Depends-On: https://review.opendev.org/c/zuul/zuul-jobs/+/866943

    Closes-Bug: #1999558
    Change-Id: I7a4a30268cb352f25bad7983b94690c0b681e5fa

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 22.0.0.0rc1 release candidate.