TypeError raised in neutron-dhcp-agent due to missing argument in clean_devices method

[Slawek Kaplonski]

I noticed in the DHCP agent logs in the CI jobs stacktraces like:

Dec 12 09:40:38.943795 nested-virt-ubuntu-jammy-ovh-bhs1-0032473968 neutron-dhcp-agent[58070]: ERROR neutron.agent.dhcp.agent [-] Unable to clean_devices dhcp for e144dc34-3938-4fbe-9973-85094ea9ee08.: TypeError: DhcpLocalProcess.clean_devices() missing 1 required positional argument: 'network'
Dec 12 09:40:38.943795 nested-virt-ubuntu-jammy-ovh-bhs1-0032473968 neutron-dhcp-agent[58070]: ERROR neutron.agent.dhcp.agent Traceback (most recent call last):
Dec 12 09:40:38.943795 nested-virt-ubuntu-jammy-ovh-bhs1-0032473968 neutron-dhcp-agent[58070]: ERROR neutron.agent.dhcp.agent File "/opt/stack/neutron/neutron/agent/dhcp/agent.py", line 255, in _call_driver
Dec 12 09:40:38.943795 nested-virt-ubuntu-jammy-ovh-bhs1-0032473968 neutron-dhcp-agent[58070]: ERROR neutron.agent.dhcp.agent rv = getattr(driver, action)(**action_kwargs)
Dec 12 09:40:38.943795 nested-virt-ubuntu-jammy-ovh-bhs1-0032473968 neutron-dhcp-agent[58070]: ERROR neutron.agent.dhcp.agent TypeError: DhcpLocalProcess.clean_devices() missing 1 required positional argument: 'network'

Example of such error: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_d8f/860270/8/check/neutron-tempest-plugin-openvswitch/d8f61ec/controller/logs/screen-q-dhcp.txt

It don't cause job failure but should be handled in better way in the code to avoid ugly stacktraces.

[Brian Haley (brian-haley)]

Is this the same as https://bugs.launchpad.net/bugs/1999388 ? Seems not finding a network in the cache could lead to both. And I pushed a change for that :)