Internal ip of FIP will not changed if updated fixed_ips of internal port

[Liu Xie]

As the title describes, if we updated fixed_ips of one internal port which associated a floatingip, but the dnat_adn_snat entry in ovn will not changed.

[Brian Haley (brian-haley)]

Hi Liu, can you give more information on this issue? For example what version of neutron are you using and what commands you are running to trigger it? Thanks.

[Liu Xie (liushy)]

version:wallaby

reproduce steps:
1.Create a new port: neutron port-create share_net

id:3eb12869-dd08-425b-8071-9750b10fc463
fixed_ips:
{"subnet_id": "a4a2a463-4e6c-4bbe-a3c7-fc0bc7e9de39", "ip_address":"192.168.111.208"}

2.Create a new floatingip: neutron floatingip-create public_net

id:07eeb37f-27ec-4f3d-b201-a632ce3193b4
floating_ip_address:172.41.0.103

3.Associated floating IP: neutron floatingip-associate 07eeb37f-27ec-4f3d-b201-a632ce3193b4 3eb12869-dd08-425b-8071-9750b10fc463

4.Update fixed_ips of internal port:
neutron port-update --fixed-ip subnet_id=a4a2a463-4e6c-4bbe-a3c7-fc0bc7e9de39,ip_address=192.168.111.209 3eb12869-dd08-425b-8071-9750b10fc463

5.Query nat list in ovn-nb:
# ovn-nbctl lr-nat-list 403071bd-67a0-437e-bcbb-0cd5bc8078d0
TYPE EXTERNAL_IP EXTERNAL_PORT LOGICAL_IP EXTERNAL_MAC LOGICAL_PORT
dnat_and_snat 172.41.0.103 192.168.111.208

We found the dnat_and_snat entry not changed.
There is not a mechanism that notify floatingip update while internal port has changed, maybe we could fix it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/867964

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

This issue, as commented in the patch under review, not only affects OVN. This should be blocked (probably) in the Neutron server API call, it should not reach the mech driver.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Slawek Kaplonski <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/867964
Reason: This review is > 4 weeks without comment, and failed Zuul jobs the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Liu Xie (liushy)]

Maybe we could raise an error when deleting/changing the fixed IP if it is linked to a FIP in ml2/plugin.

[yatin (yatinkarel)]

Patch Proposed by Liu Xie:- https://review.opendev.org/c/openstack/neutron/+/889791

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/889791
Committed: https://opendev.org/openstack/neutron/commit/aad82233eb4fa7a6354f58cd9f8fda869f77db80
Submitter: "Zuul (22348)"
Branch: master

commit aad82233eb4fa7a6354f58cd9f8fda869f77db80
Author: liushy <[e-mail]>
Date: Thu Jul 27 12:48:34 2023 +0800

    Prevent internal IP change for floating IP

    Raise an error when deleting/changing the fixed IP
    which is linked to a floating IP.

    Closes-Bug: #1999209
    Change-Id: I83a5b6c30d54435426f75f4cd1f80bf41822eec5

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 23.0.0.0rc1 release candidate.