ovs/ovn source deployment broken with ovs_branch=master

[yatin]

Since [1] jobs running with OVS_BRANCH=master are broken, fails as below:-
utilities/ovn-dbctl.c: In function ‘do_dbctl’:
utilities/ovn-dbctl.c:724:9: error: too few arguments to function ‘ctl_context_init_command’
  724 | ctl_context_init_command(ctx, c);
      | ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from utilities/ovn-dbctl.c:23:
/opt/stack/ovs/lib/db-ctl-base.h:249:6: note: declared here
  249 | void ctl_context_init_command(struct ctl_context *, struct ctl_command *,
      | ^~~~~~~~~~~~~~~~~~~~~~~~
make[1]: *** [Makefile:2352: utilities/ovn-dbctl.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/opt/stack/ovn'
make: *** [Makefile:1548: all] Error 2
+ lib/neutron_plugins/ovn_agent:compile_ovn:1 : exit_trap

Failure builds example:-
- https://zuul.opendev.org/t/openstack/build/3a900a1cfe824746ac8ffc6a27fc8ec4
- https://zuul.opendev.org/t/openstack/build/7d862338d6194a4fb3a34e8c3c67f532
- https://zuul.opendev.org/t/openstack/build/ae092f4985af41908697240e3f64f522

Until OVN repo[2] get's updated to work with ovs master we have to pin ovs to working version to get these experimental jobs back to green.

[1] https://github.com/openvswitch/ovs/commit/b8bf410a5c94173da02279b369d75875c4035959
[2] https://github.com/ovn-org/ovn

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/867004

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/867004
Committed: https://opendev.org/openstack/neutron/commit/ca73925f42220888a58d24135c1835ace416c06d
Submitter: "Zuul (22348)"
Branch: master

commit ca73925f42220888a58d24135c1835ace416c06d
Author: yatinkarel <email address hidden>
Date: Thu Dec 8 20:51:51 2022 +0530

    Pin OVS_BRANCH to working commit

    With [1] OVN main branch compilation fails, until
    main branch is fixed to work with ovs master, let's
    ping OVS_BRANCH to working commit.

    [1] https://github.com/openvswitch/ovs/commit/b8bf410

    Closes-Bug: #1999154
    Change-Id: I3453aa86cab4997ea22d0f8cb5c107871e171f67

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/867075

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/867075
Committed: https://opendev.org/openstack/neutron/commit/135daae62d8a05e6295c8ad2ddbe166d1418337b
Submitter: "Zuul (22348)"
Branch: master

commit 135daae62d8a05e6295c8ad2ddbe166d1418337b
Author: yatinkarel <email address hidden>
Date: Fri Dec 9 11:06:55 2022 +0530

    Use same ovs/ovn versions in local test setups

    Currently we using different defaults in CI and
    local run, also defaults in local run using ovs
    master branch which is broken currently. Let's
    use same version by definining defaults in
    configure_for_func_testing.sh rather than at job
    level, jobs can override these only when really
    needed.

    Drop unneeded source of functions, this was wrongly
    detecting ovs/ovn versions. Anything required
    should be sourced as part of configure_for_func_testing.sh.

    Related-Bug: #1999154
    Change-Id: I04a2b0b974d11a525c850b1e641a19749dee93f6

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/867522

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/867522
Committed: https://opendev.org/openstack/neutron/commit/b5fdad3cfb8ec60e8e7934bf55308ecf5d7661b1
Submitter: "Zuul (22348)"
Branch: master

commit b5fdad3cfb8ec60e8e7934bf55308ecf5d7661b1
Author: yatinkarel <email address hidden>
Date: Tue Dec 13 21:01:27 2022 +0530

    Pin OVS_BRANCH in ipv6 ovn job

    Was missed with original patch to pin OVS_BRANCH[1].

    [1] https://review.opendev.org/c/openstack/neutron/+/867004

    Related-Bug: #1999154
    Change-Id: I6c74d90260c8caf80a9698373b45fdd27b6bd8e9

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

It seems that is broken again...

OVN octavia is using "a787fbbf9dd6a108a53053afb45fb59a0b58b514" [1].

[1]https://review.opendev.org/c/openstack/ovn-octavia-provider/+/867983/2/zuul.d/base.yaml

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/868201

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/868201
Committed: https://opendev.org/openstack/neutron/commit/1d46b199517ce93066dc9b989cb6e1e078f701b8
Submitter: "Zuul (22348)"
Branch: master

commit 1d46b199517ce93066dc9b989cb6e1e078f701b8
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sun Dec 11 21:45:21 2022 +0100

    Pin OVS_BRANCH to master again

    This patch reverts [1] and [2] now [3] has been merged in the
    OVN repository.

    [1]https://review.opendev.org/c/openstack/neutron/+/867004
    [2]https://review.opendev.org/c/openstack/neutron/+/867522
    [3]https://github.com/ovn-org/ovn/commit/1b0dbde940706e5de6e60221be78a278361fa76d

    Related-Bug: #1999154

    Change-Id: I31cc4ef324aa9112b4ba9409025495af6813a80b

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 22.0.0.0rc1 release candidate.

[Brian Haley (brian-haley)]

Seems fixed, closing.