[fullstack] Error in "test_concurrent_router_subnet_attachment_overlapping_cidr_"

Bug #1998226 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Fernando Royo
tags: added: fullstack gate-failure
tags: added: l3-dvr-backlog
tags: removed: l3-dvr-backlog
Changed in neutron:
status: New → Confirmed
importance: Undecided → High
Changed in neutron:
assignee: nobody → Fernando Royo (froyoredhat)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/866328

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/866328
Committed: https://opendev.org/openstack/neutron/commit/92efd8e45bef761fc464c932f1fd60d1c4d7e828
Submitter: "Zuul (22348)"
Branch: master

commit 92efd8e45bef761fc464c932f1fd60d1c4d7e828
Author: Fernando Royo <email address hidden>
Date: Thu Dec 1 11:47:58 2022 +0100

    Dont raise RouterInterfaceNotFound on overlap check router ports

    A corner case of the fix done in [1] could happend if, as a race
    scenario, parallel requests evaluate other ports that could be deleted
    during the process if they had already determined a overlapping, in that
    case a RouterInterfaceNotFound exception was raised and the request
    finished with that exception and a 404 status code.

    This patch removes the exception due to a port not found, because if the
    port is not found, the related subnet should not participate in the
    overlap evaluation, so it makes no sense to break the process for a port
    that no longer exists. It also improves the previous validation to
    perform the overlapping check, being performed only when we have
    at least more than one subnet, as the overlapping check with only one
    subnet did not make sense.

    Closes-Bug: #1998226

    [1] https://review.opendev.org/c/openstack/neutron/+/859143

    Change-Id: If4afe6f525c46f9cf7f02d8aae27dfc56144fd62

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/866835

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/866836

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/866837

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/866838

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/866835
Committed: https://opendev.org/openstack/neutron/commit/6927dfbb3e52ba298928362da5cce32d49b1e1f8
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 6927dfbb3e52ba298928362da5cce32d49b1e1f8
Author: Fernando Royo <email address hidden>
Date: Thu Dec 1 11:47:58 2022 +0100

    Dont raise RouterInterfaceNotFound on overlap check router ports

    A corner case of the fix done in [1] could happend if, as a race
    scenario, parallel requests evaluate other ports that could be deleted
    during the process if they had already determined a overlapping, in that
    case a RouterInterfaceNotFound exception was raised and the request
    finished with that exception and a 404 status code.

    This patch removes the exception due to a port not found, because if the
    port is not found, the related subnet should not participate in the
    overlap evaluation, so it makes no sense to break the process for a port
    that no longer exists. It also improves the previous validation to
    perform the overlapping check, being performed only when we have
    at least more than one subnet, as the overlapping check with only one
    subnet did not make sense.

    Closes-Bug: #1998226

    [1] https://review.opendev.org/c/openstack/neutron/+/859143

    Change-Id: If4afe6f525c46f9cf7f02d8aae27dfc56144fd62
    (cherry picked from commit 92efd8e45bef761fc464c932f1fd60d1c4d7e828)

tags: added: in-stable-zed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/866836
Committed: https://opendev.org/openstack/neutron/commit/7672b0e76a32a9e6ceaa92b1bbddcc150030b5d5
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 7672b0e76a32a9e6ceaa92b1bbddcc150030b5d5
Author: Fernando Royo <email address hidden>
Date: Thu Dec 1 11:47:58 2022 +0100

    Dont raise RouterInterfaceNotFound on overlap check router ports

    A corner case of the fix done in [1] could happend if, as a race
    scenario, parallel requests evaluate other ports that could be deleted
    during the process if they had already determined a overlapping, in that
    case a RouterInterfaceNotFound exception was raised and the request
    finished with that exception and a 404 status code.

    This patch removes the exception due to a port not found, because if the
    port is not found, the related subnet should not participate in the
    overlap evaluation, so it makes no sense to break the process for a port
    that no longer exists. It also improves the previous validation to
    perform the overlapping check, being performed only when we have
    at least more than one subnet, as the overlapping check with only one
    subnet did not make sense.

    Closes-Bug: #1998226

    [1] https://review.opendev.org/c/openstack/neutron/+/859143

    Change-Id: If4afe6f525c46f9cf7f02d8aae27dfc56144fd62
    (cherry picked from commit 92efd8e45bef761fc464c932f1fd60d1c4d7e828)

tags: added: in-stable-yoga
tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/866837
Committed: https://opendev.org/openstack/neutron/commit/74618128bc37b8277505d44b1cdea69191930258
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 74618128bc37b8277505d44b1cdea69191930258
Author: Fernando Royo <email address hidden>
Date: Thu Dec 1 11:47:58 2022 +0100

    Dont raise RouterInterfaceNotFound on overlap check router ports

    A corner case of the fix done in [1] could happend if, as a race
    scenario, parallel requests evaluate other ports that could be deleted
    during the process if they had already determined a overlapping, in that
    case a RouterInterfaceNotFound exception was raised and the request
    finished with that exception and a 404 status code.

    This patch removes the exception due to a port not found, because if the
    port is not found, the related subnet should not participate in the
    overlap evaluation, so it makes no sense to break the process for a port
    that no longer exists. It also improves the previous validation to
    perform the overlapping check, being performed only when we have
    at least more than one subnet, as the overlapping check with only one
    subnet did not make sense.

    Closes-Bug: #1998226

    [1] https://review.opendev.org/c/openstack/neutron/+/859143

    Change-Id: If4afe6f525c46f9cf7f02d8aae27dfc56144fd62
    (cherry picked from commit 92efd8e45bef761fc464c932f1fd60d1c4d7e828)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/866838
Committed: https://opendev.org/openstack/neutron/commit/579af629a55afffbde5964d595d9880019d2700b
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 579af629a55afffbde5964d595d9880019d2700b
Author: Fernando Royo <email address hidden>
Date: Thu Dec 1 11:47:58 2022 +0100

    Dont raise RouterInterfaceNotFound on overlap check router ports

    A corner case of the fix done in [1] could happend if, as a race
    scenario, parallel requests evaluate other ports that could be deleted
    during the process if they had already determined a overlapping, in that
    case a RouterInterfaceNotFound exception was raised and the request
    finished with that exception and a 404 status code.

    This patch removes the exception due to a port not found, because if the
    port is not found, the related subnet should not participate in the
    overlap evaluation, so it makes no sense to break the process for a port
    that no longer exists. It also improves the previous validation to
    perform the overlapping check, being performed only when we have
    at least more than one subnet, as the overlapping check with only one
    subnet did not make sense.

    Closes-Bug: #1998226

    [1] https://review.opendev.org/c/openstack/neutron/+/859143

    Change-Id: If4afe6f525c46f9cf7f02d8aae27dfc56144fd62
    (cherry picked from commit 92efd8e45bef761fc464c932f1fd60d1c4d7e828)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 19.5.0

This issue was fixed in the openstack/neutron 19.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 22.0.0.0rc1

This issue was fixed in the openstack/neutron 22.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 20.3.0

This issue was fixed in the openstack/neutron 20.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 21.1.0

This issue was fixed in the openstack/neutron 21.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron wallaby-eom

This issue was fixed in the openstack/neutron wallaby-eom release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.