Move "ChassisBandwidthConfigEvent" registration to "OvnSbIdl" class initialization

Bug #1998108 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Rodolfo Alonso

Bug Description

The event "ChassisBandwidthConfigEvent", that is an OVN SB DB event, should be registered in the "OvnSbIdl" class initialization. This class is instantiated for the worker threads. Because we use the "OvnDbNotifyHandler", the event will be treated by just one single OVN Client at a time.

If the placement extension is not loaded yet, the class will skip any event.

Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/865857

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/865857
Committed: https://opendev.org/openstack/neutron/commit/49eab7d308b598e4c4966110d6aa61cd091cc3f6
Submitter: "Zuul (22348)"
Branch: master

commit 49eab7d308b598e4c4966110d6aa61cd091cc3f6
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Nov 17 21:14:40 2022 +0100

    Move registration "ChassisBandwidthConfigEvent" to OvnSbIdl init

    The "ChassisBandwidthConfigEvent" event registration is now done in the
    "OvnSbIdl" class initialization. That ensures this event is registered
    in a worker thread.

    If the event is called before the "OVNMechanismDriver"'s "OVNClient"
    has been instantiated, the event is skipped. When the OVN placement
    extension is loaded, all chassis configurations are read and loaded,
    thus any previous event is not relevant.

    This patch also adds a "match_fn" check to
    "ChassisBandwidthConfigEvent". If during an update event, the bandwidth
    options are not modified, this class does not update the resource
    provider inventories.

    Closes-Bug: #1998108
    Related-Bug: #1578989
    Change-Id: I74883041c642b9498299ebf2b5bf885776e241e0

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/868784

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/868784
Committed: https://opendev.org/openstack/neutron/commit/74b6c1dd0bd9034578d7be81940b36b553ffe627
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 74b6c1dd0bd9034578d7be81940b36b553ffe627
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Nov 17 21:14:40 2022 +0100

    Move registration "ChassisBandwidthConfigEvent" to OvnSbIdl init

    The "ChassisBandwidthConfigEvent" event registration is now done in the
    "OvnSbIdl" class initialization. That ensures this event is registered
    in a worker thread.

    If the event is called before the "OVNMechanismDriver"'s "OVNClient"
    has been instantiated, the event is skipped. When the OVN placement
    extension is loaded, all chassis configurations are read and loaded,
    thus any previous event is not relevant.

    This patch also adds a "match_fn" check to
    "ChassisBandwidthConfigEvent". If during an update event, the bandwidth
    options are not modified, this class does not update the resource
    provider inventories.

    Closes-Bug: #1998108
    Related-Bug: #1578989
    Change-Id: I74883041c642b9498299ebf2b5bf885776e241e0
    (cherry picked from commit 49eab7d308b598e4c4966110d6aa61cd091cc3f6)

tags: added: in-stable-zed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 22.0.0.0rc1

This issue was fixed in the openstack/neutron 22.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 21.1.0

This issue was fixed in the openstack/neutron 21.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.