neutron revision_number does not bump on network update

[Andreas Karis]

neutron revision_number does not bump on network update

I tested the exact same mechanism with the subnet resource and an update to the same field (description) and it works like a charm. For the network resource, the revision number is not updated when updating the field, instead there's an inconsitency checker which fixesthe inconsistency from time to time

Here's the output of my go application calling into the API and updating resources (with a slightly modified version of gophercloud):
~~~
[stack@standalone gophercloud-test]$ go run main.go -network-id 674bf675-0382-4524-86f6-be1b677e1c12 -subnet-id 10ee214c-e8df-4f1a-af0b-4c9b64db64e3 -port-id c808500a-70b8-45e8-b0df-cbf0336d3139
I0715 13:06:18.881525 561527 main.go:101] Getting network
================> akaris GET map[network:map[admin_state_up:true availability_zone_hints:[] availability_zones:[] created_at:2022-07-15T11:15:29Z description: dns_domain: id:674bf675-0382-4524-86f6-be1b677e1c12 ipv4_address_scope:<nil> ipv6_address_scope:<nil> l2_adjacency:true mtu:1442 name:akaris-test port_security_enabled:true project_id:6f69c87fe95b469c8c7709382818acf6 qos_policy_id:<nil> revision_number:40 router:external:false shared:false status:ACTIVE subnets:[10ee214c-e8df-4f1a-af0b-4c9b64db64e3] tags:[] tenant_id:6f69c87fe95b469c8c7709382818acf6 updated_at:2022-07-15T13:04:20Z]]
I0715 13:06:19.063586 561527 main.go:103] Revision number is: 40
I0715 13:06:21.063986 561527 main.go:107] Updating network
-----> akaris PUT https://10.1.8.109:13696/v2.0/networks/674bf675-0382-4524-86f6-be1b677e1c12 &{map[network:map[description:test]] <nil> 0xc0005f6b10 [200 201] map[If-Match:revision_number=40] [] <nil> false}
I0715 13:06:25.666203 561527 main.go:124] Updating network again
I0715 13:06:25.666231 561527 main.go:130] Revision number is: 40
-----> akaris PUT https://10.1.8.109:13696/v2.0/networks/674bf675-0382-4524-86f6-be1b677e1c12 &{map[network:map[description:test2]] <nil> 0xc000615a70 [200 201] map[If-Match:revision_number=40] [] <nil> false}
================> akaris GET map[network:map[admin_state_up:true availability_zone_hints:[] availability_zones:[] created_at:2022-07-15T11:15:29Z description:test2 dns_domain: id:674bf675-0382-4524-86f6-be1b677e1c12 ipv4_address_scope:<nil> ipv6_address_scope:<nil> l2_adjacency:true mtu:1442 name:akaris-test port_security_enabled:true project_id:6f69c87fe95b469c8c7709382818acf6 qos_policy_id:<nil> revision_number:40 router:external:false shared:false status:ACTIVE subnets:[10ee214c-e8df-4f1a-af0b-4c9b64db64e3] tags:[] tenant_id:6f69c87fe95b469c8c7709382818acf6 updated_at:2022-07-15T13:06:25Z]]
I0715 13:06:28.093811 561527 main.go:138] &{674bf675-0382-4524-86f6-be1b677e1c12 akaris-test test2 true ACTIVE [10ee214c-e8df-4f1a-af0b-4c9b64db64e3] 6f69c87fe95b469c8c7709382818acf6 2022-07-15 13:06:25 +0000 UTC 2022-07-15 11:15:29 +0000 UTC 6f69c87fe95b469c8c7709382818acf6 false [] [] 40}
I0715 13:06:30.094846 561527 main.go:142] Getting network
================> akaris GET map[network:map[admin_state_up:true availability_zone_hints:[] availability_zones:[] created_at:2022-07-15T11:15:29Z description:test2 dns_domain: id:674bf675-0382-4524-86f6-be1b677e1c12 ipv4_address_scope:<nil> ipv6_address_scope:<nil> l2_adjacency:true mtu:1442 name:akaris-test port_security_enabled:true project_id:6f69c87fe95b469c8c7709382818acf6 qos_policy_id:<nil> revision_number:40 router:external:false shared:false status:ACTIVE subnets:[10ee214c-e8df-4f1a-af0b-4c9b64db64e3] tags:[] tenant_id:6f69c87fe95b469c8c7709382818acf6 updated_at:2022-07-15T13:06:25Z]]
I0715 13:06:30.210418 561527 main.go:144] Revision number is: 40
I0715 13:06:32.211495 561527 main.go:148] Resetting network
-----> akaris PUT https://10.1.8.109:13696/v2.0/networks/674bf675-0382-4524-86f6-be1b677e1c12 &{map[network:map[description:]] <nil> 0xc0005f62a0 [200 201] map[If-Match:revision_number=40] [] <nil> false}
~~~

Here's the neutron output for that same test:
~~~
  stack@standalone gophercloud]$ while true; do date ; openstack network show 674bf675-0382-4524-86f6-be1b677e1c12 ; sleep 1; done
  Fri Jul 15 13:06:15 UTC 2022
  +---------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
  | Field | Value |
  +---------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
  | description | |
  | revision_number | 40 |
  +---------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
  Fri Jul 15 13:06:18 UTC 2022
  +---------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
  | Field | Value |
  +---------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
  | description | |
  | revision_number | 40 |
  +---------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
  Fri Jul 15 13:06:22 UTC 2022
  +---------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
  | Field | Value |
  +---------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
  | description | test |
  | revision_number | 40 |
  +---------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
  Fri Jul 15 13:06:25 UTC 2022
  +---------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
  | Field | Value |
  +---------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
  | description | test2 |
  | revision_number | 40 |
  +---------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
  Fri Jul 15 13:06:29 UTC 2022
  +---------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
  | Field | Value |
  +---------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
  | description | test2 |
  | revision_number | 40 |
  +---------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
~~~

[Andreas Karis (akkaris)]

The last revision bump happened due to an inconsistency check, indicating that something on the updates is clearly not updating the revision number:
~~~
2022-07-15 12:59:34.481 40 DEBUG futurist.periodics [req-74ee1d8f-facb-46df-99b3-4bb32b3bd974 - - - - -] Submitting periodic callback 'networking_ovn.common.maintenance.DBInconsistenciesPeriodics.check_for_inconsistencies' _process_scheduled /usr/lib/python3.6/site-packages/futurist/periodics.py:639
2022-07-15 12:59:34.490 40 DEBUG networking_ovn.common.maintenance [req-74ee1d8f-facb-46df-99b3-4bb32b3bd974 - - - - -] Maintenance task: Synchronizing Neutron and OVN databases check_for_inconsistencies /usr/lib/python3.6/site-packages/networking_ovn/common/maintenance.py:342
2022-07-15 12:59:34.491 40 DEBUG networking_ovn.common.maintenance [req-74ee1d8f-facb-46df-99b3-4bb32b3bd974 - - - - -] Maintenance task: Number of inconsistencies found at create/update: networks=1 _log /usr/lib/python3.6/site-packages/networking_ovn/common/maintenance.py:323
2022-07-15 12:59:34.491 40 DEBUG networking_ovn.common.maintenance [req-74ee1d8f-facb-46df-99b3-4bb32b3bd974 - - - - -] Maintenance task: Fixing resource 674bf675-0382-4524-86f6-be1b677e1c12 (type: networks) at create/update check_for_inconsistencies /usr/lib/python3.6/site-packages/networking_ovn/common/maintenance.py:354
2022-07-15 12:59:34.579 40 DEBUG ovsdbapp.backend.ovs_idl.transaction [-] Running txn n=1 command(idx=0): CheckRevisionNumberCommand(name=neutron-674bf675-0382-4524-86f6-be1b677e1c12, resource={'id': '674bf675-0382-4524-86f6-be1b677e1c12', 'name': 'akaris-test', 'tenant_id': '6f69c87fe95b469c8c7709382818acf6', 'admin_state_up': True, 'mtu': 1442, 'status': 'ACTIVE', 'subnets': ['10ee214c-e8df-4f1a-af0b-4c9b64db64e3'], 'shared': False, 'availability_zone_hints': [], 'availability_zones': [], 'ipv4_address_scope': None, 'ipv6_address_scope': None, 'router:external': False, 'vlan_transparent': None, 'description': '', 'qos_policy_id': None, 'port_security_enabled': True, 'dns_domain': '', 'l2_adjacency': True, 'tags': [], 'created_at': '2022-07-15T11:15:29Z', 'updated_at': '2022-07-15T12:54:59Z', 'revision_number': 40, 'project_id': '6f69c87fe95b469c8c7709382818acf6', 'provider:network_type': 'geneve', 'provider:physical_network': None, 'provider:segmentation_id': 30264}, resource_type=networks, if_exists=True) do_commit /usr/lib/python3.6/site-packages/ovsdbapp/backend/ovs_idl/transaction.py:89
2022-07-15 12:59:34.579 40 DEBUG ovsdbapp.backend.ovs_idl.transaction [-] Running txn n=1 command(idx=1): DbSetCommand(table=Logical_Switch, record=neutron-674bf675-0382-4524-86f6-be1b677e1c12, col_values=(('external_ids', {'neutron:network_name': 'akaris-test', 'neutron:mtu': '1442', 'neutron:revision_number': '40'}), ('other_config', {'mcast_snoop': 'false', 'mcast_flood_unregistered': 'false', 'vlan-passthru': 'false'}))) do_commit /usr/lib/python3.6/site-packages/ovsdbapp/backend/ovs_idl/transaction.py:89
2022-07-15 12:59:34.596 25 DEBUG networking_ovn.ovsdb.ovsdb_monitor [-] Hash Ring: Node 92c9941f-1c88-443d-956a-f3a17ceb9436 (host: standalone.shiftstack) handling event "update" for row 888507e7-8932-456c-b2ba-4410e8a7630f (table: Logical_...

[Andreas Karis (akkaris)]

Here's the neutron log in question:
~~~
2022-07-15 13:06:17.606 19 DEBUG neutron.pecan_wsgi.hooks.policy_enforcement [req-aecb1776-8d38-4ab6-bbb9-cfa17ee4c245 3c88c234ba004865bbae69a2a28f0dfe 6f69c87fe95b469c8c7709382818acf6 - default default] Attributes excluded by policy engine: ['vlan_transparent', 'provider:network_type', 'provider:physical_network', 'provider:segmentation_id'] _exclude_attributes_by_policy /usr/lib/python3.6/site-packages/neutron/pecan_wsgi/hooks/policy_enforcement.py:256
2022-07-15 13:06:17.607 19 INFO neutron.wsgi [req-aecb1776-8d38-4ab6-bbb9-cfa17ee4c245 3c88c234ba004865bbae69a2a28f0dfe 6f69c87fe95b469c8c7709382818acf6 - default default] 192.168.24.1 "GET /v2.0/networks/674bf675-0382-4524-86f6-be1b677e1c12 HTTP/1.1" status: 200 len: 800 time: 0.1828680
2022-07-15 13:06:18.019 19 DEBUG neutron.wsgi [-] (19) accepted ('192.168.24.1', 34476) server /usr/lib/python3.6/site-packages/eventlet/wsgi.py:985
2022-07-15 13:06:18.084 19 INFO neutron.wsgi [req-fd0f4d2d-3059-482f-9d73-271a80fb608c 2a48856776d2442092bdcc4899ae56ab 9271f2b667f444de93ee682198c394ac - default default] 192.168.24.1 "GET /v2.0/ports?device_id=382c107f-a082-4e9b-8adb-2ba45323c479 HTTP/1.1" status: 200 len: 1730 time: 0.0639110
2022-07-15 13:06:18.119 19 INFO neutron.wsgi [req-bad51a66-ea0d-4a6e-9cb4-d5c1b2335381 2a48856776d2442092bdcc4899ae56ab 9271f2b667f444de93ee682198c394ac - default default] 192.168.24.1 "GET /v2.0/security-groups?id=d426fa6b-74e1-4272-95c0-e7edd4978cef&fields=id&fields=name HTTP/1.1" status: 200 len: 275 time: 0.0302784
2022-07-15 13:06:18.889 18 DEBUG neutron.wsgi [-] (18) accepted ('192.168.24.1', 34508) server /usr/lib/python3.6/site-packages/eventlet/wsgi.py:985
2022-07-15 13:06:18.897 40 DEBUG futurist.periodics [req-74ee1d8f-facb-46df-99b3-4bb32b3bd974 - - - - -] Submitting periodic callback 'networking_ovn.common.maintenance.HashRingHealthCheckPeriodics.touch_hash_ring_nodes' _process_scheduled /usr/lib/python3.6/site-packages/futurist/periodics.py:639
2022-07-15 13:06:19.061 18 DEBUG neutron.pecan_wsgi.hooks.policy_enforcement [req-8e20bc1d-9e88-4e99-bc81-a352cfd990a0 3c88c234ba004865bbae69a2a28f0dfe 6f69c87fe95b469c8c7709382818acf6 - default default] Attributes excluded by policy engine: ['vlan_transparent', 'provider:network_type', 'provider:physical_network', 'provider:segmentation_id'] _exclude_attributes_by_policy /usr/lib/python3.6/site-packages/neutron/pecan_wsgi/hooks/policy_enforcement.py:256
2022-07-15 13:06:19.063 18 INFO neutron.wsgi [req-8e20bc1d-9e88-4e99-bc81-a352cfd990a0 3c88c234ba004865bbae69a2a28f0dfe 6f69c87fe95b469c8c7709382818acf6 - default default] 192.168.24.1 "GET /v2.0/networks/674bf675-0382-4524-86f6-be1b677e1c12 HTTP/1.1" status: 200 len: 800 time: 0.1722431
2022-07-15 13:06:19.196 19 DEBUG neutron.wsgi [-] (19) accepted ('192.168.24.1', 34518) server /usr/lib/python3.6/site-packages/eventlet/wsgi.py:985
2022-07-15 13:06:19.202 19 INFO neutron.wsgi [-] 192.168.24.1 "OPTIONS / HTTP/1.0" status: 200 len: 249 time: 0.0046527
2022-07-15 13:06:19.243 19 DEBUG neutron.wsgi [-] (19) accepted ('192.168.24.1', 34528) server /usr/lib/python3.6/site-packages/eventlet/wsgi.py:985
2022-07-15 13:06:19.366 19...

[Bence Romsics (bence-romsics)]

I guess this is a simpler reproduction for the same problem:

$ openstack net create net0 -f value -c revision_number
1
$ openstack net set net0 --description foo
$ openstack net show net0 -f value -c revision_number
1

[Slawek Kaplonski (slaweq)]

Ok, this seems to be the same problem like for routers https://bugs.launchpad.net/neutron/+bug/1865173
I will investigate both of them together.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/851733

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/851733
Committed: https://opendev.org/openstack/neutron/commit/4c9cb83d6b46a6425e603194649a61f51a07a307
Submitter: "Zuul (22348)"
Branch: master

commit 4c9cb83d6b46a6425e603194649a61f51a07a307
Author: Slawek Kaplonski <email address hidden>
Date: Mon Aug 1 13:00:28 2022 +0200

    Bump revision number of objects when description is changed

    "Description" attribute belongs to the StandardAttribute class from
    which many other classes inherits (like e.g. Network, Port or Subnet).
    In case when only description of object is updated, revision number of
    the object should be bumped but it wasn't the case for all of the
    objects. For example updated description of the Network or Router didn't
    bumped its revision_number. It was like that because StandardAttribute
    object was the only one which was dirty in the session, and as it is not
    member of the HasStandardAttibutes class, it was filtered out.

    Now, to fix that problem revision_plugin looks in the session.dirty list
    for objects which inherits from HasStandardAttibutes class (as it was
    before) but also for StandardAttribute objects to bump revision numbers.

    Closes-Bug: #1981817
    Closes-Bug: #1865173
    Change-Id: I79b40a8ae5d594ed6fc875572663469c8b701202

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/854905

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/854906

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/854907

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/854908

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/854909

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/neutron/+/854990

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/854907
Committed: https://opendev.org/openstack/neutron/commit/d0592d06e8835d529a5f6e25bba063743cd7bc73
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit d0592d06e8835d529a5f6e25bba063743cd7bc73
Author: Slawek Kaplonski <email address hidden>
Date: Mon Aug 1 13:00:28 2022 +0200

    Bump revision number of objects when description is changed

    "Description" attribute belongs to the StandardAttribute class from
    which many other classes inherits (like e.g. Network, Port or Subnet).
    In case when only description of object is updated, revision number of
    the object should be bumped but it wasn't the case for all of the
    objects. For example updated description of the Network or Router didn't
    bumped its revision_number. It was like that because StandardAttribute
    object was the only one which was dirty in the session, and as it is not
    member of the HasStandardAttibutes class, it was filtered out.

    Now, to fix that problem revision_plugin looks in the session.dirty list
    for objects which inherits from HasStandardAttibutes class (as it was
    before) but also for StandardAttribute objects to bump revision numbers.

    Closes-Bug: #1981817
    Closes-Bug: #1865173
    Change-Id: I79b40a8ae5d594ed6fc875572663469c8b701202
    (cherry picked from commit 4c9cb83d6b46a6425e603194649a61f51a07a307)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/854909
Committed: https://opendev.org/openstack/neutron/commit/39f7e1299364f3eca6375c178b604f70a05c0d81
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 39f7e1299364f3eca6375c178b604f70a05c0d81
Author: Slawek Kaplonski <email address hidden>
Date: Mon Aug 1 13:00:28 2022 +0200

    Bump revision number of objects when description is changed

    "Description" attribute belongs to the StandardAttribute class from
    which many other classes inherits (like e.g. Network, Port or Subnet).
    In case when only description of object is updated, revision number of
    the object should be bumped but it wasn't the case for all of the
    objects. For example updated description of the Network or Router didn't
    bumped its revision_number. It was like that because StandardAttribute
    object was the only one which was dirty in the session, and as it is not
    member of the HasStandardAttibutes class, it was filtered out.

    Now, to fix that problem revision_plugin looks in the session.dirty list
    for objects which inherits from HasStandardAttibutes class (as it was
    before) but also for StandardAttribute objects to bump revision numbers.

    Closes-Bug: #1981817
    Closes-Bug: #1865173
    Change-Id: I79b40a8ae5d594ed6fc875572663469c8b701202
    (cherry picked from commit 4c9cb83d6b46a6425e603194649a61f51a07a307)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/854908
Committed: https://opendev.org/openstack/neutron/commit/05e37d891cefd2268a4a72bdf752d12b5b2f2f24
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 05e37d891cefd2268a4a72bdf752d12b5b2f2f24
Author: Slawek Kaplonski <email address hidden>
Date: Mon Aug 1 13:00:28 2022 +0200

    Bump revision number of objects when description is changed

    "Description" attribute belongs to the StandardAttribute class from
    which many other classes inherits (like e.g. Network, Port or Subnet).
    In case when only description of object is updated, revision number of
    the object should be bumped but it wasn't the case for all of the
    objects. For example updated description of the Network or Router didn't
    bumped its revision_number. It was like that because StandardAttribute
    object was the only one which was dirty in the session, and as it is not
    member of the HasStandardAttibutes class, it was filtered out.

    Now, to fix that problem revision_plugin looks in the session.dirty list
    for objects which inherits from HasStandardAttibutes class (as it was
    before) but also for StandardAttribute objects to bump revision numbers.

    Closes-Bug: #1981817
    Closes-Bug: #1865173
    Change-Id: I79b40a8ae5d594ed6fc875572663469c8b701202
    (cherry picked from commit 4c9cb83d6b46a6425e603194649a61f51a07a307)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/854906
Committed: https://opendev.org/openstack/neutron/commit/0fe77594c5a55f909733761c64ee03271a8d4ecd
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 0fe77594c5a55f909733761c64ee03271a8d4ecd
Author: Slawek Kaplonski <email address hidden>
Date: Mon Aug 1 13:00:28 2022 +0200

    Bump revision number of objects when description is changed

    "Description" attribute belongs to the StandardAttribute class from
    which many other classes inherits (like e.g. Network, Port or Subnet).
    In case when only description of object is updated, revision number of
    the object should be bumped but it wasn't the case for all of the
    objects. For example updated description of the Network or Router didn't
    bumped its revision_number. It was like that because StandardAttribute
    object was the only one which was dirty in the session, and as it is not
    member of the HasStandardAttibutes class, it was filtered out.

    Now, to fix that problem revision_plugin looks in the session.dirty list
    for objects which inherits from HasStandardAttibutes class (as it was
    before) but also for StandardAttribute objects to bump revision numbers.

    Closes-Bug: #1981817
    Closes-Bug: #1865173
    Change-Id: I79b40a8ae5d594ed6fc875572663469c8b701202
    (cherry picked from commit 4c9cb83d6b46a6425e603194649a61f51a07a307)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/854905
Committed: https://opendev.org/openstack/neutron/commit/edc26807dd8d4a39b1638a74895f6d9876101721
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit edc26807dd8d4a39b1638a74895f6d9876101721
Author: Slawek Kaplonski <email address hidden>
Date: Mon Aug 1 13:00:28 2022 +0200

    Bump revision number of objects when description is changed

    "Description" attribute belongs to the StandardAttribute class from
    which many other classes inherits (like e.g. Network, Port or Subnet).
    In case when only description of object is updated, revision number of
    the object should be bumped but it wasn't the case for all of the
    objects. For example updated description of the Network or Router didn't
    bumped its revision_number. It was like that because StandardAttribute
    object was the only one which was dirty in the session, and as it is not
    member of the HasStandardAttibutes class, it was filtered out.

    Now, to fix that problem revision_plugin looks in the session.dirty list
    for objects which inherits from HasStandardAttibutes class (as it was
    before) but also for StandardAttribute objects to bump revision numbers.

    Closes-Bug: #1981817
    Closes-Bug: #1865173
    Change-Id: I79b40a8ae5d594ed6fc875572663469c8b701202
    (cherry picked from commit 4c9cb83d6b46a6425e603194649a61f51a07a307)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/854990
Committed: https://opendev.org/openstack/neutron/commit/bbaf496bd6d5af34d71df794368b902fbd4d8452
Submitter: "Zuul (22348)"
Branch: stable/train

commit bbaf496bd6d5af34d71df794368b902fbd4d8452
Author: Slawek Kaplonski <email address hidden>
Date: Mon Aug 1 13:00:28 2022 +0200

    Bump revision number of objects when description is changed

    "Description" attribute belongs to the StandardAttribute class from
    which many other classes inherits (like e.g. Network, Port or Subnet).
    In case when only description of object is updated, revision number of
    the object should be bumped but it wasn't the case for all of the
    objects. For example updated description of the Network or Router didn't
    bumped its revision_number. It was like that because StandardAttribute
    object was the only one which was dirty in the session, and as it is not
    member of the HasStandardAttibutes class, it was filtered out.

    Now, to fix that problem revision_plugin looks in the session.dirty list
    for objects which inherits from HasStandardAttibutes class (as it was
    before) but also for StandardAttribute objects to bump revision numbers.

    Closes-Bug: #1981817
    Closes-Bug: #1865173
    Change-Id: I79b40a8ae5d594ed6fc875572663469c8b701202
    (cherry picked from commit 4c9cb83d6b46a6425e603194649a61f51a07a307)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 21.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 18.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 19.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 20.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron train-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron ussuri-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron victoria-eom release.