[OVS][QoS] "delete_minimum_bandwidth_queue" uses the incorrect Port UUID

Bug #1977819 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Rodolfo Alonso

Bug Description

The method "delete_minimum_bandwidth_queue" uses the incorrect Port UUID (or name) to unset the QoS value. The minimum BW QoS register is set in the physical bridge interface, not the port with the Neutron QoS policy attached.

Error: https://paste.opendev.org/show/bRQRp5Dq4tgWgLzrZpCO/

Bugzilla reference: https://bugzilla.redhat.com/show_bug.cgi?id=2097444

Changed in neutron:
importance: Undecided → High
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/844927

Changed in neutron:
status: Confirmed → In Progress
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/846958

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/846959

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/846960

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/846961

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/846962

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/neutron/+/846963

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/844927
Committed: https://opendev.org/openstack/neutron/commit/9f5e211796dbc0df0bad1ae29fbb82eb7317fb82
Submitter: "Zuul (22348)"
Branch: master

commit 9f5e211796dbc0df0bad1ae29fbb82eb7317fb82
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Jun 7 09:26:04 2022 +0000

    [OVS][QoS] Unset the min-bw QoS from the phys bridge interface

    The minimum bandwidth OVS QoS policy is set in the physical bridge
    interface, not the port that receives the Neutron QoS policy.
    If no other port has a minimum bandwidth rule, the OVS QoS policy
    can be unset from this port and deleted. This patch fixes the
    port that must be updated.

    Closes-Bug: #1977819
    Change-Id: I0ebcc85f5ffa9dc29ffedee0c7df1828c85e1576

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/train)

Change abandoned by "Rodolfo Alonso <email address hidden>" on branch: stable/train
Review: https://review.opendev.org/c/openstack/neutron/+/846963

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/846958
Committed: https://opendev.org/openstack/neutron/commit/c41bd56033108a185f55705a1e8d4ef317b529e4
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit c41bd56033108a185f55705a1e8d4ef317b529e4
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Jun 7 09:26:04 2022 +0000

    [OVS][QoS] Unset the min-bw QoS from the phys bridge interface

    The minimum bandwidth OVS QoS policy is set in the physical bridge
    interface, not the port that receives the Neutron QoS policy.
    If no other port has a minimum bandwidth rule, the OVS QoS policy
    can be unset from this port and deleted. This patch fixes the
    port that must be updated.

    Closes-Bug: #1977819
    Change-Id: I0ebcc85f5ffa9dc29ffedee0c7df1828c85e1576
    (cherry picked from commit 9f5e211796dbc0df0bad1ae29fbb82eb7317fb82)

tags: added: in-stable-yoga
tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/846959
Committed: https://opendev.org/openstack/neutron/commit/6040b88078cb7acb5844594e09ca8d730741c239
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 6040b88078cb7acb5844594e09ca8d730741c239
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Jun 7 09:26:04 2022 +0000

    [OVS][QoS] Unset the min-bw QoS from the phys bridge interface

    The minimum bandwidth OVS QoS policy is set in the physical bridge
    interface, not the port that receives the Neutron QoS policy.
    If no other port has a minimum bandwidth rule, the OVS QoS policy
    can be unset from this port and deleted. This patch fixes the
    port that must be updated.

    Closes-Bug: #1977819
    Change-Id: I0ebcc85f5ffa9dc29ffedee0c7df1828c85e1576
    (cherry picked from commit 9f5e211796dbc0df0bad1ae29fbb82eb7317fb82)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/846961
Committed: https://opendev.org/openstack/neutron/commit/9a29649965a823cf7f7db7a4b1ddf8097928cc7b
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 9a29649965a823cf7f7db7a4b1ddf8097928cc7b
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Jun 7 09:26:04 2022 +0000

    [OVS][QoS] Unset the min-bw QoS from the phys bridge interface

    The minimum bandwidth OVS QoS policy is set in the physical bridge
    interface, not the port that receives the Neutron QoS policy.
    If no other port has a minimum bandwidth rule, the OVS QoS policy
    can be unset from this port and deleted. This patch fixes the
    port that must be updated.

    Closes-Bug: #1977819
    Change-Id: I0ebcc85f5ffa9dc29ffedee0c7df1828c85e1576
    (cherry picked from commit 9f5e211796dbc0df0bad1ae29fbb82eb7317fb82)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/846962
Committed: https://opendev.org/openstack/neutron/commit/86e2ba00c4af01db5ff97cd20b7484c2555de3ad
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 86e2ba00c4af01db5ff97cd20b7484c2555de3ad
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Jun 7 09:26:04 2022 +0000

    [OVS][QoS] Unset the min-bw QoS from the phys bridge interface

    The minimum bandwidth OVS QoS policy is set in the physical bridge
    interface, not the port that receives the Neutron QoS policy.
    If no other port has a minimum bandwidth rule, the OVS QoS policy
    can be unset from this port and deleted. This patch fixes the
    port that must be updated.

    Closes-Bug: #1977819
    Change-Id: I0ebcc85f5ffa9dc29ffedee0c7df1828c85e1576
    (cherry picked from commit 9f5e211796dbc0df0bad1ae29fbb82eb7317fb82)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/train)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/846963
Committed: https://opendev.org/openstack/neutron/commit/7740ed078431d2df8160abb207f5c64fb64cea14
Submitter: "Zuul (22348)"
Branch: stable/train

commit 7740ed078431d2df8160abb207f5c64fb64cea14
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Jun 7 09:26:04 2022 +0000

    [OVS][QoS] Unset the min-bw QoS from the phys bridge interface

    The minimum bandwidth OVS QoS policy is set in the physical bridge
    interface, not the port that receives the Neutron QoS policy.
    If no other port has a minimum bandwidth rule, the OVS QoS policy
    can be unset from this port and deleted. This patch fixes the
    port that must be updated.

    Closes-Bug: #1977819
    Change-Id: I0ebcc85f5ffa9dc29ffedee0c7df1828c85e1576
    (cherry picked from commit 9f5e211796dbc0df0bad1ae29fbb82eb7317fb82)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/846960
Committed: https://opendev.org/openstack/neutron/commit/2c8208138a7e881268de62b0b3d80b63b1f3c969
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 2c8208138a7e881268de62b0b3d80b63b1f3c969
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Jun 7 09:26:04 2022 +0000

    [OVS][QoS] Unset the min-bw QoS from the phys bridge interface

    The minimum bandwidth OVS QoS policy is set in the physical bridge
    interface, not the port that receives the Neutron QoS policy.
    If no other port has a minimum bandwidth rule, the OVS QoS policy
    can be unset from this port and deleted. This patch fixes the
    port that must be updated.

    Closes-Bug: #1977819
    Change-Id: I0ebcc85f5ffa9dc29ffedee0c7df1828c85e1576
    (cherry picked from commit 9f5e211796dbc0df0bad1ae29fbb82eb7317fb82)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 18.5.0

This issue was fixed in the openstack/neutron 18.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 19.4.0

This issue was fixed in the openstack/neutron 19.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 20.2.0

This issue was fixed in the openstack/neutron 20.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 21.0.0.0rc1

This issue was fixed in the openstack/neutron 21.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron train-eol

This issue was fixed in the openstack/neutron train-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron ussuri-eol

This issue was fixed in the openstack/neutron ussuri-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron victoria-eom

This issue was fixed in the openstack/neutron victoria-eom release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.