Neutron allows creation of trunks for VIF_TYPE_HW_VEB ports

[Michal Dulko]

There's no trunk driver supporting VIF_TYPE_HW_VEB ports [1,2,3], yet Neutron allows trunks to be created for them. I think it should rejected on validation.

[1] https://github.com/openstack/neutron/blob/b1f48d8da3a6017a49f2a9ece89b9dc01ba8a810/neutron/services/trunk/drivers/openvswitch/driver.py#L31-L34
[2] https://github.com/openstack/neutron/blob/b1f48d8da3a6017a49f2a9ece89b9dc01ba8a810/neutron/services/trunk/drivers/ovn/trunk_driver.py#L29-L32
[3] https://github.com/openstack/neutron/blob/b1f48d8da3a6017a49f2a9ece89b9dc01ba8a810/neutron/services/trunk/drivers/linuxbridge/driver.py#L25-L27

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Hello:

This problem is happening in the OVN driver, in the Trunk service OVN driver (both networking-ovn [1] for Train deployments or Neutron [2] for newer).

When a trunk is created, regardless of the port binding (that means, even if the parent port is not bound to ML2/OVN), the Trunk OVS driver updates the status to ACTIVE. This is obviously something wrong that must be fixed but doesn't affect to any other service (**if** this service is not reading the trunk status).

Another topic, that is related to this bug is what is happening when a parent port is linked to a trunk and this parent port is then bound to a driver (SR-IOV in this specific case NOTE1) that doesn't have Trunk driver. In this case, the Trunk won't be created and the status of the Trunk must not be updated.

Regards.

NOTE1: the parent port is vnic-type direct and it is bound to a SR-IOV network. This is not defined in the bug description but I have access to the reporter environment.

[1]https://github.com/openstack/networking-ovn/blob/2704f99a2c97f008aedc9c3b8ed4ebc17c8245cc/networking_ovn/ml2/trunk_driver.py#L140
[2]https://github.com/openstack/neutron/blob/9ca5c1cc0426f629148e1e40657660671e948ce3/neutron/services/trunk/drivers/ovn/trunk_driver.py#L141

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/843247

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/844016

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/844017

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/844018

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/844019

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/844020

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/843247
Committed: https://opendev.org/openstack/neutron/commit/68bbd3586bdc313a6b67f2983ba2331a7956856c
Submitter: "Zuul (22348)"
Branch: master

commit 68bbd3586bdc313a6b67f2983ba2331a7956856c
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat May 14 09:41:25 2022 +0000

    [Trunk] Check if parent port belongs to OVN to activate

    In Trunk service, the OVN was setting always the trunk to "ACTIVE"
    anytime the trunk was created or updated. This patch changes this
    behaviour: only when the trunk parent port belongs to OVN (that
    means, there is a related logical switch port to this Neutron port),
    the methods will set the trunk to "ACTIVE".

    Closes-Bug: #1974183
    Change-Id: Ied5ef53882d4249e0ceaa731239befdc3ba67d03

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/844017
Committed: https://opendev.org/openstack/neutron/commit/cc7c9255ac0534fe0184f7ae64e09e29a57efefb
Submitter: "Zuul (22348)"
Branch: stable/xena

commit cc7c9255ac0534fe0184f7ae64e09e29a57efefb
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat May 14 09:41:25 2022 +0000

    [Trunk] Check if parent port belongs to OVN to activate

    In Trunk service, the OVN was setting always the trunk to "ACTIVE"
    anytime the trunk was created or updated. This patch changes this
    behaviour: only when the trunk parent port belongs to OVN (that
    means, there is a related logical switch port to this Neutron port),
    the methods will set the trunk to "ACTIVE".

    Closes-Bug: #1974183
    Change-Id: Ied5ef53882d4249e0ceaa731239befdc3ba67d03
    (cherry picked from commit 68bbd3586bdc313a6b67f2983ba2331a7956856c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/844020
Committed: https://opendev.org/openstack/neutron/commit/2f48872a31272c96d8695232e50a7c9718cfcc11
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 2f48872a31272c96d8695232e50a7c9718cfcc11
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat May 14 09:41:25 2022 +0000

    [Trunk] Check if parent port belongs to OVN to activate

    In Trunk service, the OVN was setting always the trunk to "ACTIVE"
    anytime the trunk was created or updated. This patch changes this
    behaviour: only when the trunk parent port belongs to OVN (that
    means, there is a related logical switch port to this Neutron port),
    the methods will set the trunk to "ACTIVE".

    Closes-Bug: #1974183
    Change-Id: Ied5ef53882d4249e0ceaa731239befdc3ba67d03
    (cherry picked from commit 68bbd3586bdc313a6b67f2983ba2331a7956856c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/844016
Committed: https://opendev.org/openstack/neutron/commit/d9326c7732592987299fb34f62f936d4326bb4a3
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit d9326c7732592987299fb34f62f936d4326bb4a3
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat May 14 09:41:25 2022 +0000

    [Trunk] Check if parent port belongs to OVN to activate

    In Trunk service, the OVN was setting always the trunk to "ACTIVE"
    anytime the trunk was created or updated. This patch changes this
    behaviour: only when the trunk parent port belongs to OVN (that
    means, there is a related logical switch port to this Neutron port),
    the methods will set the trunk to "ACTIVE".

    Closes-Bug: #1974183
    Change-Id: Ied5ef53882d4249e0ceaa731239befdc3ba67d03
    (cherry picked from commit 68bbd3586bdc313a6b67f2983ba2331a7956856c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/844018
Committed: https://opendev.org/openstack/neutron/commit/cc637d8d1026aa25925f63be573422f13db2052a
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit cc637d8d1026aa25925f63be573422f13db2052a
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat May 14 09:41:25 2022 +0000

    [Trunk] Check if parent port belongs to OVN to activate

    In Trunk service, the OVN was setting always the trunk to "ACTIVE"
    anytime the trunk was created or updated. This patch changes this
    behaviour: only when the trunk parent port belongs to OVN (that
    means, there is a related logical switch port to this Neutron port),
    the methods will set the trunk to "ACTIVE".

    Closes-Bug: #1974183
    Change-Id: Ied5ef53882d4249e0ceaa731239befdc3ba67d03
    (cherry picked from commit 68bbd3586bdc313a6b67f2983ba2331a7956856c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/844019
Committed: https://opendev.org/openstack/neutron/commit/69e101901a1b1a2764380300e8757ec75237e442
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 69e101901a1b1a2764380300e8757ec75237e442
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat May 14 09:41:25 2022 +0000

    [Trunk] Check if parent port belongs to OVN to activate

    In Trunk service, the OVN was setting always the trunk to "ACTIVE"
    anytime the trunk was created or updated. This patch changes this
    behaviour: only when the trunk parent port belongs to OVN (that
    means, there is a related logical switch port to this Neutron port),
    the methods will set the trunk to "ACTIVE".

    Closes-Bug: #1974183
    Change-Id: Ied5ef53882d4249e0ceaa731239befdc3ba67d03
    (cherry picked from commit 68bbd3586bdc313a6b67f2983ba2331a7956856c)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 18.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 19.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 20.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 21.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron ussuri-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron victoria-eom release.