[neutron-dynamic-routing] Plugin RPC queue should be consumed by RPC workers

[Renat Nurgaliyev]

Currently, the RPC queue of the BGP service plugin is consumed directdly in the plugin thread. This may lead to unprocessed data in TCP queues due to infrequent polling, AMQP connection drops due to missed heartbeats, and other unwanted behavior. Instead, the RPC queue should be consumed by RPC workers, the same way as it is already done in other service plugins, like L3 plugin, metering plugin, etc.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/842383

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/842383
Committed: https://opendev.org/openstack/neutron-dynamic-routing/commit/b9c085b85f3f2912d77050a33667f88b8edd6ca0
Submitter: "Zuul (22348)"
Branch: master

commit b9c085b85f3f2912d77050a33667f88b8edd6ca0
Author: Renat Nurgaliyev <email address hidden>
Date: Wed May 18 17:38:39 2022 +0200

    Consume BGP service plugin queue in RPC workers

    This patch adds BGP service plugin RPC queue to RPC workers, like it is
    done in other Neutron service plugins (l3-plugin, metering, etc.).
    Without it some RPC requests and AMQP heartbeats are not processed in
    time, causing AMQP connection dropping, and other unpredictable unwanted
    behavior.

    Closes-Bug: #1974057
    Change-Id: I1b13f01ca47c8390f1361e01d5eb313fe2fc417f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/849510

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/849511

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/849512

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/849510
Committed: https://opendev.org/openstack/neutron-dynamic-routing/commit/a019b78c98e1c618cc6227951ce63fe4fcd0c405
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit a019b78c98e1c618cc6227951ce63fe4fcd0c405
Author: Renat Nurgaliyev <email address hidden>
Date: Wed May 18 17:38:39 2022 +0200

    Consume BGP service plugin queue in RPC workers

    This patch adds BGP service plugin RPC queue to RPC workers, like it is
    done in other Neutron service plugins (l3-plugin, metering, etc.).
    Without it some RPC requests and AMQP heartbeats are not processed in
    time, causing AMQP connection dropping, and other unpredictable unwanted
    behavior.

    Closes-Bug: #1974057
    Change-Id: I1b13f01ca47c8390f1361e01d5eb313fe2fc417f
    (cherry picked from commit b9c085b85f3f2912d77050a33667f88b8edd6ca0)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/851729

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/849511
Committed: https://opendev.org/openstack/neutron-dynamic-routing/commit/b515ce43b8396cdcd68787e7a1ae4708dcd0da27
Submitter: "Zuul (22348)"
Branch: stable/xena

commit b515ce43b8396cdcd68787e7a1ae4708dcd0da27
Author: Renat Nurgaliyev <email address hidden>
Date: Wed May 18 17:38:39 2022 +0200

    Consume BGP service plugin queue in RPC workers

    This patch adds BGP service plugin RPC queue to RPC workers, like it is
    done in other Neutron service plugins (l3-plugin, metering, etc.).
    Without it some RPC requests and AMQP heartbeats are not processed in
    time, causing AMQP connection dropping, and other unpredictable unwanted
    behavior.

    Closes-Bug: #1974057
    Change-Id: I1b13f01ca47c8390f1361e01d5eb313fe2fc417f
    (cherry picked from commit b9c085b85f3f2912d77050a33667f88b8edd6ca0)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/849512
Committed: https://opendev.org/openstack/neutron-dynamic-routing/commit/ed1ffb194921285fb89d92a35ffbc04cc2610861
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit ed1ffb194921285fb89d92a35ffbc04cc2610861
Author: Renat Nurgaliyev <email address hidden>
Date: Wed May 18 17:38:39 2022 +0200

    Consume BGP service plugin queue in RPC workers

    This patch adds BGP service plugin RPC queue to RPC workers, like it is
    done in other Neutron service plugins (l3-plugin, metering, etc.).
    Without it some RPC requests and AMQP heartbeats are not processed in
    time, causing AMQP connection dropping, and other unpredictable unwanted
    behavior.

    Closes-Bug: #1974057
    Change-Id: I1b13f01ca47c8390f1361e01d5eb313fe2fc417f
    (cherry picked from commit b9c085b85f3f2912d77050a33667f88b8edd6ca0)

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Dr. Jens Harbott <email address hidden>" on branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/851729
Reason: CI would need fixing

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-dynamic-routing 21.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-dynamic-routing 18.1.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-dynamic-routing 19.1.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-dynamic-routing 20.0.1 release.