[UT] Error output in "test_metadata_port_on_network_delete"

[Rodolfo Alonso]

The unit test is not providing a return value to a mocked OVN DB method, "nb_idl.ls_get". This is the error output: https://paste.opendev.org/show/bs2WhKDEbdZQ6gid4s9E/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/866409

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/866409
Committed: https://opendev.org/openstack/neutron/commit/88b7db0e0c4d633748f454f4977c13c253012769
Submitter: "Zuul (22348)"
Branch: master

commit 88b7db0e0c4d633748f454f4977c13c253012769
Author: Brian Haley <email address hidden>
Date: Thu Dec 1 17:53:42 2022 -0500

    Mock ls_get in OVN metadata delete network unit test

    "TypeError: 'Mock' object is not iterable" could possibly
    be triggered by test_metadata_port_on_network_delete()
    since there is a missing mock of the return value for ls_get.

    Although I did not see the error described in the bug, I did
    verify ls_get was returning an incorrect value by printing
    it in the code, which after this patch was a fake row.

    Change-Id: Ib1f204c98eee96321c7befebf94012dc2c80b1e8
    Closes-bug: #1973731

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 22.0.0.0rc1 release candidate.