ovn-octavia-provider health monitoring fails because doesn't set the correct source IP address for OVN health check

[Gabriel Barazer]

Hello all,

IT seems the health checking feature of ovn octavia provider is broken and all service monitors show offline status because of a typo in https://opendev.org/openstack/ovn-octavia-provider/src/commit/1b212ec54fa336cc7a22a502ad3d0ce39658138e/ovn_octavia_provider/helper.py#L2171

Note the "i" prepended in the IP address in member_src += f'i{hm_source_ip}'

This causes the IP string to be casted including the "i" which give a random IP address for health check source, which in turn cause the response packet of the checked backend to be sent to the gateway MAC instead of the health check monitor source MAC defined in NB_Global options:svc_monitor_mac. The monitor does not get the check response and fails.

The very simple fix is to remove this "i" letter to set the correct source IP address for the monitor.

[Miguel Lavalle (minsel)]

Looking at the patch that introduced this line, it seems to be indeed a mistake: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/816829/4/ovn_octavia_provider/helper.py#2036

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/834345

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/834345
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/90bd5dc71ecd4891fcd9292d56726f034a59fbdf
Submitter: "Zuul (22348)"
Branch: master

commit 90bd5dc71ecd4891fcd9292d56726f034a59fbdf
Author: Miguel Lavalle <email address hidden>
Date: Fri Mar 18 13:03:22 2022 -0500

    Remove incorrect character in f-string

    Patch [1] switched to f-strings, unwillingly introducing a 'i' to an
    ip address. This change corrects that error

    [1] https://review.opendev.org/c/openstack/ovn-octavia-provider/+/816829

    Closes-Bug: #1965530
    Change-Id: I832780660a3658552dc8fb50c3e232306e1fa110

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/834471

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/834472

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/834471
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/b17e4769015a749e211b9b394437523f8f840563
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit b17e4769015a749e211b9b394437523f8f840563
Author: Miguel Lavalle <email address hidden>
Date: Fri Mar 18 13:03:22 2022 -0500

    Remove incorrect character in f-string

    Patch [1] switched to f-strings, unwillingly introducing a 'i' to an
    ip address. This change corrects that error

    [1] https://review.opendev.org/c/openstack/ovn-octavia-provider/+/816829

    Closes-Bug: #1965530
    Change-Id: I832780660a3658552dc8fb50c3e232306e1fa110
    (cherry picked from commit 90bd5dc71ecd4891fcd9292d56726f034a59fbdf)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/834472
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/afa74b4a7efa6ff8b67ddf6ea30955e05739887e
Submitter: "Zuul (22348)"
Branch: stable/xena

commit afa74b4a7efa6ff8b67ddf6ea30955e05739887e
Author: Miguel Lavalle <email address hidden>
Date: Fri Mar 18 13:03:22 2022 -0500

    Remove incorrect character in f-string

    Patch [1] switched to f-strings, unwillingly introducing a 'i' to an
    ip address. This change corrects that error

    [1] https://review.opendev.org/c/openstack/ovn-octavia-provider/+/816829

    Closes-Bug: #1965530
    Change-Id: I832780660a3658552dc8fb50c3e232306e1fa110
    (cherry picked from commit 90bd5dc71ecd4891fcd9292d56726f034a59fbdf)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 3.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 1.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 2.1.0 release.