[ovn-octavia-provider] Deleted members remain in ERROR status

[Fernando Royo]

An OVN provider Load Balancer allows the creation of members without specifying the subnet-id. The internal logic allows OVN provider to create the member by associating it with the subnet-id of the pool to which it belongs, but the member is stored in Octavia DB without a reference to the subnet_id associated with the pool.

Subsequently, when an attempt is made to delete a member that was created without specifying the subnet_id to which it belongs, it is left in an ERROR state, while a member that did include that parameter at creation time is deleted correctly.

Steps to Reproduce:
1. Create a load balancer with OVN as provider
2. Create a listener and a pool associated to LB create in 1.
3. Create a member without parameter subnet-id
4. Try to delete the member created in 3.

Expected result:
Member is deleted correctly

Actual result:
Member keeps in ERROR state.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/833799

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/833799
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/82eabfda244de2de54c8417f201c67129b875199
Submitter: "Zuul (22348)"
Branch: master

commit 82eabfda244de2de54c8417f201c67129b875199
Author: Fernando Royo <email address hidden>
Date: Tue Mar 15 15:36:42 2022 +0100

    Fix deletion of members without subnet_id

    OVN octavia provider allows to create member without param subnet_id,
    in that case the driver search it according to the pool_id, but it is
    not propagated to Octavia DB.

    In further operations, as delete or update, Octavia call to the driver
    without subnet_id, getting as result the member in ERROR state.

    Closes-Bug: #1964817
    Change-Id: I08b5ee11dbffe672dfd762c944c2f2c18623826f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/835194

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/835195

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/835196

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/835198

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/835199

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Fernando Royo <email address hidden>" on branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/835199
Reason: duplicate Change Id by error

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/835204

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/835194
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/caf9f2aed3e9e127f49f1b83ec5d5252af5c1d0d
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit caf9f2aed3e9e127f49f1b83ec5d5252af5c1d0d
Author: Fernando Royo <email address hidden>
Date: Tue Mar 15 15:36:42 2022 +0100

    Fix deletion of members without subnet_id

    OVN octavia provider allows to create member without param subnet_id,
    in that case the driver search it according to the pool_id, but it is
    not propagated to Octavia DB.

    In further operations, as delete or update, Octavia call to the driver
    without subnet_id, getting as result the member in ERROR state.

    Closes-Bug: #1964817
    Change-Id: I08b5ee11dbffe672dfd762c944c2f2c18623826f
    (cherry picked from commit 82eabfda244de2de54c8417f201c67129b875199)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/835195
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/3975bb76aeece21021ef951f8069b72d18d7a58e
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 3975bb76aeece21021ef951f8069b72d18d7a58e
Author: Fernando Royo <email address hidden>
Date: Tue Mar 15 15:36:42 2022 +0100

    Fix deletion of members without subnet_id

    OVN octavia provider allows to create member without param subnet_id,
    in that case the driver search it according to the pool_id, but it is
    not propagated to Octavia DB.

    In further operations, as delete or update, Octavia call to the driver
    without subnet_id, getting as result the member in ERROR state.

    Closes-Bug: #1964817
    Change-Id: I08b5ee11dbffe672dfd762c944c2f2c18623826f
    (cherry picked from commit 82eabfda244de2de54c8417f201c67129b875199)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/835196
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/5c7118213fad5dcf3b2fe7727e6fdb0e5d6f7f1f
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 5c7118213fad5dcf3b2fe7727e6fdb0e5d6f7f1f
Author: Fernando Royo <email address hidden>
Date: Tue Mar 15 15:36:42 2022 +0100

    Fix deletion of members without subnet_id

    OVN octavia provider allows to create member without param subnet_id,
    in that case the driver search it according to the pool_id, but it is
    not propagated to Octavia DB.

    In further operations, as delete or update, Octavia call to the driver
    without subnet_id, getting as result the member in ERROR state.

    Closes-Bug: #1964817
    Change-Id: I08b5ee11dbffe672dfd762c944c2f2c18623826f
    (cherry picked from commit 82eabfda244de2de54c8417f201c67129b875199)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/835198
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/f32ece64faeaba5f7842cf90f93963d26357f6dd
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit f32ece64faeaba5f7842cf90f93963d26357f6dd
Author: Fernando Royo <email address hidden>
Date: Tue Mar 15 15:36:42 2022 +0100

    Fix deletion of members without subnet_id

    OVN octavia provider allows to create member without param subnet_id,
    in that case the driver search it according to the pool_id, but it is
    not propagated to Octavia DB.

    In further operations, as delete or update, Octavia call to the driver
    without subnet_id, getting as result the member in ERROR state.

    Conflicts:
        ovn_octavia_provider/driver.py

    Closes-Bug: #1964817
    Change-Id: I08b5ee11dbffe672dfd762c944c2f2c18623826f
    (cherry picked from commit 82eabfda244de2de54c8417f201c67129b875199)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/835204
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/f208e7e9de843904982ce2c7b36278760f53859d
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit f208e7e9de843904982ce2c7b36278760f53859d
Author: Fernando Royo <email address hidden>
Date: Fri Mar 25 11:57:57 2022 +0100

    Fix deletion of members without subnet_id

    OVN octavia provider allows to create member without param subnet_id,
    in that case the driver search it according to the pool_id, but it is
    not propagated to Octavia DB.

    In further operations, as delete or update, Octavia call to the driver
    without subnet_id, getting as result the member in ERROR state.

    Closes-Bug: #1964817
    (manually cherry picked from commit 82eabfda244de2de54c8417f201c67129b875199)

    Change-Id: I08b5ee11dbffe672dfd762c944c2f2c18623826f

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 1.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 3.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn train-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 1.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 2.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider ussuri-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider victoria-eom release.