Support binding floating ip to smart-nic port in the dvr mode.

[Jacy Lee]

In DVR mode, neutron only allows binding flaoting IP to the normal port. When a floating IP is bound to a smart-nic port, neutron raise the error 'Port VNIC type is not valid to associate a FIP in DVR mode' [1]. When the Ironic use smart NICs to implement Bare Metal Servers, the port VNIC type is 'smart-nic', and the Neutron L2 agent and L3 agent run locally on the smart NIC. The smart-nic port can be bound to virtual bridge, and the floating IP can also be implemented by the L3 agent on the smart NIC. So here [2] should also return ture when the port VINC type is 'smart-nic'.

[1] https://github.com/openstack/neutron/blob/b072cbf05f079519e379b2bfebe27846ae612275/neutron/db/l3_db.py#L1280
[2] https://github.com/openstack/neutron-lib/blob/f765e3c21c52f97c713697db4d84c526054078f3/neutron_lib/plugins/utils.py#L390

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron-lib/+/831639

[Brian Haley (brian-haley)]

Seems valid from a high level, will bring up at neutron meeting next week during "bugs" section.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron-lib/+/831639
Committed: https://opendev.org/openstack/neutron-lib/commit/e2f05ffabccda1a8a213cbc2e27c2bf910e5766c
Submitter: "Zuul (22348)"
Branch: master

commit e2f05ffabccda1a8a213cbc2e27c2bf910e5766c
Author: Jacy Lee <[e-mail]>
Date: Thu Mar 3 16:08:49 2022 +0800

    Support binding floating ip to smart-nic port

    When the Ironic use smart NICs to implement Bare Metal servers, the
    neutron L2 agent and L3 agent run locally on the smart NIC. The
    smart-nic port can be bound to the virtual bridge, and the floating
    ip can also be implemented by the L3 agent on the smart NIC.

    Closes-Bug: #1962821
    Change-Id: I6c10c51b4ed6fd5f05671a9d3b2d5d7aa087eb2b

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron-lib/+/832715

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/neutron-lib/+/832716

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron-lib/+/832717

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron-lib/+/832718

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron-lib/+/832719

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron-lib/+/832720

[Slawek Kaplonski (slaweq)]

This bug has had a related patch abandoned and has been automatically un-assigned due to inactivity. Please re-assign yourself if you are continuing work or adjust the state as appropriate if it is no longer valid.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Slawek Kaplonski <email address hidden>" on branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron-lib/+/832715
Reason: This review is > 4 weeks without comment, and failed Zuul jobs the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-lib 2.21.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Rodolfo Alonso <email address hidden>" on branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron-lib/+/832717
Reason: Same reason as commented in https://review.opendev.org/c/openstack/neutron-lib/+/832715

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Rodolfo Alonso <email address hidden>" on branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron-lib/+/832718
Reason: Same reason as commented in https://review.opendev.org/c/openstack/neutron-lib/+/832715

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Rodolfo Alonso <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron-lib/+/832719
Reason: Same reason as commented in https://review.opendev.org/c/openstack/neutron-lib/+/832715

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Rodolfo Alonso <email address hidden>" on branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron-lib/+/832720
Reason: Same reason as commented in https://review.opendev.org/c/openstack/neutron-lib/+/832715

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Rodolfo Alonso <email address hidden>" on branch: stable/train
Review: https://review.opendev.org/c/openstack/neutron-lib/+/832716
Reason: Same reason as commented in https://review.opendev.org/c/openstack/neutron-lib/+/832715