neutron

"get_rule_type" should not check the context admin status

Bug #1959778 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
New
Low
Unassigned

Bug Description

Method "get_rule_type" should not check the context admin status [1]. This should be done in the policy hook, before calling this method. This is covered and tested in the new secure RBAC policies.

[1]https://github.com/openstack/neutron/blob/e7b70521d0e230143a80974e7e4795a2acafcc9b/neutron/services/qos/qos_plugin.py#L867-L868

Tags: qos
Rodolfo Alonso (rodolfo-alonso-hernandez)
Changed in neutron:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron-lib (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron-lib/+/827533

Lajos Katona (lajos-katona)
tags: added: qos
Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
status: New → In Progress
Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :

Sorry, I added this LP link to a non related patch [1]. My bad.

[1]https://review.opendev.org/c/openstack/neutron-lib/+/827533

Changed in neutron:
status: In Progress → New
assignee: Rodolfo Alonso (rodolfo-alonso-hernandez) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.