[tempest] Test "test_list_policy_filter_by_name" failing

[Rodolfo Alonso]

Log: https://4f906509796c68317fb0-5f46846acfbcb9c99203c3f7b3243d40.ssl.cf2.rackcdn.com/826512/2/check/neutron-tempest-plugin-api/c1456f8/testr_results.html

Snippet: https://paste.opendev.org/show/812395/

[yatin (yatinkarel)]

So it failed because three tests creating policy with same name: "test" around same time, and hence list policy by name failed as it expected only 1 policy to exist with name "test" but actually there were three. Using different specific name in test_list_policy_filter_by_name should fix the issue.

But also i see all the three policies created associated with different project_id, so may be it's some bug that it list from all the projects instead of just the one it's created for? So will also check that, may be it's introduced after recent rbac related patch https://review.opendev.org/c/openstack/neutron/+/821208.

2022-01-26 19:39:20.724046 | controller | {3} neutron_tempest_plugin.api.test_qos_negative.QosNegativeTestJSON.test_update_policy_with_too_long_description [0.086488s] ... ok
2022-01-26 19:39:20.822808 | controller | {3} neutron_tempest_plugin.api.test_qos_negative.QosNegativeTestJSON.test_update_policy_with_too_long_name [0.098501s] ... ok
2022-01-26 19:39:20.878403 | controller | {2} neutron_tempest_plugin.api.test_qos.QosTestJSON.test_list_policy_filter_by_name [0.223892s] ... FAILED

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/826827

[yatin (yatinkarel)]

<< But also i see all the three policies created associated with different project_id, so may be it's some bug that it list from all the projects instead of just the one it's created for? So will also check that, may be it's introduced after recent rbac related patch https://review.opendev.org/c/openstack/neutron/+/821208.

So i see admin creates this policy and it can list policies for all these projects so doesn't look like a regression it was just not hit by now.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/826871

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/826871
Committed: https://opendev.org/openstack/neutron-tempest-plugin/commit/757f3f1d1390090fbd43ba19a7632bcb7b580147
Submitter: "Zuul (22348)"
Branch: master

commit 757f3f1d1390090fbd43ba19a7632bcb7b580147
Author: elajkat <email address hidden>
Date: Fri Jan 28 11:17:55 2022 +0100

    Use random policy names in test_qos and test_qos_negative

    Change-Id: Ib5f586e38c7c23fce6e03dc28b3f3d4828264ebf
    Related-Bug: 1959184

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/826827
Committed: https://opendev.org/openstack/neutron-tempest-plugin/commit/65fa2c06f7fa719620cd27ea70b52e9299ca9312
Submitter: "Zuul (22348)"
Branch: master

commit 65fa2c06f7fa719620cd27ea70b52e9299ca9312
Author: yatinkarel <email address hidden>
Date: Fri Jan 28 13:44:19 2022 +0530

    Use random name in qos test_list_policy_filter_by_name

    test_list_policy_filter_by_name was looking for policies
    with name 'test' and expected only one such policy to
    be retrieved, but since tempest is running with multiple
    concurrency and some other qos tests were also using same
    policy name, this leads to test failure when this test
    runs at same time with other such tests. This patch fixes
    it by using random name for the policy for this test.

    Closes-Bug: #1959184
    Change-Id: Ibcbb2403b5b5983b2573c5a4791fb30850816d60

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-tempest-plugin 1.9.0 release.