OVN mech driver failing to check the L2/L3 connectivity

[Rodolfo Alonso]

In LP#1821058, a new parameter was defined for each mechanism driver, the "connectivity". That provides a way to define what type of driver is. For example, SRIOV, Linux Bridge, OVS or OVN are "l2" drivers. Calico is "l3" only. The default value is "legacy".

In [1], a check for ports without IP addresses. Those kind of ports can only be bound to "l2" drivers.

In [2] I changed the "vif_details" dictionary to populated the two sub-dicts under "ovs" and "vhostuser". The problem is that check [1] cannot be done because the "connectivity" parameter in not a key in "vif_details" anymore.

A more robust way to check the mech driver connectivity must be implemented, rather that adding it to a dictionary, "vif_details", that has not a defined structure.

NOTE: this is currently breaking heat-tempest-plugin CI master job.

[1]https://review.opendev.org/c/openstack/neutron/+/678027
[2]https://review.opendev.org/c/openstack/neutron/+/814143

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron-lib/+/826501

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/826502

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron-lib/+/826501
Committed: https://opendev.org/openstack/neutron-lib/commit/c2166f9af6ccbe8fdaff6fc035291633539329dc
Submitter: "Zuul (22348)"
Branch: master

commit c2166f9af6ccbe8fdaff6fc035291633539329dc
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Jan 26 17:23:54 2022 +0000

    Add "connectivity" property to "MechanismDriver"

    This property will return the type of the driver: "l2", "l3" or
    "legacy".

    bp boot-vm-with-unaddressed-port
    Related-Bug: #1959125
    Related-Bug: #1821058

    Change-Id: I5730c68e4e860028efa0541b0098c439c14524d7

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/826502
Committed: https://opendev.org/openstack/neutron/commit/0fe6c0b8ca8a5704242766472d94d5ca86832363
Submitter: "Zuul (22348)"
Branch: master

commit 0fe6c0b8ca8a5704242766472d94d5ca86832363
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Jan 26 17:37:07 2022 +0000

    Use the "connectivity" property of "MechanismDriver"

    The base class "MechanismDriver" now has a property called
    "connectivity". This patch overrides the default value in the
    in-tree drivers.

    The method "_check_drivers_connectivity" now uses this property
    that is available in all drivers.

    Depends-On: https://review.opendev.org/c/openstack/neutron-lib/+/826501

    Closes-Bug: #1959125
    bp boot-vm-with-unaddressed-port
    Related-Bug: #1821058

    Change-Id: I91734835b07d804365b46adfb26e984557107d80

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 20.0.0.0rc1 release candidate.