neutron

OVS: except MappingNotFound instead of KeyError

Bug #1957931 reported by James Pic on 2022-01-14

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	neutron	Fix Released	High	James Pic

Bug Description

LocalVlanManager.pop() swallows KeyError to raise MappingNotFound: https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/vlanmanager.py#L110

OVSNeutronAgent.reclaim_local_vlan() excepts a KeyError:
https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L1064

Which breaks the loop in treat_devices_removed(): https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L2053

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-01-14: Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/824727

Changed in neutron:
status:	New → In Progress

Rodolfo Alonso (rodolfo-alonso-hernandez) on 2022-01-17

Changed in neutron:
importance:	Undecided → High

Lajos Katona (lajos-katona) on 2022-01-17

Changed in neutron:
assignee:	nobody → James Pic (jpic)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-01-20: Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/824727
Committed: https://opendev.org/openstack/neutron/commit/d033c9f93327b5845280bbc21e5a229555b905f4
Submitter: "Zuul (22348)"
Branch: master

commit d033c9f93327b5845280bbc21e5a229555b905f4
Author: jpic <email address hidden>
Date: Fri Jan 14 16:31:22 2022 +0100

Fix OVS OVSNeutronAgent.reclaim_local_vlan()

Closes-Bug: #1957931

Change-Id: I5b716399cb8344b8a89b97378fcb4796654e6152

Changed in neutron:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-01-20: Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/825449

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-01-20: Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/825470

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-01-20: Fix proposed to neutron (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/825471

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-01-20: Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/825472

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-01-21: Fix merged to neutron (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/825471
Committed: https://opendev.org/openstack/neutron/commit/f47fdf4d0599c83249d042a89c0905a2dcd0b93e
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit f47fdf4d0599c83249d042a89c0905a2dcd0b93e
Author: jpic <email address hidden>
Date: Fri Jan 14 16:31:22 2022 +0100

Fix OVS OVSNeutronAgent.reclaim_local_vlan()

Closes-Bug: #1957931

Change-Id: I5b716399cb8344b8a89b97378fcb4796654e6152
(cherry picked from commit d033c9f93327b5845280bbc21e5a229555b905f4)

tags:

added: in-stable-victoria

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-01-21: Fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/825472
Committed: https://opendev.org/openstack/neutron/commit/4affce8fe5a258d9a195702f17e09c50571cf40c
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 4affce8fe5a258d9a195702f17e09c50571cf40c
Author: jpic <email address hidden>
Date: Fri Jan 14 16:31:22 2022 +0100

Fix OVS OVSNeutronAgent.reclaim_local_vlan()

Closes-Bug: #1957931

Change-Id: I5b716399cb8344b8a89b97378fcb4796654e6152
(cherry picked from commit d033c9f93327b5845280bbc21e5a229555b905f4)

tags:

added: in-stable-ussuri

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-01-21: Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/825470
Committed: https://opendev.org/openstack/neutron/commit/8fa04bec83c2f672ca3f51b97bd966b0cbafdc44
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 8fa04bec83c2f672ca3f51b97bd966b0cbafdc44
Author: jpic <email address hidden>
Date: Fri Jan 14 16:31:22 2022 +0100

Fix OVS OVSNeutronAgent.reclaim_local_vlan()

Closes-Bug: #1957931

Change-Id: I5b716399cb8344b8a89b97378fcb4796654e6152
(cherry picked from commit d033c9f93327b5845280bbc21e5a229555b905f4)

tags:

added: in-stable-wallaby

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-01-26: Fix merged to neutron (stable/xena)

#10

Reviewed: https://review.opendev.org/c/openstack/neutron/+/825449
Committed: https://opendev.org/openstack/neutron/commit/eb582be329f16640a741c85f1b34e58f5ec42e6a
Submitter: "Zuul (22348)"
Branch: stable/xena

commit eb582be329f16640a741c85f1b34e58f5ec42e6a
Author: jpic <email address hidden>
Date: Fri Jan 14 16:31:22 2022 +0100

Fix OVS OVSNeutronAgent.reclaim_local_vlan()

Closes-Bug: #1957931

Change-Id: I5b716399cb8344b8a89b97378fcb4796654e6152
(cherry picked from commit d033c9f93327b5845280bbc21e5a229555b905f4)

tags:

added: in-stable-xena

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-03-10: Fix included in openstack/neutron 20.0.0.0rc1

#11

This issue was fixed in the openstack/neutron 20.0.0.0rc1 release candidate.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-04-21: Fix included in openstack/neutron 17.4.0

#12

This issue was fixed in the openstack/neutron 17.4.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-04-21: Fix included in openstack/neutron 18.3.0

#13

This issue was fixed in the openstack/neutron 18.3.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-04-21: Fix included in openstack/neutron 19.2.0

#14

This issue was fixed in the openstack/neutron 19.2.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2024-01-17: Fix included in openstack/neutron ussuri-eol

#15

This issue was fixed in the openstack/neutron ussuri-eol release.

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.