Wrong ACTIVE status of subports attached to a trunk whose parent is DOWN

[Luis Tomas Bolivar]

Subports of a trunk should have the same status as the parent port. However, with ovn, if the parent port is in DOWN status, the subports are transitioned to ACTIVE as soon as they are attached to the trunk

Steps to reproduce
- Create 2 ports , Port1 and Port2 (in DOWN status)
- Create trunk: openstack network trunk create --parent-port Port1 trunk
- Add Port2 as a subport of the trunk: openstack network trunk set --subport port=Port2,segmentation-type=vlan,segmentation-id=101 trunk
- Check the status of Port2 is ACTIVE, while it should be DOWN

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/824378

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/824378
Committed: https://opendev.org/openstack/neutron/commit/15d6cfffc9f3c63a7bac75f8d04beaae82ddc794
Submitter: "Zuul (22348)"
Branch: master

commit 15d6cfffc9f3c63a7bac75f8d04beaae82ddc794
Author: Luis Tomas Bolivar <email address hidden>
Date: Wed Jan 12 11:45:53 2022 +0100

    Ensure subports status is aligned with parent port

    Subports of a trunk should have the same status as the parent port.
    However, with ovn, if the parent port is in DOWN status, the subports
    are transitioned to ACTIVE as soon as they are attached to the trunk.

    This patch ensure the status set on the subports when being attached
    matches the one on the parent port.

    Closes-Bug: #1957161
    Change-Id: I26c43c2909b635e8b21306ea1880da3877477a17

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/826843

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/826919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/826843
Committed: https://opendev.org/openstack/neutron/commit/08a35203dedffdbad62819af21877055205d14d1
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 08a35203dedffdbad62819af21877055205d14d1
Author: Luis Tomas Bolivar <email address hidden>
Date: Wed Jan 12 11:45:53 2022 +0100

    Ensure subports status is aligned with parent port

    Subports of a trunk should have the same status as the parent port.
    However, with ovn, if the parent port is in DOWN status, the subports
    are transitioned to ACTIVE as soon as they are attached to the trunk.

    This patch ensure the status set on the subports when being attached
    matches the one on the parent port.

    Closes-Bug: #1957161
    Change-Id: I26c43c2909b635e8b21306ea1880da3877477a17
    (cherry picked from commit 15d6cfffc9f3c63a7bac75f8d04beaae82ddc794)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/826919
Committed: https://opendev.org/openstack/neutron/commit/0340d412bef0d52da996ab901b12bf15c3015d9e
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 0340d412bef0d52da996ab901b12bf15c3015d9e
Author: Luis Tomas Bolivar <email address hidden>
Date: Wed Jan 12 11:45:53 2022 +0100

    Ensure subports status is aligned with parent port

    Subports of a trunk should have the same status as the parent port.
    However, with ovn, if the parent port is in DOWN status, the subports
    are transitioned to ACTIVE as soon as they are attached to the trunk.

    This patch ensure the status set on the subports when being attached
    matches the one on the parent port.

    Conflicts:
           neutron/services/trunk/drivers/ovn/trunk_driver.py

    The conflict is related to the code added by
    https://github.com/openstack/neutron/commit/6ada9124143f42311951a75b5d586bbab4451ce6

    Closes-Bug: #1957161
    Change-Id: I26c43c2909b635e8b21306ea1880da3877477a17
    (cherry picked from commit 15d6cfffc9f3c63a7bac75f8d04beaae82ddc794)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/830123

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/830064

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/830123
Committed: https://opendev.org/openstack/neutron/commit/2a6148869ab95c9075b23a152186a5edc8608b55
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 2a6148869ab95c9075b23a152186a5edc8608b55
Author: Luis Tomas Bolivar <email address hidden>
Date: Wed Jan 12 11:45:53 2022 +0100

    Ensure subports status is aligned with parent port

    Subports of a trunk should have the same status as the parent port.
    However, with ovn, if the parent port is in DOWN status, the subports
    are transitioned to ACTIVE as soon as they are attached to the trunk.

    This patch ensure the status set on the subports when being attached
    matches the one on the parent port.

    Conflicts:
        neutron/services/trunk/drivers/ovn/trunk_driver.py

    Closes-Bug: #1957161
    Change-Id: I26c43c2909b635e8b21306ea1880da3877477a17
    (cherry picked from commit 15d6cfffc9f3c63a7bac75f8d04beaae82ddc794)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/830064
Committed: https://opendev.org/openstack/neutron/commit/246d7da7da11643a1f5c0b2fe167141db773fc2e
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 246d7da7da11643a1f5c0b2fe167141db773fc2e
Author: Luis Tomas Bolivar <email address hidden>
Date: Wed Jan 12 11:45:53 2022 +0100

    Ensure subports status is aligned with parent port

    Subports of a trunk should have the same status as the parent port.
    However, with ovn, if the parent port is in DOWN status, the subports
    are transitioned to ACTIVE as soon as they are attached to the trunk.

    This patch ensure the status set on the subports when being attached
    matches the one on the parent port.

    Conflicts:
        neutron/services/trunk/drivers/ovn/trunk_driver.py

    Closes-Bug: #1957161
    Change-Id: I26c43c2909b635e8b21306ea1880da3877477a17
    (cherry picked from commit 15d6cfffc9f3c63a7bac75f8d04beaae82ddc794)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 20.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 17.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 18.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 19.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn train-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron ussuri-eol release.