neutron

Error when l3-agent get filter id for ip

Bug #1955775 reported by Zhai Mengdong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Zhai Mengdong

Bug Description

2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent Traceback (most recent call last):
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent File "/usr/lib/python3.6/site-packages/neutron/agent/l3/agent.py", line 555, in _process_router_update
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent self._process_router_if_compatible(router)
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent File "/usr/lib/python3.6/site-packages/neutron/agent/l3/agent.py", line 477, in _process_router_if_compatible
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent self._process_updated_router(router)
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent File "/usr/lib/python3.6/site-packages/neutron/agent/l3/agent.py", line 501, in _process_updated_router
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent self.l3_ext_manager.update_router(self.context, router)
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent File "/usr/lib/python3.6/site-packages/neutron/agent/l3/l3_agent_extensions_manager.py", line 54, in update_router
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent extension.obj.update_router(context, data)
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent File "/usr/lib/python3.6/site-packages/oslo_concurrency/lockutils.py", line 359, in inner
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent return f(*args, **kwargs)
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent File "/usr/lib/python3.6/site-packages/neutron/agent/l3/extensions/qos/fip.py", line 236, in update_router
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent self.process_floating_ip_addresses(context, router_info)
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent File "/usr/lib/python3.6/site-packages/neutron/agent/l3/extensions/qos/fip.py", line 218, in process_floating_ip_addresses
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent self.process_ip_rates(fip_addr, device, rates)
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent File "/usr/lib/python3.6/site-packages/neutron/agent/l3/extensions/qos/fip.py", line 183, in process_ip_rates
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent rate['rate'], rate['burst'])
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent File "/usr/lib/python3.6/site-packages/neutron/agent/l3/extensions/qos/fip.py", line 123, in process_ip_rate_limit
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent tc_wrapper.set_ip_rate_limit(direction, ip, rate, burst)
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent File "/usr/lib/python3.6/site-packages/neutron/agent/linux/l3_tc_lib.py", line 169, in set_ip_rate_limit
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent filter_id = self._get_filterid_for_ip(qdisc_id, ip)
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent File "/usr/lib/python3.6/site-packages/neutron/agent/linux/l3_tc_lib.py", line 82, in _get_filterid_for_ip
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent filterids_for_ip.append(filter_id)
2021-12-22 23:37:34.366 3403 ERROR neutron.agent.l3.agent UnboundLocalError: local variable 'filter_id' referenced before assignment

If the interface is accidentally added some tc rules not through neutron, for example, the interface has two tc rules, the first rule is "filter protocol all ...", the second rule is "match ...". This first rule mismatch FILTER_ID_REGEX and the second rule starts with "match", so the code will execute this statement:

filterids_for_ip.append(filter_id)

But filter_id has not been assignment at this time.

Zhai Mengdong (mengdong)
Changed in neutron:
assignee: nobody → Zhai Mengdong (mengdong)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/822987

Changed in neutron:
status: New → In Progress
Bence Romsics (bence-romsics)
Changed in neutron:
status: In Progress → Won't Fix
status: Won't Fix → Triaged
importance: Undecided → High
OpenStack Infra (hudson-openstack)
Changed in neutron:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/822987
Committed: https://opendev.org/openstack/neutron/commit/0255eb31e5c3ce31ed08069c4e5c0fcb1fc29074
Submitter: "Zuul (22348)"
Branch: master

commit 0255eb31e5c3ce31ed08069c4e5c0fcb1fc29074
Author: zhaimengdong <email address hidden>
Date: Mon Dec 27 14:06:39 2021 +0800

    Fix a error when l3-agent gets filter id for ip

    Before using filter_id in _get_filterid_for_ip(), we should assign it first.

    Closes-Bug: #1955775

    Change-Id: Icea0a8b756f210761b635d2d34e2af04a939a640

Changed in neutron:
status: In Progress → Fix Released
Bernard Cafarelli (bcafarel)
tags: added: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 20.0.0.0rc1

This issue was fixed in the openstack/neutron 20.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/833197

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/833198

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/833199

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/833200

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/neutron/+/833201

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/833197
Committed: https://opendev.org/openstack/neutron/commit/ceaed57f428769a914b2bc57055cc2f16058e2be
Submitter: "Zuul (22348)"
Branch: stable/xena

commit ceaed57f428769a914b2bc57055cc2f16058e2be
Author: zhaimengdong <email address hidden>
Date: Mon Dec 27 14:06:39 2021 +0800

    Fix a error when l3-agent gets filter id for ip

    Before using filter_id in _get_filterid_for_ip(), we should assign it first.

    Closes-Bug: #1955775

    Change-Id: Icea0a8b756f210761b635d2d34e2af04a939a640
    (cherry picked from commit 0255eb31e5c3ce31ed08069c4e5c0fcb1fc29074)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/833198
Committed: https://opendev.org/openstack/neutron/commit/6c27df2ca099567b2630928936f7ea201a8a464c
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 6c27df2ca099567b2630928936f7ea201a8a464c
Author: zhaimengdong <email address hidden>
Date: Mon Dec 27 14:06:39 2021 +0800

    Fix a error when l3-agent gets filter id for ip

    Before using filter_id in _get_filterid_for_ip(), we should assign it first.

    Closes-Bug: #1955775

    Change-Id: Icea0a8b756f210761b635d2d34e2af04a939a640
    (cherry picked from commit 0255eb31e5c3ce31ed08069c4e5c0fcb1fc29074)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/833200
Committed: https://opendev.org/openstack/neutron/commit/f13a420a41a29b6747b93709a53a76102d12a6ee
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit f13a420a41a29b6747b93709a53a76102d12a6ee
Author: zhaimengdong <email address hidden>
Date: Mon Dec 27 14:06:39 2021 +0800

    Fix a error when l3-agent gets filter id for ip

    Before using filter_id in _get_filterid_for_ip(), we should assign it first.

    Closes-Bug: #1955775

    Change-Id: Icea0a8b756f210761b635d2d34e2af04a939a640
    (cherry picked from commit 0255eb31e5c3ce31ed08069c4e5c0fcb1fc29074)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/train)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/833201
Committed: https://opendev.org/openstack/neutron/commit/71d1bfb2b820dfefa508363f4995bdf3becb716d
Submitter: "Zuul (22348)"
Branch: stable/train

commit 71d1bfb2b820dfefa508363f4995bdf3becb716d
Author: zhaimengdong <email address hidden>
Date: Mon Dec 27 14:06:39 2021 +0800

    Fix a error when l3-agent gets filter id for ip

    Before using filter_id in _get_filterid_for_ip(), we should assign it first.

    Closes-Bug: #1955775

    Change-Id: Icea0a8b756f210761b635d2d34e2af04a939a640
    (cherry picked from commit 0255eb31e5c3ce31ed08069c4e5c0fcb1fc29074)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/833199
Committed: https://opendev.org/openstack/neutron/commit/36e89eb1827924980a166edeedfbe83d76a1843c
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 36e89eb1827924980a166edeedfbe83d76a1843c
Author: zhaimengdong <email address hidden>
Date: Mon Dec 27 14:06:39 2021 +0800

    Fix a error when l3-agent gets filter id for ip

    Before using filter_id in _get_filterid_for_ip(), we should assign it first.

    Closes-Bug: #1955775

    Change-Id: Icea0a8b756f210761b635d2d34e2af04a939a640
    (cherry picked from commit 0255eb31e5c3ce31ed08069c4e5c0fcb1fc29074)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 17.4.0

This issue was fixed in the openstack/neutron 17.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 18.3.0

This issue was fixed in the openstack/neutron 18.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 19.2.0

This issue was fixed in the openstack/neutron 19.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron train-eol

This issue was fixed in the openstack/neutron train-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron ussuri-eol

This issue was fixed in the openstack/neutron ussuri-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.