[stable only] Logging service plugin expects wrong arguments in the callback function

[Slawek Kaplonski]

To fix bug https://bugs.launchpad.net/neutron/+bug/1939558 we proposed 2 patches https://review.opendev.org/c/openstack/neutron/+/810870 and https://review.opendev.org/c/openstack/neutron/+/815298/ (those are wallaby backports).
But by mistake we used new style of the payload arguments in the callback functions in neutron/services/logapi/logging_plugin.py in _clean_logs_by_resource_id method thus now it's failing when that callback is called.
It affects only wallaby and older releases as Xena and master are already moved to the new callbacks so it works fine there.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/822602

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/822610

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/822611

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/neutron/+/822612

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/822602
Committed: https://opendev.org/openstack/neutron/commit/adbcc77a3f7ebbf9a2302248dcdfbeece1a0528f
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit adbcc77a3f7ebbf9a2302248dcdfbeece1a0528f
Author: Slawek Kaplonski <email address hidden>
Date: Wed Dec 22 08:37:45 2021 +0100

    [Stable only] Fix callback function arguments

    Fixes [1] and [2] for bug [3] are using new callabacks mechanism and
    expects payload as one of the arguments passed to the callback functions.
    This works fine in Xena+ releases but not in Wallaby and olders where
    old callbacks mechanism is still used, at least for the security group
    AFTER_DELETE events.
    So this patch fixes that by changing to the old callbacks mechanism in
    the logging service plugin in stable/wallaby and older branches only.

    Closes-Bug: #1955546

    [1] https://review.opendev.org/c/openstack/neutron/+/804237
    [2] https://review.opendev.org/c/openstack/neutron/+/812459
    [3] https://bugs.launchpad.net/neutron/+bug/1939558

    Change-Id: I0003bd566dc769436ad1342351ad058394bd52da

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/822610
Committed: https://opendev.org/openstack/neutron/commit/90156cef695b26d6f8bcf5f7f0329effafc4e322
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 90156cef695b26d6f8bcf5f7f0329effafc4e322
Author: Slawek Kaplonski <email address hidden>
Date: Wed Dec 22 08:37:45 2021 +0100

    [Stable only] Fix callback function arguments

    Fixes [1] and [2] for bug [3] are using new callabacks mechanism and
    expects payload as one of the arguments passed to the callback functions.
    This works fine in Xena+ releases but not in Wallaby and olders where
    old callbacks mechanism is still used, at least for the security group
    AFTER_DELETE events.
    So this patch fixes that by changing to the old callbacks mechanism in
    the logging service plugin in stable/wallaby and older branches only.

    Closes-Bug: #1955546

    [1] https://review.opendev.org/c/openstack/neutron/+/804237
    [2] https://review.opendev.org/c/openstack/neutron/+/812459
    [3] https://bugs.launchpad.net/neutron/+bug/1939558

    Change-Id: I0003bd566dc769436ad1342351ad058394bd52da

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/822611
Committed: https://opendev.org/openstack/neutron/commit/eb1190d2067f24b6accc3463e601e5b41c0e0be4
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit eb1190d2067f24b6accc3463e601e5b41c0e0be4
Author: Slawek Kaplonski <email address hidden>
Date: Wed Dec 22 08:37:45 2021 +0100

    [Stable only] Fix callback function arguments

    Fixes [1] and [2] for bug [3] are using new callabacks mechanism and
    expects payload as one of the arguments passed to the callback functions.
    This works fine in Xena+ releases but not in Wallaby and olders where
    old callbacks mechanism is still used, at least for the security group
    AFTER_DELETE events.
    So this patch fixes that by changing to the old callbacks mechanism in
    the logging service plugin in stable/wallaby and older branches only.

    Closes-Bug: #1955546

    [1] https://review.opendev.org/c/openstack/neutron/+/804237
    [2] https://review.opendev.org/c/openstack/neutron/+/812459
    [3] https://bugs.launchpad.net/neutron/+bug/1939558

    Change-Id: I0003bd566dc769436ad1342351ad058394bd52da

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/822612
Committed: https://opendev.org/openstack/neutron/commit/65310eb566f82258847c08d8f48725a47152b053
Submitter: "Zuul (22348)"
Branch: stable/train

commit 65310eb566f82258847c08d8f48725a47152b053
Author: Slawek Kaplonski <email address hidden>
Date: Wed Dec 22 08:37:45 2021 +0100

    [Stable only] Fix callback function arguments

    Fixes [1] and [2] for bug [3] are using new callabacks mechanism and
    expects payload as one of the arguments passed to the callback functions.
    This works fine in Xena+ releases but not in Wallaby and olders where
    old callbacks mechanism is still used, at least for the security group
    AFTER_DELETE events.
    So this patch fixes that by changing to the old callbacks mechanism in
    the logging service plugin in stable/wallaby and older branches only.

    Closes-Bug: #1955546

    [1] https://review.opendev.org/c/openstack/neutron/+/804237
    [2] https://review.opendev.org/c/openstack/neutron/+/812459
    [3] https://bugs.launchpad.net/neutron/+bug/1939558

    Change-Id: I0003bd566dc769436ad1342351ad058394bd52da

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 17.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 18.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron train-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron ussuri-eol release.