Agents API test failed due to not expected "alive" status of the agent

[Slawek Kaplonski]

Failure https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_877/820125/1/check/neutron-tempest-plugin-api/877167f/testr_results.html

Stacktrace:

Traceback (most recent call last):
  File "/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/neutron_tempest_plugin/api/admin/test_agent_management.py", line 44, in test_list_agent
    self.assertIn(self.agent, agents)
  File "/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/testtools/testcase.py", line 399, in assertIn
    self.assertThat(haystack, Contains(needle), message)
  File "/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/testtools/testcase.py", line 480, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: {'binary': 'neutron-ovn-metadata-agent', 'host': 'ubuntu-focal-rax-iad-0027624514', 'availability_zone': '', 'topic': 'n/a', 'description': '', 'agent_type': 'OVN Metadata agent', 'id': 'c182fa5f-fd73-51c3-bd64-358818183f45', 'alive': False, 'admin_state_up': True} not in [{'binary': 'neutron-ovn-metadata-agent', 'host': 'ubuntu-focal-rax-iad-0027624514', 'availability_zone': '', 'topic': 'n/a', 'description': '', 'agent_type': 'OVN Metadata agent', 'id': 'c182fa5f-fd73-51c3-bd64-358818183f45', 'alive': True, 'admin_state_up': True}, {'binary': 'ovn-controller', 'host': 'ubuntu-focal-rax-iad-0027624514', 'availability_zone': '', 'topic': 'n/a', 'description': '', 'agent_type': 'OVN Controller Gateway agent', 'id': '5c61e06b-c437-45c9-b91e-6f29af544b4f', 'alive': True, 'admin_state_up': True}]

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/820921

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/820921
Committed: https://opendev.org/openstack/neutron-tempest-plugin/commit/7914c980381df859f7c55f8de1b316965bee8470
Submitter: "Zuul (22348)"
Branch: master

commit 7914c980381df859f7c55f8de1b316965bee8470
Author: elajkat <email address hidden>
Date: Tue Dec 7 18:40:38 2021 +0100

    test_list_agent: pop 'alive' from agent dict

    As the test class lists agents in resource setup it can happen that the
    selected agent from the list is not 'alive', but when test
    test_list_agent lists again the agents, it is already up and
    'alive'=True.
    To avoid such failure, do skip 'alive' field of the comparison.

    Change-Id: I0ed012ef59550e853a30e2994a1ab53083d8640c
    Closes-Bug: #1953480

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-tempest-plugin 1.9.0 release.