Neutron functional tests don't properly clean up ovn-northd

[Terry Wilson]

ovn-northd does not get stopped when running dsvm-functional tests.

[vagrant@fedora neutron]$ pgrep ovn-northd
[vagrant@fedora neutron]$ tox -e dsvm-functional test_agent_change
dsvm-functional develop-inst-noop: /opt/stack/neutron

...

dsvm-functional: commands succeeded
congratulations :)

[vagrant@fedora neutron]$ pgrep ovn-northd
525468

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/819049

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/819049
Committed: https://opendev.org/openstack/neutron/commit/74aa86a976c5bcf42b2779e5c557d7f7f4fdac9b
Submitter: "Zuul (22348)"
Branch: master

commit 74aa86a976c5bcf42b2779e5c557d7f7f4fdac9b
Author: Terry Wilson <email address hidden>
Date: Tue Nov 23 21:21:27 2021 -0600

    Properly clean up ovn-northd in functional tests

    ovn-northd.ctl is a socket, so os.path.isfile() returns false and
    ovn-northd is not properly killed. Use os.path.exists() instead.

    Closes-Bug: #1952023
    Change-Id: I00fba2dc4395c0a8cd4631d4c2c71d9c3dc429e9

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/825722

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/825723

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/825724

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/825725

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/825722
Committed: https://opendev.org/openstack/neutron/commit/ff45fce49573154f91849feab20935472ed293a2
Submitter: "Zuul (22348)"
Branch: stable/xena

commit ff45fce49573154f91849feab20935472ed293a2
Author: Terry Wilson <email address hidden>
Date: Tue Nov 23 21:21:27 2021 -0600

    Properly clean up ovn-northd in functional tests

    ovn-northd.ctl is a socket, so os.path.isfile() returns false and
    ovn-northd is not properly killed. Use os.path.exists() instead.

    Closes-Bug: #1952023
    Change-Id: I00fba2dc4395c0a8cd4631d4c2c71d9c3dc429e9
    (cherry picked from commit 74aa86a976c5bcf42b2779e5c557d7f7f4fdac9b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/825723
Committed: https://opendev.org/openstack/neutron/commit/46e763b63b7e469a45f964c63f16984f5bb2ca0a
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 46e763b63b7e469a45f964c63f16984f5bb2ca0a
Author: Terry Wilson <email address hidden>
Date: Tue Nov 23 21:21:27 2021 -0600

    Properly clean up ovn-northd in functional tests

    ovn-northd.ctl is a socket, so os.path.isfile() returns false and
    ovn-northd is not properly killed. Use os.path.exists() instead.

    Closes-Bug: #1952023
    Change-Id: I00fba2dc4395c0a8cd4631d4c2c71d9c3dc429e9
    (cherry picked from commit 74aa86a976c5bcf42b2779e5c557d7f7f4fdac9b)
    (cherry picked from commit ff45fce49573154f91849feab20935472ed293a2)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/825724
Committed: https://opendev.org/openstack/neutron/commit/b11f3f4c37cbc02f37de78cdc32837f18807d018
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit b11f3f4c37cbc02f37de78cdc32837f18807d018
Author: Terry Wilson <email address hidden>
Date: Tue Nov 23 21:21:27 2021 -0600

    Properly clean up ovn-northd in functional tests

    ovn-northd.ctl is a socket, so os.path.isfile() returns false and
    ovn-northd is not properly killed. Use os.path.exists() instead.

    Closes-Bug: #1952023
    Change-Id: I00fba2dc4395c0a8cd4631d4c2c71d9c3dc429e9
    (cherry picked from commit 74aa86a976c5bcf42b2779e5c557d7f7f4fdac9b)
    (cherry picked from commit ff45fce49573154f91849feab20935472ed293a2)
    (cherry picked from commit 46e763b63b7e469a45f964c63f16984f5bb2ca0a)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/825725
Committed: https://opendev.org/openstack/neutron/commit/fb8ab2bd3bddaa94cce67872bde31ca4f5647f30
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit fb8ab2bd3bddaa94cce67872bde31ca4f5647f30
Author: Terry Wilson <email address hidden>
Date: Tue Nov 23 21:21:27 2021 -0600

    Properly clean up ovn-northd in functional tests

    ovn-northd.ctl is a socket, so os.path.isfile() returns false and
    ovn-northd is not properly killed. Use os.path.exists() instead.

    Closes-Bug: #1952023
    Change-Id: I00fba2dc4395c0a8cd4631d4c2c71d9c3dc429e9
    (cherry picked from commit 74aa86a976c5bcf42b2779e5c557d7f7f4fdac9b)
    (cherry picked from commit ff45fce49573154f91849feab20935472ed293a2)
    (cherry picked from commit 46e763b63b7e469a45f964c63f16984f5bb2ca0a)
    (cherry picked from commit b11f3f4c37cbc02f37de78cdc32837f18807d018)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 20.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 17.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 18.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 19.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron ussuri-eol release.