neutron

[OVN] dns-nameserver=0.0.0.0 for a subnet isn't treated properly

Bug #1950686 reported by Dr. Jens Harbott on 2021-11-11

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	neutron	Fix Released	Medium	Rodolfo Alonso

Bug Description

As documented in https://docs.openstack.org/neutron/latest/admin/config-dns-res.html#case-1-each-virtual-network-uses-unique-dns-resolver-s , setting dns-nameserver=0.0.0.0 for a subnet should indicate that DHCP should not advertise any DNS server to instances on that subnet. This works fine with LB or OVS, but with OVN, instead the IP 0.0.0.0 is advertised as nameserver to instances.

Tags:

Slawek Kaplonski (slaweq) on 2021-11-12

Changed in neutron:
importance:	Undecided → Medium

Dr. Jens Harbott (j-harbott) on 2021-11-23

tags:

added: dns

Rodolfo Alonso (rodolfo-alonso-hernandez) on 2021-11-26

Changed in neutron:
assignee:	nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-12-07: Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/820858

Changed in neutron:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-12-17: Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/820858
Committed: https://opendev.org/openstack/neutron/commit/a416f8b0ab810f34ea274183df590a73d150a137
Submitter: "Zuul (22348)"
Branch: master

commit a416f8b0ab810f34ea274183df590a73d150a137
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Dec 7 11:42:53 2021 +0000

Do not announce any DNS resolver if "0.0.0.0" or "::" provided

    The DHCP server should not announce any DNS resolver at all on the
    subnet if "0.0.0.0" (IPv4) or "::" (IPv6) are configured as DNS
    name servers in any subnet.

https://docs.openstack.org/neutron/latest/admin/config-dns-res.html

Closes-Bug: #1950686
Change-Id: I78dd012764c7bd7a29aeb8d97c00b627d7723aeb

Changed in neutron:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-12-20: Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/822293

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-12-20: Fix proposed to neutron (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/822296

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-12-20: Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/822297

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-12-20: Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/822325

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-12-21: Fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/822293
Committed: https://opendev.org/openstack/neutron/commit/c73fc94204d432e111e1a7c5ba8b779c5fb0b3b6
Submitter: "Zuul (22348)"
Branch: stable/xena

commit c73fc94204d432e111e1a7c5ba8b779c5fb0b3b6
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Dec 7 11:42:53 2021 +0000

Do not announce any DNS resolver if "0.0.0.0" or "::" provided

    The DHCP server should not announce any DNS resolver at all on the
    subnet if "0.0.0.0" (IPv4) or "::" (IPv6) are configured as DNS
    name servers in any subnet.

https://docs.openstack.org/neutron/latest/admin/config-dns-res.html

    Closes-Bug: #1950686
    Change-Id: I78dd012764c7bd7a29aeb8d97c00b627d7723aeb
    (cherry picked from commit a416f8b0ab810f34ea274183df590a73d150a137)

tags:

added: in-stable-xena

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-12-21: Fix merged to neutron (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/822296
Committed: https://opendev.org/openstack/neutron/commit/625fa3a5b2b1485f8a1be2b2ee75febd00161dae
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 625fa3a5b2b1485f8a1be2b2ee75febd00161dae
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Dec 7 11:42:53 2021 +0000

Do not announce any DNS resolver if "0.0.0.0" or "::" provided

    The DHCP server should not announce any DNS resolver at all on the
    subnet if "0.0.0.0" (IPv4) or "::" (IPv6) are configured as DNS
    name servers in any subnet.

https://docs.openstack.org/neutron/latest/admin/config-dns-res.html

Conflicts:
neutron/common/ovn/utils.py

    Closes-Bug: #1950686
    Change-Id: I78dd012764c7bd7a29aeb8d97c00b627d7723aeb
    (cherry picked from commit a416f8b0ab810f34ea274183df590a73d150a137)

tags:

added: in-stable-victoria

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-12-22: Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/822325
Committed: https://opendev.org/openstack/neutron/commit/173fa98f9e9b4f051fbd458156de3d297236a4e9
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 173fa98f9e9b4f051fbd458156de3d297236a4e9
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Dec 7 11:42:53 2021 +0000

Do not announce any DNS resolver if "0.0.0.0" or "::" provided

    The DHCP server should not announce any DNS resolver at all on the
    subnet if "0.0.0.0" (IPv4) or "::" (IPv6) are configured as DNS
    name servers in any subnet.

https://docs.openstack.org/neutron/latest/admin/config-dns-res.html

    Closes-Bug: #1950686
    Change-Id: I78dd012764c7bd7a29aeb8d97c00b627d7723aeb
    (cherry picked from commit a416f8b0ab810f34ea274183df590a73d150a137)

tags:

added: in-stable-wallaby

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-01-06: Fix merged to neutron (stable/ussuri)

#10

Reviewed: https://review.opendev.org/c/openstack/neutron/+/822297
Committed: https://opendev.org/openstack/neutron/commit/329d25cce31569f4b5faa1472008758adf4f3157
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 329d25cce31569f4b5faa1472008758adf4f3157
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Dec 7 11:42:53 2021 +0000

Do not announce any DNS resolver if "0.0.0.0" or "::" provided

    The DHCP server should not announce any DNS resolver at all on the
    subnet if "0.0.0.0" (IPv4) or "::" (IPv6) are configured as DNS
    name servers in any subnet.

https://docs.openstack.org/neutron/latest/admin/config-dns-res.html

    Conflicts:
        neutron/common/ovn/utils.py
        neutron/tests/unit/common/ovn/test_utils.py

    Closes-Bug: #1950686
    Change-Id: I78dd012764c7bd7a29aeb8d97c00b627d7723aeb
    (cherry picked from commit a416f8b0ab810f34ea274183df590a73d150a137)
    (cherry picked from commit 625fa3a5b2b1485f8a1be2b2ee75febd00161dae)