[RFE] GW IP and FIP QoS to inherit from network

[Rodolfo Alonso]

This RFE proposes to add the ability fro FIPs and GW IPs to inherit the QoS policy from the network they are located, same as with port QoS.

This RFE implies changes in:
- The FIP object, to add the network QoS policy of the (external) network that is located.
- A change in the CLI (SDK and OSC) to include the network QoS in the resources views.
- A change in the L3 QoS extension (OVS and OVN, the only backends implementing L3 QoS) to read the network inherited QoS from the FIP or the GW IP port.

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2012877

[LIU Yulong (dragon889)]

+1, make sense, this will be a defaut qos limit for those floating IPs.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/817734

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Hello:

An update from what I commented in the drivers meeting. Those are the steps to implement this feature:
1) Add network QoS policy ID to the FIP OVO
2) [OVN] Implement FIP QoS inheritance
3) [OVS] Implement FIP QoS inheritance
4) [OVS] Implement GW QoS inheritance
5) Add SDK and OSC code to FIP "show" command.
6) Add reno and check for external networks QoS. Emit a warning in case of having external networks with QoS policies, because now FIPs and GW IPs will inherit from those QoS policies.

Regards.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/817790

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron-lib/+/817936

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/818399

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron-lib/+/818536

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/819147

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron-lib/+/817936
Committed: https://opendev.org/openstack/neutron-lib/commit/f9497acdb2181b4d0c22f6c6d42861d564f355dd
Submitter: "Zuul (22348)"
Branch: master

commit f9497acdb2181b4d0c22f6c6d42861d564f355dd
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Nov 15 11:17:28 2021 +0000

    Add floating IP network QoS field to floating IP definition

    Related-Bug: #1950454

    Change-Id: Ib83a375a03111316c1351a2afb622e201a603b5c

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/820125

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron-vpnaas/+/820126

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron-vpnaas/+/820126
Committed: https://opendev.org/openstack/neutron-vpnaas/commit/883f4f26100f751f50543d363a8a2633f43d62aa
Submitter: "Zuul (22348)"
Branch: master

commit 883f4f26100f751f50543d363a8a2633f43d62aa
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Dec 2 09:55:06 2021 +0000

    Add "update_network" implementation to "L3AgentExtension" child classes

    Added "update_network" method implementation to all "L3AgentExtension"
    child classes. This new method will be added as a new abstract method
    in future neutron-lib releases.

    Needed-By: https://review.opendev.org/c/openstack/neutron-lib/+/818536
    Related-Bug: #1950454
    Change-Id: If319a47e65e4052dd3bbfba700819cbb9183a263

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/817734
Committed: https://opendev.org/openstack/neutron/commit/42cfa055c278b1daa2c486a277e71c674836fb51
Submitter: "Zuul (22348)"
Branch: master

commit 42cfa055c278b1daa2c486a277e71c674836fb51
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Nov 11 17:04:16 2021 +0000

    Add network QoS inheritance to floating IP

    Added information of the floating IP network QoS policy to the
    ``FloatingIP`` OVO. The view-only parameter added allows to check
    the network QoS policy in the floating IP object.

    This patch does not implement any change in the L3 code (OVS or
    OVN). This patch does not change any existing behaviour.

    NOTE: bump neutron-lib version

    Depends-On: https://review.opendev.org/c/openstack/neutron-lib/+/817936

    Partial-Bug: #1950454
    Change-Id: I9d7bb54b14fb983161fdf51c96b6fda107db4fe6

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/820125
Committed: https://opendev.org/openstack/neutron/commit/b1ecde9122b34b52e1976b3bce22b81dc5b282d5
Submitter: "Zuul (22348)"
Branch: master

commit b1ecde9122b34b52e1976b3bce22b81dc5b282d5
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Dec 2 09:42:09 2021 +0000

    Add "update_network" implementation to "L3AgentExtension" child classes

    Added "update_network" method implementation to all "L3AgentExtension"
    child classes. This new method will be added as a new abstract method
    in future neutron-lib releases.

    Needed-By: https://review.opendev.org/c/openstack/neutron-lib/+/818536
    Related-Bug: #1950454
    Change-Id: Ib50d37d57c3d6a69a68876ae04f468325516d4eb

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron-lib/+/818536
Committed: https://opendev.org/openstack/neutron-lib/commit/4807bacab4ad6320cbd6b3c2c164bad78f5f42d5
Submitter: "Zuul (22348)"
Branch: master

commit 4807bacab4ad6320cbd6b3c2c164bad78f5f42d5
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri Nov 19 11:14:53 2021 +0000

    Add new method "update_network" to "L3AgentExtension".

    This new method will extend the L3 agent extensions functionality,
    making them aware of any network change.

    Change-Id: I7184c058ea59a1dceefda7ce4488df4d64c71111
    Related-Bug: #1950454

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/818399
Committed: https://opendev.org/openstack/neutron/commit/d7178927fdea70c2200ec409b4c3a94a8819a029
Submitter: "Zuul (22348)"
Branch: master

commit d7178927fdea70c2200ec409b4c3a94a8819a029
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Nov 18 14:27:06 2021 +0000

    Add upgrade check for floating IP QoS inheritance from network

    This new upgrade check will inform to the user what external networks
    have at least one floating IP address and a bound QoS policy. That
    could affect to the L3 QoS applied on the floating IP.

    Partial-Bug: #1950454
    Change-Id: I751b8baeda00ce890722d96199b19a91818b2ca0

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/817790
Committed: https://opendev.org/openstack/neutron/commit/8dfe5cc95ba8d27ff59f710a34418d46a0d25144
Submitter: "Zuul (22348)"
Branch: master

commit 8dfe5cc95ba8d27ff59f710a34418d46a0d25144
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri Nov 12 14:31:58 2021 +0000

    [OVN] Implement floating IP network QoS inheritance

    Floating IP now have information of the QoS policy of the external
    network. The OVN QoS extension will use this network QoS policy if
    there is no floating IP QoS policy.

    Partial-Bug: #1950454
    Change-Id: I380a130d97e8bfe54caa5f3a129877507d1ce2a6

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/834855

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/834855
Committed: https://opendev.org/openstack/neutron/commit/7c2420e3af0de597932873c433070630ca005dc5
Submitter: "Zuul (22348)"
Branch: master

commit 7c2420e3af0de597932873c433070630ca005dc5
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Mar 17 07:43:52 2022 +0000

    Add "qos_policy_id" field to "Router" OVO

    This new synthetic field is linked to a
    "QosRouterGatewayIPPolicyBinding" register. This binding register will
    bind a QoS policy and a Router. Now is possible to provide this field
    in the create/update input parameters. If provided, the "Router" OVO will
    create/delete the "QosRouterGatewayIPPolicyBinding" register.

    The "Router" OVO takes this parameter from the DB object. When the DB
    object is retrieved, the QoS policy binding register is retrieved too
    due to a backref link in the "QosRouterGatewayIPPolicyBinding" DB model to
    the "Router" DB model.

    Related-Bug: #1893625
    Related-Bug: #1950454

    Change-Id: I59ed68b2c1e19f1f31e72b4868e3db750ef06d6f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/838678

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/838678
Committed: https://opendev.org/openstack/neutron/commit/15b826a05f84d9ed13e61ae288d5ad106dcf418c
Submitter: "Zuul (22348)"
Branch: master

commit 15b826a05f84d9ed13e61ae288d5ad106dcf418c
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri Nov 19 12:08:11 2021 +0000

    [OVN] Implement GW IP network QoS inheritance

    This patch enables the gateway IP network QoS inheritance in
    the OVN backend driver. The OVN QoS extension will use the
    router external network (GW network) QoS policy if the gateway
    IP port has no QoS policy assigned.

    Partial-Bug: #1950454

    Change-Id: I5ee51dc124ae464b9e9fd366cf7bf85176376c25

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Slawek Kaplonski <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/819147
Reason: This review is > 4 weeks without comment, and failed Zuul jobs the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.