direct-physical port creation fails with QoS minimum bandwidth rule

[Balazs Gibizer]

Today the sriov qos service plugin blindly blocks creating ports
with minimum bandwidth qos and with direct_physical vnic_type. This was
originally added when only dataplane enforcement was the scope of the
qos service plugin. However in the last many releases we created
placement enforcement for this qos rule regardless of the vnic_type.
So now blindly blocking the port creation is now preventing using the
placement enforcement for this rule for direct_physical ports.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/815962
Committed: https://opendev.org/openstack/neutron/commit/abfbe5d54d9d3992638efbb49d5a4145fe99ff7a
Submitter: "Zuul (22348)"
Branch: master

commit abfbe5d54d9d3992638efbb49d5a4145fe99ff7a
Author: Balazs Gibizer <email address hidden>
Date: Fri Oct 29 15:32:13 2021 +0200

    Do not block qos for direct-physical ports

    Today the sriov qos service plugin blindly blocks creating ports
    with minimum bandwidth qos and with direct_physical vnic_type. This was
    originally added when only dataplane enforcement was the scope of the
    qos service plugin. However in the last many releases we created
    placement enforcement for this qos rule regardless of the vnic_type.
    So now blindly blocking the port creation is now preventing using the
    placement enforcement for this rule for direct_physical ports.

    This patch removes this limitation by marking minimum bandwidth as
    supported rule for the sriov qos service plugin. The limitation that
    data plane enforcement is not supported for this rule remains. The agent
    will not even try to apply any kind of rules to these ports as port
    binding is not forwarded for the sriov agent at all.

    The documentation is extended to explain that placement enforcement now
    works while data plane enforcement still not supported.

    This is somewhat similar to the case when the support for egress
    direction is added to the minimum bandwidth rule, while the sriov data
    plane enforcement was not (could not) been implemented for this
    direction in the sriov agent. Today the sriov agent simply ignores the
    egress direction rules in the minimum bandwidth qos rule during applying
    the data plane enforcement.

    Closes-Bug: #1949877

    Change-Id: I20ad32eac414ff90b551bff940d92cbcfa848101

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 20.0.0.0rc1 release candidate.