FIP ports count into quota as they get a project_id set

[Johannes Kulik]

With https://github.com/openstack/neutron/commit/d0c172afa6ea38e94563afb4994471420b27cddf Neutron started adding a "project_id" to a FIPs external port, even though https://github.com/openstack/neutron/blob/f97baa0b16687453735e46e7a0f73fe03d7d4db7/neutron/db/l3_db.py#L326 states, that this is "intentionally not set".

This makes the ports viewable by the customer in "openstack port list" and lets the ports count into quota, which was not the case pre-train.

Is this change intentional?

[Sebastian Lohff (sebageek)]

FIP ports generally didn't to have a project_id and this is still the case for other ports that should not be managed by the user, but only by OpenStack. Router gateway interfaces for examples also don't have a project id.

The change doesn't feel intentional to me, but if it is, then it should be corrected for other ports of this as well.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/816722

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/816722
Committed: https://opendev.org/openstack/neutron/commit/d9f31f5047f7de8a74b169770e2342136234b344
Submitter: "Zuul (22348)"
Branch: master

commit d9f31f5047f7de8a74b169770e2342136234b344
Author: Sebastian Lohff <email address hidden>
Date: Thu Nov 4 15:56:37 2021 +0100

    Do not set project_id for floating ip ports

    Floating IP ports should not have a project_id assigned to them as they
    are not managed by the owner of a project, but by OpenStack itself. With
    a project_id assigned they also count towards the port quota of said
    project, which they should not. Therefore, we do not set a project_id
    anymore on Floating IP creation for the Floating IP port. This is in
    line with the behaviour we currently have for gateway interfaces of
    routers.

    Change-Id: I053d48166141e5cdbd39a1235a43b06d64478bc1
    Closes-Bug: #1949767

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 20.0.0.0rc1 release candidate.