[OVN] check_for_mcast_flood_reports maintenance task not accounting for localnet "mcast_flood" changes

Bug #1949081 reported by Lucas Alvares Gomes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Lucas Alvares Gomes

Bug Description

The patch [0] changed the value of the "mcast_flood" option for the localnet ports in OVN to "false" to avoid multicast packet duplication but, the maintenance task check_for_mcast_flood_reports was never updated to account for that change.

Current the maintenance task only checks if the mcast_flood option is set and if so it moves on to the next port. This means that localnet ports created prior to [1] will continue to have the mcast_flood value as "true".

We need to update check_for_mcast_flood_reports to change the value of mcast_flood to "false" for the localnet ports in case they are unset or set to "true")

[1] https://review.opendev.org/c/openstack/neutron/+/797418

Changed in neutron:
status: New → Confirmed
importance: Undecided → Medium
Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/815843
Committed: https://opendev.org/openstack/neutron/commit/d02fb560aa35c4931d40000e8ca4c0e4105299b7
Submitter: "Zuul (22348)"
Branch: master

commit d02fb560aa35c4931d40000e8ca4c0e4105299b7
Author: Lucas Alvares Gomes <email address hidden>
Date: Thu Oct 28 14:17:20 2021 +0100

    [OVN] Update check_for_mcast_flood_reports() to check for mcast_flood

    The patch [0] changed the value of the "mcast_flood" option for the
    localnet ports in OVN to "false" to avoid multicast packet duplication
    but, the maintenance task check_for_mcast_flood_reports() was never
    updated to account for that change.

    So, localnet ports created prior to [0] would continue to have the
    "mcast_flood" value as "true" and new ports would have it as "false".
    This patch fixes the maintenance task.

    [0] https://review.opendev.org/c/openstack/neutron/+/797418

    Change-Id: Ib90704a85c9ed659d71ac8ed42b1b542bd2496a2
    Closes-Bug: #1949081
    Signed-off-by: Lucas Alvares Gomes <email address hidden>

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/823564

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/823565

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/823566

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/823567

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/823564
Committed: https://opendev.org/openstack/neutron/commit/09f713d5d50307eeead575d377fdb38711691045
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 09f713d5d50307eeead575d377fdb38711691045
Author: Lucas Alvares Gomes <email address hidden>
Date: Thu Oct 28 14:17:20 2021 +0100

    [OVN] Update check_for_mcast_flood_reports() to check for mcast_flood

    The patch [0] changed the value of the "mcast_flood" option for the
    localnet ports in OVN to "false" to avoid multicast packet duplication
    but, the maintenance task check_for_mcast_flood_reports() was never
    updated to account for that change.

    So, localnet ports created prior to [0] would continue to have the
    "mcast_flood" value as "true" and new ports would have it as "false".
    This patch fixes the maintenance task.

    [0] https://review.opendev.org/c/openstack/neutron/+/797418

    Change-Id: Ib90704a85c9ed659d71ac8ed42b1b542bd2496a2
    Closes-Bug: #1949081
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit d02fb560aa35c4931d40000e8ca4c0e4105299b7)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/823566
Committed: https://opendev.org/openstack/neutron/commit/c986caa2997c7221a7a4adf96beda6d06763f150
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit c986caa2997c7221a7a4adf96beda6d06763f150
Author: Lucas Alvares Gomes <email address hidden>
Date: Thu Oct 28 14:17:20 2021 +0100

    [OVN] Update check_for_mcast_flood_reports() to check for mcast_flood

    The patch [0] changed the value of the "mcast_flood" option for the
    localnet ports in OVN to "false" to avoid multicast packet duplication
    but, the maintenance task check_for_mcast_flood_reports() was never
    updated to account for that change.

    So, localnet ports created prior to [0] would continue to have the
    "mcast_flood" value as "true" and new ports would have it as "false".
    This patch fixes the maintenance task.

    [0] https://review.opendev.org/c/openstack/neutron/+/797418

    Change-Id: Ib90704a85c9ed659d71ac8ed42b1b542bd2496a2
    Closes-Bug: #1949081
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit d02fb560aa35c4931d40000e8ca4c0e4105299b7)

tags: added: in-stable-victoria
tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/823565
Committed: https://opendev.org/openstack/neutron/commit/3113930ac76f33afc3b6becab2081419a6a1bf22
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 3113930ac76f33afc3b6becab2081419a6a1bf22
Author: Lucas Alvares Gomes <email address hidden>
Date: Thu Oct 28 14:17:20 2021 +0100

    [OVN] Update check_for_mcast_flood_reports() to check for mcast_flood

    The patch [0] changed the value of the "mcast_flood" option for the
    localnet ports in OVN to "false" to avoid multicast packet duplication
    but, the maintenance task check_for_mcast_flood_reports() was never
    updated to account for that change.

    So, localnet ports created prior to [0] would continue to have the
    "mcast_flood" value as "true" and new ports would have it as "false".
    This patch fixes the maintenance task.

    [0] https://review.opendev.org/c/openstack/neutron/+/797418

    Change-Id: Ib90704a85c9ed659d71ac8ed42b1b542bd2496a2
    Closes-Bug: #1949081
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit d02fb560aa35c4931d40000e8ca4c0e4105299b7)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/823567
Committed: https://opendev.org/openstack/neutron/commit/30e4bfbeaf9f3cd750dd1194845d76e9366ebe79
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 30e4bfbeaf9f3cd750dd1194845d76e9366ebe79
Author: Lucas Alvares Gomes <email address hidden>
Date: Thu Oct 28 14:17:20 2021 +0100

    [OVN] Update check_for_mcast_flood_reports() to check for mcast_flood

    The patch [0] changed the value of the "mcast_flood" option for the
    localnet ports in OVN to "false" to avoid multicast packet duplication
    but, the maintenance task check_for_mcast_flood_reports() was never
    updated to account for that change.

    So, localnet ports created prior to [0] would continue to have the
    "mcast_flood" value as "true" and new ports would have it as "false".
    This patch fixes the maintenance task.

    [0] https://review.opendev.org/c/openstack/neutron/+/797418

    Change-Id: Ib90704a85c9ed659d71ac8ed42b1b542bd2496a2
    Closes-Bug: #1949081
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit d02fb560aa35c4931d40000e8ca4c0e4105299b7)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 17.3.0

This issue was fixed in the openstack/neutron 17.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 18.2.0

This issue was fixed in the openstack/neutron 18.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 20.0.0.0rc1

This issue was fixed in the openstack/neutron 20.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 19.2.0

This issue was fixed in the openstack/neutron 19.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-ovn train-eol

This issue was fixed in the openstack/networking-ovn train-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron ussuri-eol

This issue was fixed in the openstack/neutron ussuri-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.