[OVN] Mech driver fails to delete DHCP options during subnet deletion

Bug #1948466 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Rodolfo Alonso

Bug Description

Snippet: https://paste.opendev.org/show/810168/

I can't provide a link to a CI execution, I saw this error in an internal CI. I'm still investigating when this could happen.

Changed in neutron:
status: New → Incomplete
Revision history for this message
Jakub Libosvar (libosvar) wrote :

Is there any impact other than stale data in the DB? I would assume if subnet is deleted and new created, it's gonna have a different ID and will not cause any issues.

Changed in neutron:
importance: Undecided → Low
tags: added: ovn
Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :

Hello Jakub:

If the driver call raises an exception, it will never end correctly, including

Changed in neutron:
status: Incomplete → New
Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :

(sorry, I submitted an unfinished comment and I can't modify it)

Hello Jakub:

If the driver call raises an exception, it will never end correctly, including the version bump. This happens when the subnet has no DHCP options. In any case, this must be considered and properly handled.

Regards.

Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/815280

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/815280
Committed: https://opendev.org/openstack/neutron/commit/95c2801da855cada741693b0dc31192e7baa111c
Submitter: "Zuul (22348)"
Branch: master

commit 95c2801da855cada741693b0dc31192e7baa111c
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Oct 25 11:12:14 2021 +0000

    Check subnet in "_remove_subnet_dhcp_options"

    Since [1], "get_subnet_dhcp_options" returns always a dictionary
    in "subnet" instead of None. This patch checks not only that "subnet"
    is None but also the dictionary is not empty.

    [1]https://review.opendev.org/c/openstack/neutron/+/807692

    Closes-Bug: #1948466

    Change-Id: Ie93cf3e47e09b3e5051be1ffad512251775b0492

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/822798

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/822799

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/822800

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/822801

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/822800
Committed: https://opendev.org/openstack/neutron/commit/79cdace512307c9b0c92f56af9abc656371a6f31
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 79cdace512307c9b0c92f56af9abc656371a6f31
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Oct 25 11:12:14 2021 +0000

    Check subnet in "_remove_subnet_dhcp_options"

    Since [1], "get_subnet_dhcp_options" returns always a dictionary
    in "subnet" instead of None. This patch checks not only that "subnet"
    is None but also the dictionary is not empty.

    [1]https://review.opendev.org/c/openstack/neutron/+/807692

    Closes-Bug: #1948466

    Change-Id: Ie93cf3e47e09b3e5051be1ffad512251775b0492
    (cherry picked from commit 95c2801da855cada741693b0dc31192e7baa111c)

tags: added: in-stable-victoria
tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/822801
Committed: https://opendev.org/openstack/neutron/commit/9151f4a3966e7416b8449945e9b4735dd92b2a60
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 9151f4a3966e7416b8449945e9b4735dd92b2a60
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Oct 25 11:12:14 2021 +0000

    Check subnet in "_remove_subnet_dhcp_options"

    Since [1], "get_subnet_dhcp_options" returns always a dictionary
    in "subnet" instead of None. This patch checks not only that "subnet"
    is None but also the dictionary is not empty.

    [1]https://review.opendev.org/c/openstack/neutron/+/807692

    Closes-Bug: #1948466

    Change-Id: Ie93cf3e47e09b3e5051be1ffad512251775b0492
    (cherry picked from commit 95c2801da855cada741693b0dc31192e7baa111c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/822798
Committed: https://opendev.org/openstack/neutron/commit/3e9dcaee50ec69fb6e71a59de4ad936e297f5a4f
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 3e9dcaee50ec69fb6e71a59de4ad936e297f5a4f
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Oct 25 11:12:14 2021 +0000

    Check subnet in "_remove_subnet_dhcp_options"

    Since [1], "get_subnet_dhcp_options" returns always a dictionary
    in "subnet" instead of None. This patch checks not only that "subnet"
    is None but also the dictionary is not empty.

    [1]https://review.opendev.org/c/openstack/neutron/+/807692

    Closes-Bug: #1948466

    Change-Id: Ie93cf3e47e09b3e5051be1ffad512251775b0492
    (cherry picked from commit 95c2801da855cada741693b0dc31192e7baa111c)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/822799
Committed: https://opendev.org/openstack/neutron/commit/1aba78896b6daa2a786a4445c9ea6eb46d8aa145
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 1aba78896b6daa2a786a4445c9ea6eb46d8aa145
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Oct 25 11:12:14 2021 +0000

    Check subnet in "_remove_subnet_dhcp_options"

    Since [1], "get_subnet_dhcp_options" returns always a dictionary
    in "subnet" instead of None. This patch checks not only that "subnet"
    is None but also the dictionary is not empty.

    [1]https://review.opendev.org/c/openstack/neutron/+/807692

    Closes-Bug: #1948466

    Change-Id: Ie93cf3e47e09b3e5051be1ffad512251775b0492
    (cherry picked from commit 95c2801da855cada741693b0dc31192e7baa111c)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 19.1.0

This issue was fixed in the openstack/neutron 19.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 17.3.0

This issue was fixed in the openstack/neutron 17.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 18.2.0

This issue was fixed in the openstack/neutron 18.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 20.0.0.0rc1

This issue was fixed in the openstack/neutron 20.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers