[OVN] VIF details "connectivity" parameter is not correctly populated

Bug #1947378 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Rodolfo Alonso

Bug Description

In OVN mech driver, VIF details "connectivity" parameter is not populated into the port bindings register when bound.

Patch [1] incorrectly added this information in the mech driver "vif_details" member, instead of adding it in each VIF type ("vhostuser", "ovs).

[1]https://review.opendev.org/c/openstack/networking-ovn/+/678599

Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/814143

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/814143
Committed: https://opendev.org/openstack/neutron/commit/b871dabdf433d2393551de6597d43774ed6cf1e4
Submitter: "Zuul (22348)"
Branch: master

commit b871dabdf433d2393551de6597d43774ed6cf1e4
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri Oct 15 13:18:00 2021 +0000

    [OVN] Add the VIF details "connectivity" parameter

    In [1], the parameter was included in the mech driver "vif_details"
    member, instead of adding it in each defined VIF type, "ovs" and
    "vhostuser".

    [1]https://review.opendev.org/c/openstack/networking-ovn/+/678599

    Closes-Bug: #1947378

    Change-Id: Ie9676fb2869cbf5b5cba9a7b27f2bfbbe0eab458

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/826438

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/826439

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/826440

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/826441

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/826438
Committed: https://opendev.org/openstack/neutron/commit/6be2df7eb5969e0b5440ccd53a1fe19029870fe7
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 6be2df7eb5969e0b5440ccd53a1fe19029870fe7
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri Oct 15 13:18:00 2021 +0000

    [OVN] Add the VIF details "connectivity" parameter

    In [1], the parameter was included in the mech driver "vif_details"
    member, instead of adding it in each defined VIF type, "ovs" and
    "vhostuser".

    [1]https://review.opendev.org/c/openstack/networking-ovn/+/678599

    NOTE: this patch differs from the master one (in "Y" release) due
    to LP#1959125. Because the fix for this bug implies a change in
    neutron-lib, this patch addresses the issue by leaving the
    connectivity parameter in the OVN mech driver "vif_details"
    dictionary, thus "_check_drivers_connectivity" can properly
    check it.

    Conflicts:
      neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py

    Closes-Bug: #1947378

    Change-Id: Ie9676fb2869cbf5b5cba9a7b27f2bfbbe0eab458
    (cherry picked from commit b871dabdf433d2393551de6597d43774ed6cf1e4)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/826439
Committed: https://opendev.org/openstack/neutron/commit/a30fd26b3f08a11d861f21f7d0ab0b917648638c
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit a30fd26b3f08a11d861f21f7d0ab0b917648638c
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri Oct 15 13:18:00 2021 +0000

    [OVN] Add the VIF details "connectivity" parameter

    In [1], the parameter was included in the mech driver "vif_details"
    member, instead of adding it in each defined VIF type, "ovs" and
    "vhostuser".

    [1]https://review.opendev.org/c/openstack/networking-ovn/+/678599

    NOTE: this patch differs from the master one (in "Y" release) due
    to LP#1959125. Because the fix for this bug implies a change in
    neutron-lib, this patch addresses the issue by leaving the
    connectivity parameter in the OVN mech driver "vif_details"
    dictionary, thus "_check_drivers_connectivity" can properly
    check it.

    Conflicts:
      neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py

    Closes-Bug: #1947378

    Change-Id: Ie9676fb2869cbf5b5cba9a7b27f2bfbbe0eab458
    (cherry picked from commit b871dabdf433d2393551de6597d43774ed6cf1e4)
    (cherry picked from commit 6be2df7eb5969e0b5440ccd53a1fe19029870fe7)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/826440
Committed: https://opendev.org/openstack/neutron/commit/dacd5276b7c359baea4f4933ce99798b02a2cdea
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit dacd5276b7c359baea4f4933ce99798b02a2cdea
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri Oct 15 13:18:00 2021 +0000

    [OVN] Add the VIF details "connectivity" parameter

    In [1], the parameter was included in the mech driver "vif_details"
    member, instead of adding it in each defined VIF type, "ovs" and
    "vhostuser".

    [1]https://review.opendev.org/c/openstack/networking-ovn/+/678599

    NOTE: this patch differs from the master one (in "Y" release) due
    to LP#1959125. Because the fix for this bug implies a change in
    neutron-lib, this patch addresses the issue by leaving the
    connectivity parameter in the OVN mech driver "vif_details"
    dictionary, thus "_check_drivers_connectivity" can properly
    check it.

    Conflicts:
      neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py

    Closes-Bug: #1947378

    Change-Id: Ie9676fb2869cbf5b5cba9a7b27f2bfbbe0eab458
    (cherry picked from commit b871dabdf433d2393551de6597d43774ed6cf1e4)
    (cherry picked from commit 6be2df7eb5969e0b5440ccd53a1fe19029870fe7)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/826441
Committed: https://opendev.org/openstack/neutron/commit/c5f7694b0debf9f48e95d798d3f0006be8da246a
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit c5f7694b0debf9f48e95d798d3f0006be8da246a
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri Oct 15 13:18:00 2021 +0000

    [OVN] Add the VIF details "connectivity" parameter

    In [1], the parameter was included in the mech driver "vif_details"
    member, instead of adding it in each defined VIF type, "ovs" and
    "vhostuser".

    [1]https://review.opendev.org/c/openstack/networking-ovn/+/678599

    NOTE: this patch differs from the master one (in "Y" release) due
    to LP#1959125. Because the fix for this bug implies a change in
    neutron-lib, this patch addresses the issue by leaving the
    connectivity parameter in the OVN mech driver "vif_details"
    dictionary, thus "_check_drivers_connectivity" can properly
    check it.

    Conflicts:
      neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py

    Closes-Bug: #1947378

    Change-Id: Ie9676fb2869cbf5b5cba9a7b27f2bfbbe0eab458
    (cherry picked from commit b871dabdf433d2393551de6597d43774ed6cf1e4)
    (cherry picked from commit 6be2df7eb5969e0b5440ccd53a1fe19029870fe7)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 20.0.0.0rc1

This issue was fixed in the openstack/neutron 20.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 17.4.0

This issue was fixed in the openstack/neutron 17.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 18.3.0

This issue was fixed in the openstack/neutron 18.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 19.2.0

This issue was fixed in the openstack/neutron 19.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron ussuri-eol

This issue was fixed in the openstack/neutron ussuri-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.