[OVN] Migration to OVN does not create the OVN QoS DB registers

Bug #1947334 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Rodolfo Alonso

Bug Description

After the OVN migration, the information about QoS in the neutron DB is correct:
(overcloud) [stack@undercloud-0 ~]$ openstack network show 569b37f1-3dd4-402e-9244-d7fad1ec4804 -c qos_policy_id -f value
85d22adf-fc02-4c6d-b17a-36183d206558
(overcloud) [stack@undercloud-0 ~]$ openstack network qos policy show 85d22adf-fc02-4c6d-b17a-36183d206558 -c rules -f value
[{'max_kbps': 1000, 'max_burst_kbps': 800, 'direction': 'egress', 'id': 'fd1fffa5-b3ae-4b24-ba81-dfce2cccbe17', 'qos_policy_id': '85d22adf-fc02-4c6d-b17a-36183d206558', 'type': 'bandwidth_limit'}, {'dscp_mark': 40, 'id': '49e3e48b-b9e1-4332-9756-603134ee25fa', 'qos_policy_id': '85d22adf-fc02-4c6d-b17a-36183d206558', 'type': 'dscp_marking'}]

Wowever there is no QoS information in the OVN NBDB:
[root@controller-0 ~]# ovn-nbctl find logical_switch name=neutron-569b37f1-3dd4-402e-9244-d7fad1ec4804
_uuid : 10c127dd-639b-455d-94e9-7de881abef9e
acls : []
dns_records : [8c29e850-26bd-4be9-8fe5-e87e84912ef9]
external_ids : {"neutron:mtu"="1442", "neutron:network_name"=tobiko.openstack.stacks._qos.QosNetworkStackFixture-network-76zr72iw3bn5, "neutron:revision_number"="6"}
forwarding_groups : []
load_balancer : []
name : neutron-569b37f1-3dd4-402e-9244-d7fad1ec4804
other_config : {mcast_flood_unregistered="false", mcast_snoop="true", vlan-passthru="false"}
ports : [031d8606-2855-4404-89a8-539ec6bf31a7, 144619e6-8ec6-43d5-8e26-f0d0fab2676f, 488e8f77-64b0-40b5-82e8-dc3d79eab851, 4c3a538f-69cf-4241-ab9b-bb1c56e7f513, 6205219c-1593-42b2-a28c-bc856d6978b2, 8a518aac-ab99-486b-9ddc-4b82accb9cfd, 8fe8118c-cf6e-40cc-89bf-4b831f5ba770, a3ff89e4-4f5f-420d-8f86-6890d5f8e157, a8eef773-b7d1-411e-8308-c6434bc5b92d]
qos_rules : []

[root@controller-0 ~]# ovn-nbctl list qos
# the output is empty

Bugzilla reference: https://bugzilla.redhat.com/show_bug.cgi?id=2010672

Changed in neutron:
importance: Undecided → Medium
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
Changed in neutron:
status: New → In Progress
Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/822729

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/822729
Committed: https://opendev.org/openstack/neutron/commit/ce7f2795384e05b7e086bdab41226a69708dfdc5
Submitter: "Zuul (22348)"
Branch: master

commit ce7f2795384e05b7e086bdab41226a69708dfdc5
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Dec 21 09:32:36 2021 +0000

    [OVN][QoS] Add external_ids reference to port QoS registers

    Same as with floating IP QoS OVN registers, port QoSes should have a
    "external_ids" reference to the port ID this QoS is attached to.

    Related-Bug: #1947334
    Change-Id: If14ccff79f77618133cce4bf95e3f1eea7ba8cf3

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/813052
Committed: https://opendev.org/openstack/neutron/commit/cde5657a504f6658cb1c9c98235c120030f86130
Submitter: "Zuul (22348)"
Branch: master

commit cde5657a504f6658cb1c9c98235c120030f86130
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Oct 7 16:20:21 2021 +0000

    [OVN] Sync QoS policies

    The tool "neutron-ovn-db-sync-util" now syncs the Neutron QoS policies
    with the OVN NB database. The tools reads the port and the floaiting IP
    QoS policies and creates the corresponding OVN QoS rules.

    The ovsdbapp library is bumped to version 1.15.0. This version updates
    the "QoSAddCommand" to allow register updates. If the OVN NB QoS
    register to be created is present in the DB and all parameters match,
    no transaction is commited to the DB.

    Depends-On: https://review.opendev.org/c/openstack/ovsdbapp/+/822138
    Closes-Bug: #1947334

    Change-Id: Ib597b62017b56b41009dd4d7359e169f424272b0

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 20.0.0.0rc1

This issue was fixed in the openstack/neutron 20.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (stable/xena)

Related fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/846027

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (stable/wallaby)

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/846028

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/846031

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/846032

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/846027
Committed: https://opendev.org/openstack/neutron/commit/92e8a6a37863d8e0f9bbc8ea96a6440b922c7bf5
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 92e8a6a37863d8e0f9bbc8ea96a6440b922c7bf5
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Dec 21 09:32:36 2021 +0000

    [OVN][QoS] Add external_ids reference to port QoS registers

    Same as with floating IP QoS OVN registers, port QoSes should have a
    "external_ids" reference to the port ID this QoS is attached to.

    Related-Bug: #1947334

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_maintenance.py

    Change-Id: If14ccff79f77618133cce4bf95e3f1eea7ba8cf3
    (cherry picked from commit ce7f2795384e05b7e086bdab41226a69708dfdc5)

tags: added: in-stable-xena
tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/846028
Committed: https://opendev.org/openstack/neutron/commit/3090ed0cdfecec22e6c2d57af42dad261864457c
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 3090ed0cdfecec22e6c2d57af42dad261864457c
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Dec 21 09:32:36 2021 +0000

    [OVN][QoS] Add external_ids reference to port QoS registers

    Same as with floating IP QoS OVN registers, port QoSes should have a
    "external_ids" reference to the port ID this QoS is attached to.

    Related-Bug: #1947334

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_maintenance.py

    Change-Id: If14ccff79f77618133cce4bf95e3f1eea7ba8cf3
    (cherry picked from commit ce7f2795384e05b7e086bdab41226a69708dfdc5)
    (cherry picked from commit 92e8a6a37863d8e0f9bbc8ea96a6440b922c7bf5)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/846032
Committed: https://opendev.org/openstack/neutron/commit/0e9c6539b37384d60efd79ae60de36ea56043cf5
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 0e9c6539b37384d60efd79ae60de36ea56043cf5
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Oct 7 16:20:21 2021 +0000

    [OVN] Sync QoS policies

    The tool "neutron-ovn-db-sync-util" now syncs the Neutron QoS policies
    with the OVN NB database. The tools reads the port and the floaiting IP
    QoS policies and creates the corresponding OVN QoS rules.

    The ovsdbapp library is bumped to version 1.15.0. This version updates
    the "QoSAddCommand" to allow register updates. If the OVN NB QoS
    register to be created is present in the DB and all parameters match,
    no transaction is commited to the DB.

    Depends-On: https://review.opendev.org/c/openstack/ovsdbapp/+/822138
    Closes-Bug: #1947334

    Conflicts:
        lower-constraints.txt
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/extensions/qos.py
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_db_sync.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/extensions/test_qos.py
        requirements.txt

    Change-Id: Ib597b62017b56b41009dd4d7359e169f424272b0
    (cherry picked from commit cde5657a504f6658cb1c9c98235c120030f86130)
    (cherry picked from commit a51f243016c884bf9a8ed3fc4792a5227b750ed6)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/846031
Committed: https://opendev.org/openstack/neutron/commit/429fbae1d0e835f7282040f59a71c2fcb9fa7a7d
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 429fbae1d0e835f7282040f59a71c2fcb9fa7a7d
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Oct 7 16:20:21 2021 +0000

    [OVN] Sync QoS policies

    The tool "neutron-ovn-db-sync-util" now syncs the Neutron QoS policies
    with the OVN NB database. The tools reads the port and the floaiting IP
    QoS policies and creates the corresponding OVN QoS rules.

    The ovsdbapp library is bumped to version 1.15.0. This version updates
    the "QoSAddCommand" to allow register updates. If the OVN NB QoS
    register to be created is present in the DB and all parameters match,
    no transaction is commited to the DB.

    Depends-On: https://review.opendev.org/c/openstack/ovsdbapp/+/822138
    Closes-Bug: #1947334

    Conflicts:
        lower-constraints.txt
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/extensions/qos.py
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_db_sync.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/extensions/test_qos.py
        requirements.txt

    Change-Id: Ib597b62017b56b41009dd4d7359e169f424272b0
    (cherry picked from commit cde5657a504f6658cb1c9c98235c120030f86130)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 18.5.0

This issue was fixed in the openstack/neutron 18.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 19.5.0

This issue was fixed in the openstack/neutron 19.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.