OVN does not update the network segment tag

Bug #1944708 reported by Lucas Alvares Gomes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Lucas Alvares Gomes

Bug Description

OVN does not update the network segment tag. For example:

$ stack@central:~/devstack$ openstack network set --provider-segment 123 public
$ stack@central:~/devstack$ sudo ovn-nbctl show
switch 85cb0ec1-c0af-4356-9069-9b8b49b0a9c8 (neutron-a25ddb65-fff0-4231-b2bd-32cec9220206) (aka public)
    port 0dde5ac4-d5cd-4390-9e8d-ed0acd1f23e7
        type: localport
        addresses: ["fa:16:3e:2e:c7:fd"]
    port provnet-83e1d5fe-dcd0-44fe-91be-f058cc36c8da
        type: localnet
        tag: 100
        addresses: ["unknown"]

See "tag: 100" in the OVN NB database hasn't been updated. But it does update it in the Neutron database:

stack@central:~/devstack$ openstack network show public | grep segmentation_id
| provider:segmentation_id | 123 |

Changed in neutron:
importance: Undecided → High
assignee: nobody → Lucas Alvares Gomes (lucasagomes)
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/810704

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/810704
Committed: https://opendev.org/openstack/neutron/commit/982c22dd46bb651c4c5c614262f1a9d68a96cd70
Submitter: "Zuul (22348)"
Branch: master

commit 982c22dd46bb651c4c5c614262f1a9d68a96cd70
Author: Lucas Alvares Gomes <email address hidden>
Date: Thu Sep 23 16:04:00 2021 +0100

    [OVN] Fix updating network segmentation ID

    The ML2/OVN driver wasn't handling updates to the segmentation ID for a
    given network. This patch fixes this problem.

    This patch extends the _update_segmentation_id() method to check on
    drivers which does not inherits from AgentMechanismDriverBase, which
    is the case of OVN (which inherits from MechanismDriver). A new method
    is now called for those drivers to get a list of supported VIF types,
    called get_supported_vif_types().

    Closes-Bug: #1944708
    Change-Id: Ibe08bfbc2efc55b9d628cdd0605941b7486186b6
    Signed-off-by: Lucas Alvares Gomes <email address hidden>

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/853147

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/853148

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/853149

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/853149
Committed: https://opendev.org/openstack/neutron/commit/c11103a9f165d7cbfa23fa807668217ff16f0a7c
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit c11103a9f165d7cbfa23fa807668217ff16f0a7c
Author: Lucas Alvares Gomes <email address hidden>
Date: Thu Sep 23 16:04:00 2021 +0100

    [OVN] Fix updating network segmentation ID

    The ML2/OVN driver wasn't handling updates to the segmentation ID for a
    given network. This patch fixes this problem.

    This patch extends the _update_segmentation_id() method to check on
    drivers which does not inherits from AgentMechanismDriverBase, which
    is the case of OVN (which inherits from MechanismDriver). A new method
    is now called for those drivers to get a list of supported VIF types,
    called get_supported_vif_types().

    Closes-Bug: #1944708
    Change-Id: Ibe08bfbc2efc55b9d628cdd0605941b7486186b6
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit 982c22dd46bb651c4c5c614262f1a9d68a96cd70)

tags: added: in-stable-yoga
tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/853147
Committed: https://opendev.org/openstack/neutron/commit/529b5f9f280a34d18d36be65338d0febcb064e3d
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 529b5f9f280a34d18d36be65338d0febcb064e3d
Author: Lucas Alvares Gomes <email address hidden>
Date: Thu Sep 23 16:04:00 2021 +0100

    [OVN] Fix updating network segmentation ID

    The ML2/OVN driver wasn't handling updates to the segmentation ID for a
    given network. This patch fixes this problem.

    This patch extends the _update_segmentation_id() method to check on
    drivers which does not inherits from AgentMechanismDriverBase, which
    is the case of OVN (which inherits from MechanismDriver). A new method
    is now called for those drivers to get a list of supported VIF types,
    called get_supported_vif_types().

    Closes-Bug: #1944708
    Change-Id: Ibe08bfbc2efc55b9d628cdd0605941b7486186b6
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit 982c22dd46bb651c4c5c614262f1a9d68a96cd70)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/853148
Committed: https://opendev.org/openstack/neutron/commit/9a0539fcda3292e1829a2147d1d181f68c9d9160
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 9a0539fcda3292e1829a2147d1d181f68c9d9160
Author: Lucas Alvares Gomes <email address hidden>
Date: Thu Sep 23 16:04:00 2021 +0100

    [OVN] Fix updating network segmentation ID

    The ML2/OVN driver wasn't handling updates to the segmentation ID for a
    given network. This patch fixes this problem.

    This patch extends the _update_segmentation_id() method to check on
    drivers which does not inherits from AgentMechanismDriverBase, which
    is the case of OVN (which inherits from MechanismDriver). A new method
    is now called for those drivers to get a list of supported VIF types,
    called get_supported_vif_types().

    Closes-Bug: #1944708
    Change-Id: Ibe08bfbc2efc55b9d628cdd0605941b7486186b6
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit 982c22dd46bb651c4c5c614262f1a9d68a96cd70)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 21.0.0.0rc1

This issue was fixed in the openstack/neutron 21.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 18.6.0

This issue was fixed in the openstack/neutron 18.6.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 19.5.0

This issue was fixed in the openstack/neutron 19.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 20.3.0

This issue was fixed in the openstack/neutron 20.3.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.