Neutron - “Update bandwidth limit rule” API on SUCCESS responds with 200 instead of Expected 202

[Arkady Shtempler]

### Scenario ###
Activate “Update bandwidth limit rule” API with proper values to make it PASS

### Actual Result ###
Received status code is 200 OK

### Expected Result ###
According the Documentation it needs to be 202 Accepted
https://docs.openstack.org/api-ref/network/v2/index.html?expanded=update-bandwidth-limit-rule-detail#update-bandwidth-limit-rule

### Tempest prompt output ###
BUG_200_instead_of_202BUG_200_instead_of_202BUG_200_instead_of_202BUG_200_instead_of_202BUG_200_instead_of_202BUG_200_instead_of_202BUG_200_instead_of_202BUG_200_instead_of_202BUG_200_instead_of_202BUG_200_instead_of_202BUG_200_instead_of_202BUG_200_instead_of_202BUG_200_instead_of_202
2021-09-01 15:21:48.668 529226 INFO tempest.lib.common.rest_client [req-27de559b-db51-433b-b01b-fd27cba24664 ] Request (QoSTest:test_qos_basic_and_update): 200 PUT http://10.0.0.125:9696/v2.0/qos/policies/31e15f98-8b03-4f8b-9a1a-27847ea48971/bandwidth_limit_rules/f17625ab-24c7-46c1-bcd2-0e326c9ac360 0.269s
2021-09-01 15:21:48.668 529226 DEBUG tempest.lib.common.rest_client [req-27de559b-db51-433b-b01b-fd27cba24664 ] Request - Headers: {'Content-Type': 'application/json', 'Accept': 'application/json', 'X-Auth-Token': '<omitted>'}
        Body: {"bandwidth_limit_rule": {"max_kbps": 2000, "max_burst_kbps": 2000}}
    Response - Headers: {'content-type': 'application/json', 'content-length': '137', 'x-openstack-request-id': 'req-27de559b-db51-433b-b01b-fd27cba24664', 'date': 'Wed, 01 Sep 2021 19:21:48 GMT', 'connection': 'close', 'status': '200', 'content-location': 'http://10.0.0.125:9696/v2.0/qos/policies/31e15f98-8b03-4f8b-9a1a-27847ea48971/bandwidth_limit_rules/f17625ab-24c7-46c1-bcd2-0e326c9ac360'}
        Body: b'{"bandwidth_limit_rule": {"max_kbps": 2000, "max_burst_kbps": 2000, "direction": "egress", "id": "f17625ab-24c7-46c1-bcd2-0e326c9ac360"}}' _log_request_full /home/stack/tempest/tempest/lib/common/rest_client.py:456

[Brian Haley (brian-haley)]

I don't see anywhere in the neutron code we return HTTPAccepted, for example in any of the tests, only HTTPOk and HTTPCreated, so this might just be a typo in the api-ref doc. I'll ask someone with more QoS knowledge to look into it.

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Hello:

I think this is a mistake in the API reference in neutron-lib. Normal response for "update" commands in Neutron is 200. We should return HTTPOK here, not HTTPAccepted.

I'll push a patch for the api-ref in neutron-lib.

Regards.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron-lib/+/807390

[Arkady Shtempler (ashtempl)]

Does the proposed patch fix this one as well?
https://docs.openstack.org/api-ref/network/v2/index.html?expanded=update-bandwidth-limit-rule-detail,update-minimum-bandwidth-rule-detail#update-minimum-bandwidth-rule

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron-lib/+/807390
Committed: https://opendev.org/openstack/neutron-lib/commit/670f83b0de1359dd301dd65ac2c2571f9d3ee193
Submitter: "Zuul (22348)"
Branch: master

commit 670f83b0de1359dd301dd65ac2c2571f9d3ee193
Author: Brian Haley <email address hidden>
Date: Fri Sep 3 14:28:50 2021 -0400

    Fix some api-ref typos

    There were some places in the API ref that it shows a 202 is
    returned on Update, but we always return a 200 (HTTPOk).
    Fixed a few other cases where Create (should be 201) and
    Delete (should be 204) were wrong as well.

    Change-Id: I4f6eb742f4420d0844e9c254ce989fc62973b0cf
    Closes-bug: #1942448

[Brian Haley (brian-haley)]

Arkady - yes, I believe it fixes that as well. Thanks for finding the issue!

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-lib 2.16.0 release.