ovs2ovn migration tool fails using VALIDATE_MIGRATION=False

[Roman Safronov]

OVN Migration Script [1] Fails when MIGRATION_VALIDATE=False.
It doesn't work 100% of the time without a FIP.

[1] tools/ovn_migration/tripleo_environment/ovn_migration.sh

Steps to Reproduce:
1. VALIDATE_MIGRATION=False; export VALIDATE_MIGRATION
2. Execute /usr/bin/ovn_migration.sh generate-inventory

Actual results:
$ /usr/bin/ovn_migration.sh generate-inventory
/usr/bin/ovn_migration.sh: line 226: /home/stack/overcloudrc: No such file or directory
Error while executing command: No Network found for public
ERROR: PUBLIC_NETWORK_NAME=public can't be accessed by the
       admin user, please fix that before continuing.

Expected results:
Script to execute without errors:
$ ./ovn_migration.sh generate-inventory
(tpa-vim-b) [stack@tpavimbuc ovn_migration]$ echo $?
0

The customer does not use floating IPs, this is why not all of the environment variables were set.
The OVN migration script should return successfully from oc_check_public_network in case MIGRATION_VALIDATE set to False.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/806942

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/806942
Committed: https://opendev.org/openstack/neutron/commit/3c305bf6ae37bd26cda8545bb1a76302dc830dee
Submitter: "Zuul (22348)"
Branch: master

commit 3c305bf6ae37bd26cda8545bb1a76302dc830dee
Author: Roman Safronov <email address hidden>
Date: Wed Sep 1 17:56:43 2021 +0300

    Skip FIP check if VALIDATE_MIGRATION is not True

    OVN migration script fails when VALIDATE_MIGRATION is not set to
    True. oc_check_public_network should return successfully in case
    VALIDATE_MIGRATION is set to False.

    Closes bug: #1942344

    Change-Id: Ibd0aea5b4e6bf44803d5d0100cacc17d401b03cc

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/807735

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/807736

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/807737

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/807735
Committed: https://opendev.org/openstack/neutron/commit/c26296d8023310aed1b9e12b39f274130a2b12d5
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit c26296d8023310aed1b9e12b39f274130a2b12d5
Author: Roman Safronov <email address hidden>
Date: Wed Sep 1 17:56:43 2021 +0300

    Skip FIP check if VALIDATE_MIGRATION is not True

    OVN migration script fails when VALIDATE_MIGRATION is not set to
    True. oc_check_public_network should return successfully in case
    VALIDATE_MIGRATION is set to False.

    Closes bug: #1942344

    Change-Id: Ibd0aea5b4e6bf44803d5d0100cacc17d401b03cc
    (cherry picked from commit 3c305bf6ae37bd26cda8545bb1a76302dc830dee)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/807736
Committed: https://opendev.org/openstack/neutron/commit/78e200268f8cdbd3473fe667e92e2606c7c3debf
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 78e200268f8cdbd3473fe667e92e2606c7c3debf
Author: Roman Safronov <email address hidden>
Date: Wed Sep 1 17:56:43 2021 +0300

    Skip FIP check if VALIDATE_MIGRATION is not True

    OVN migration script fails when VALIDATE_MIGRATION is not set to
    True. oc_check_public_network should return successfully in case
    VALIDATE_MIGRATION is set to False.

    Closes bug: #1942344

    Change-Id: Ibd0aea5b4e6bf44803d5d0100cacc17d401b03cc
    (cherry picked from commit 3c305bf6ae37bd26cda8545bb1a76302dc830dee)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 19.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/807737
Committed: https://opendev.org/openstack/neutron/commit/3ebe727ae32aac87b4a54f0d2ed09d0429cb06fb
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 3ebe727ae32aac87b4a54f0d2ed09d0429cb06fb
Author: Roman Safronov <email address hidden>
Date: Wed Sep 1 17:56:43 2021 +0300

    Skip FIP check if VALIDATE_MIGRATION is not True

    OVN migration script fails when VALIDATE_MIGRATION is not set to
    True. oc_check_public_network should return successfully in case
    VALIDATE_MIGRATION is set to False.

    Closes bug: #1942344

    Change-Id: Ibd0aea5b4e6bf44803d5d0100cacc17d401b03cc
    (cherry picked from commit 3c305bf6ae37bd26cda8545bb1a76302dc830dee)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 16.4.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 17.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 18.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn train-eol release.