neutron

pyroute2 >= 0.6.2 fails in pep8 import analysis

Bug #1930750 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Critical
Rodolfo Alonso

Bug Description

Since version 0.6.2, pyroute2 library dynamically imports the needed modules when loaded. A static analysis will fail when checking the import references.

Example: https://c918cbae52d07f0b694c-87cfb8a8e579ae39cc41214d7e8b69d2.ssl.cf1.rackcdn.com/793735/2/check/openstack-tox-pep8/62e482e/job-output.txt

Snippet: http://paste.openstack.org/show/806340/

Rodolfo Alonso (rodolfo-alonso-hernandez)
Changed in neutron:
importance: Undecided → Critical
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/794668

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/794668
Committed: https://opendev.org/openstack/neutron/commit/074c131b570adb60150ea25d7cec2367ee963ac2
Submitter: "Zuul (22348)"
Branch: master

commit 074c131b570adb60150ea25d7cec2367ee963ac2
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Jun 3 19:11:11 2021 +0000

    Disable pep8 import check for pyroute2 library

    Since version 0.6.2, pyroute2 library dynamically imports the needed
    modules when loaded. A static analysis will fail when checking the
    import references.

    Change-Id: I5aaf9494a2d5c2533199e6b92d4df8fe785f83a3
    Closes-Bug: #1930750

Changed in neutron:
status: In Progress → Fix Released
Bernard Cafarelli (bcafarel)
tags: added: neutron-proactive-backport-potential
Bernard Cafarelli (bcafarel)
tags: removed: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 19.0.0.0rc1

This issue was fixed in the openstack/neutron 19.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/829211

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/829211
Committed: https://opendev.org/openstack/neutron/commit/3ba0f8f3c6f0e92688b2e0f954e1f8afa14854e5
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 3ba0f8f3c6f0e92688b2e0f954e1f8afa14854e5
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Jun 3 19:11:11 2021 +0000

    Disable pep8 import check for pyroute2 library

    Since version 0.6.2, pyroute2 library dynamically imports the needed
    modules when loaded. A static analysis will fail when checking the
    import references.

    Conflicts:
      neutron/privileged/agent/linux/ip_lib.py

    Note for this backport, we recently bumped the pyroute2
    version for stable/wallaby due to a memory leak problem
    with the old version. You can find more information at:
    https://review.opendev.org/c/openstack/requirements/+/828091

    Change-Id: I5aaf9494a2d5c2533199e6b92d4df8fe785f83a3
    Closes-Bug: #1930750
    (cherry picked from commit 074c131b570adb60150ea25d7cec2367ee963ac2)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 18.3.0

This issue was fixed in the openstack/neutron 18.3.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.