"test_reserve_provider_segment_without_physical_network" failing randomly

Bug #1929190 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Rodolfo Alonso

Bug Description

Since [1], the VLAN segment allocation using "get_random_unallocated_segment" does not enforce a priority in the physical network selection, depending on the configuration order. All available physical network segments can be selected randomly; that means any physical network can be chosen.

The occurrence of this error was low because "phys_net1" has 4096 VLAN IDs and "phys_net2" only 10.

Error: https://1a46c32c0fda8a65ef95-6c47599ea81a63bd28f7b62c07ab0c76.ssl.cf5.rackcdn.com/792015/2/check/openstack-tox-cover/c3222cd/testr_results.html

Snippet: http://paste.openstack.org/show/805543/

[1]https://review.opendev.org/c/openstack/neutron/+/780802

Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/792559

Changed in neutron:
status: New → In Progress
tags: added: unittest
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/792559
Committed: https://opendev.org/openstack/neutron/commit/05ce5a1f9409d9fdd4ef92133f38d7ec9084b1c5
Submitter: "Zuul (22348)"
Branch: master

commit 05ce5a1f9409d9fdd4ef92133f38d7ec9084b1c5
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri May 21 09:44:22 2021 +0000

    VLAN "allocate_partially_specified_segment" can return any physnet

    When allocating a partially defined segment with VLAN type driver, any
    physical network can be returned. The method will select randomly any
    VLAN segment available, independently of the physnet configured order.

    Change-Id: I4d344f5ca6673b70b69a03503ec0f267bf0cadf7
    Closes-Bug: #1929190

Changed in neutron:
status: In Progress → Fix Released
tags: added: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/808156

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/808189

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/808191

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/neutron/+/808192

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/808156
Committed: https://opendev.org/openstack/neutron/commit/c823bc3294f5dfcd3a3dc52fca0eee9cb6ed277c
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit c823bc3294f5dfcd3a3dc52fca0eee9cb6ed277c
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri May 21 09:44:22 2021 +0000

    VLAN "allocate_partially_specified_segment" can return any physnet

    When allocating a partially defined segment with VLAN type driver, any
    physical network can be returned. The method will select randomly any
    VLAN segment available, independently of the physnet configured order.

    Change-Id: I4d344f5ca6673b70b69a03503ec0f267bf0cadf7
    Closes-Bug: #1929190
    (cherry picked from commit 05ce5a1f9409d9fdd4ef92133f38d7ec9084b1c5)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 19.0.0.0rc1

This issue was fixed in the openstack/neutron 19.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/808191
Committed: https://opendev.org/openstack/neutron/commit/9b0f09456451744592a7d43fe02645a91e695dca
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 9b0f09456451744592a7d43fe02645a91e695dca
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri May 21 09:44:22 2021 +0000

    VLAN "allocate_partially_specified_segment" can return any physnet

    When allocating a partially defined segment with VLAN type driver, any
    physical network can be returned. The method will select randomly any
    VLAN segment available, independently of the physnet configured order.

    Conflicts:
        neutron/tests/unit/plugins/ml2/drivers/test_type_vlan.py

    Change-Id: I4d344f5ca6673b70b69a03503ec0f267bf0cadf7
    Closes-Bug: #1929190
    (cherry picked from commit 05ce5a1f9409d9fdd4ef92133f38d7ec9084b1c5)
    (cherry picked from commit c823bc3294f5dfcd3a3dc52fca0eee9cb6ed277c)
    (cherry picked from commit e07b66e710798fb299da145c60df2ffdde368b50)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/train)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/808192
Committed: https://opendev.org/openstack/neutron/commit/e474ee9a5daa774e6b7f1de44a568b187cf74ad5
Submitter: "Zuul (22348)"
Branch: stable/train

commit e474ee9a5daa774e6b7f1de44a568b187cf74ad5
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri May 21 09:44:22 2021 +0000

    VLAN "allocate_partially_specified_segment" can return any physnet

    When allocating a partially defined segment with VLAN type driver, any
    physical network can be returned. The method will select randomly any
    VLAN segment available, independently of the physnet configured order.

    Conflicts:
        neutron/tests/unit/plugins/ml2/drivers/test_type_vlan.py

    Change-Id: I4d344f5ca6673b70b69a03503ec0f267bf0cadf7
    Closes-Bug: #1929190
    (cherry picked from commit 05ce5a1f9409d9fdd4ef92133f38d7ec9084b1c5)
    (cherry picked from commit c823bc3294f5dfcd3a3dc52fca0eee9cb6ed277c)
    (cherry picked from commit e07b66e710798fb299da145c60df2ffdde368b50)
    (cherry picked from commit 9b0f09456451744592a7d43fe02645a91e695dca)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 16.4.2

This issue was fixed in the openstack/neutron 16.4.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 17.3.0

This issue was fixed in the openstack/neutron 17.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 18.2.0

This issue was fixed in the openstack/neutron 18.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.