ovn_migration.sh script doesn't detect neutron_dhcp agents when they run on a different node than neutron_api

Bug #1928450 reported by Jakub Libosvar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Medium
Jakub Libosvar

Bug Description

Description of problem:
hosts_for_migration/[ovn-dbs] host group is populated wrongly and doesn't consider neutron_dhcp containers running elsewhere than neutron_server.

Version-Release number of selected component (if applicable):
python3-networking-ovn-migration-tool-7.3.1-1.20200902233413.el8ost.noarch (RHOS 16.1.3)

How reproducible:
always

Steps to Reproduce:
1. Install overcloud with split control plane having neutron_dhcp and neutron_api running on distinct nodes
2.
3.

Actual results:
[ovn-dbs]
ctrl-net-c-01 ansible_host=10.0.37.45 ovn_central=true ansible_ssh_user=stack ansible_become=true
ctrl-net-c-02 ansible_host=10.0.37.21 ansible_ssh_user=stack ansible_become=true
ctrl-net-c-03 ansible_host=10.0.36.66 ansible_ssh_user=stack ansible_become=true
ctrl-net-c-04 ansible_host=10.0.37.139 ansible_ssh_user=stack ansible_become=true

[ovn-controllers]
compute-net-c-001 ansible_host=10.0.36.225 ansible_ssh_user=stack ansible_become=true ovn_controller=true
compute-net-c-002 ansible_host=10.0.36.152 ansible_ssh_user=stack ansible_become=true ovn_controller=true
ctrl-nova-c-01 ansible_host=10.0.37.104 ansible_ssh_user=stack ansible_become=true ovn_controller=true
ctrl-nova-c-02 ansible_host=10.0.37.15 ansible_ssh_user=stack ansible_become=true ovn_controller=true
ctrl-nova-c-03 ansible_host=10.0.37.8 ansible_ssh_user=stack ansible_become=true ovn_controller=true

Expected results:
[ovn-dbs]
compute-net-c-001 ansible_host=10.0.36.225 ansible_ssh_user=stack ansible_become=true
compute-net-c-002 ansible_host=10.0.36.152 ansible_ssh_user=stack ansible_become=true

[ovn-controllers]
compute-net-c-001 ansible_host=10.0.36.225 ansible_ssh_user=stack ansible_become=true ovn_controller=true
compute-net-c-002 ansible_host=10.0.36.152 ansible_ssh_user=stack ansible_become=true ovn_controller=true
ctrl-nova-c-01 ansible_host=10.0.37.104 ansible_ssh_user=stack ansible_become=true ovn_controller=true
ctrl-nova-c-02 ansible_host=10.0.37.15 ansible_ssh_user=stack ansible_become=true ovn_controller=true
ctrl-nova-c-03 ansible_host=10.0.37.8 ansible_ssh_user=stack ansible_become=true ovn_controller=true

Revision history for this message
Jakub Libosvar (libosvar) wrote :
Changed in neutron:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/791113

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/791114

Changed in neutron:
importance: Undecided → Medium
milestone: none → xena-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/791113
Committed: https://opendev.org/openstack/neutron/commit/208fea3bf6835ce460dc515d24cd3871c2420276
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 208fea3bf6835ce460dc515d24cd3871c2420276
Author: Jakub Libosvar <email address hidden>
Date: Fri Mar 19 12:07:12 2021 +0100

    ovn-migration: Use DHCP nodes to configure dnsmasq

    Previously, the migration script used controller nodes to configure
    dnsmasq when configuring new MTU. Controller nodes may not run DHCP
    agents. The patch detects DHCP agents instead and uses those to
    configure dnsmasq.

    Closes-bug: #1928450

    Change-Id: Ib468c04779af7aaf4dedf84ba885bce71078248b
    Signed-off-by: Jakub Libosvar <email address hidden>
    (cherry picked from commit 569aa4452a42d884f365fc7800164a9f7f984687)

tags: added: in-stable-victoria
tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/791114
Committed: https://opendev.org/openstack/neutron/commit/676935b4e59f0b3bfb7e6daeb68863238bb85837
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 676935b4e59f0b3bfb7e6daeb68863238bb85837
Author: Jakub Libosvar <email address hidden>
Date: Fri Mar 19 12:07:12 2021 +0100

    ovn-migration: Use DHCP nodes to configure dnsmasq

    Previously, the migration script used controller nodes to configure
    dnsmasq when configuring new MTU. Controller nodes may not run DHCP
    agents. The patch detects DHCP agents instead and uses those to
    configure dnsmasq.

    Closes-bug: #1928450

    Change-Id: Ib468c04779af7aaf4dedf84ba885bce71078248b
    Signed-off-by: Jakub Libosvar <email address hidden>
    (cherry picked from commit 569aa4452a42d884f365fc7800164a9f7f984687)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 16.4.0

This issue was fixed in the openstack/neutron 16.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 17.2.0

This issue was fixed in the openstack/neutron 17.2.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers