Allow update of description of security_group_rule

[Jesper Schmitz Mouridsen]

Allow putting/editing description on an existing security_group_rule:

curl -X PUT -H "X-Auth-Token: $TOKEN" -H "Content-Type: application/json" -d '{"security_group_rule":{"description":"testing"}}' "http://$NEUTRON_URL:9696/v2.0/security_group_rules/$SEC_RULE_ID

I do not know implications of the attached patch with reagards to the firewall agent. Comments are welcome.

[Lajos Katona (lajos-katona)]

Based on api-def (see [1]) and api-ref (see [2]) no PUT is not allowed on security-group rules

[1] https://opendev.org/openstack/neutron/src/branch/master/neutron/extensions/securitygroup.py#L239
[2] https://docs.openstack.org/api-ref/network/v2/index.html#security-group-rules-security-group-rules

[Jesper Schmitz Mouridsen (jsmdk)]

Well on current unmodified devstack you can put to
http://$NEUTRON_IP:9696/v2.0/security_group_rules/$RULE_ID

You get
AttributeError: 'Ml2Plugin' object has no attribute 'update_security_group_rule'

My patch implements update_security_group_rule and allows editing of description.

It seems that the api-def only disallows puts of security-group-rules within the security-group endpoint?

[Brian Haley (brian-haley)]

I guess I don't see why the description field can't be updated, since it's part of the StandardAttribute that has allow_put=True. It would need a larger change, like adding publishing of events, as well as openstack client changes to allow it.