neutron

Deprecation of pyroute2.IPDB in favor of pyroute2.NDB

Bug #1926476 reported by Rodolfo Alonso
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Rodolfo Alonso

Bug Description

The module "pyroute2.IPDB" is used in "privileged.agent.linux.ip_lib.get_routing_table".

Output: http://paste.openstack.org/show/804836/

Deprecation warning documentation: https://docs.pyroute2.org/ipdb_toc.html

Rodolfo Alonso (rodolfo-alonso-hernandez)
Changed in neutron:
importance: Undecided → High
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/788810

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/788936

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/788810
Committed: https://opendev.org/openstack/neutron/commit/2cf431455395c6c87e174073eac3557f4820eb0f
Submitter: "Zuul (22348)"
Branch: master

commit 2cf431455395c6c87e174073eac3557f4820eb0f
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Apr 29 17:18:09 2021 +0000

    Implement multipath routing in route commands

    Related-Bug: #1926476

    Change-Id: I598da266905a5645b744d7ffcc47b417ff64a5e7

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/788936
Committed: https://opendev.org/openstack/neutron/commit/c511964d70324c6974740eed245044f0fe77841e
Submitter: "Zuul (22348)"
Branch: master

commit c511964d70324c6974740eed245044f0fe77841e
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri Apr 30 10:42:31 2021 +0000

    Replace "get_routing_table" with "list_ip_routes"

    "get_routing_table" uses "pyroute2.IPDB" that has been deprecated.
    "list_ip_routes" has been improved to be able to read multipath
    routes.

    Closes-Bug: #1926476

    Change-Id: I0299fa11a7afefbd2999f81cd4ed3beed572009c

Changed in neutron:
status: In Progress → Fix Released
Bernard Cafarelli (bcafarel)
tags: added: neutron-proactive-backport-potential
Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :

Because stable branches use older versions of pyroute2, I wouldn't backport this patch.

pyroute2.IPDB was removed in pyroute2==0.6.2.

Slawek Kaplonski (slaweq)
tags: removed: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 19.0.0.0rc1

This issue was fixed in the openstack/neutron 19.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (stable/wallaby)

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/868086

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/868087

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/868086
Committed: https://opendev.org/openstack/neutron/commit/59e9b6749dda59955e530133da137ca64e4256e9
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 59e9b6749dda59955e530133da137ca64e4256e9
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Apr 29 17:18:09 2021 +0000

    Implement multipath routing in route commands

    Related-Bug: #1926476

    Change-Id: I598da266905a5645b744d7ffcc47b417ff64a5e7
    (cherry picked from commit 2cf431455395c6c87e174073eac3557f4820eb0f)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/868087
Committed: https://opendev.org/openstack/neutron/commit/d57a6f1be8c221a93c7a189544e3bb6cf69e36f0
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit d57a6f1be8c221a93c7a189544e3bb6cf69e36f0
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri Apr 30 10:42:31 2021 +0000

    Replace "get_routing_table" with "list_ip_routes"

    "get_routing_table" uses "pyroute2.IPDB" that has been deprecated.
    "list_ip_routes" has been improved to be able to read multipath
    routes.

    Closes-Bug: #1926476

    Conflicts:
        neutron/privileged/agent/linux/ip_lib.py
        neutron/tests/functional/agent/l3/framework.py
        neutron/tests/functional/agent/linux/test_ip_lib.py

    Change-Id: I0299fa11a7afefbd2999f81cd4ed3beed572009c
    (cherry picked from commit c511964d70324c6974740eed245044f0fe77841e)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron wallaby-eom

This issue was fixed in the openstack/neutron wallaby-eom release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.