neutron

[OVN] OVN metada should not need to monitor the enterily Chassis table

Bug #1925836 reported by Lucas Alvares Gomes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Lucas Alvares Gomes

Bug Description

If both "Chassis" and "Chassis_Private" tables are passed to the MetadataProxyHandler class [0] the code will only limit the monitoring of the "Chassis_Private" table [1].

Ideally, both tables should be conditionally monitored instead.

[0] https://github.com/openstack/neutron/blob/1ad9ca56b07ffdc9f7e0bc6a62af61961b9128eb/neutron/agent/ovn/metadata/agent.py#L240-L242

[1] https://github.com/openstack/neutron/blob/1ad9ca56b07ffdc9f7e0bc6a62af61961b9128eb/neutron/agent/ovn/metadata/ovsdb.py#L41-L44

Lucas Alvares Gomes (lucasagomes)
tags: added: ovn
Changed in neutron:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/787780

Changed in neutron:
status: Confirmed → In Progress
Rodolfo Alonso (rodolfo-alonso-hernandez)
Changed in neutron:
assignee: nobody → Lucas Alvares Gomes (lucasagomes)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/787780
Committed: https://opendev.org/openstack/neutron/commit/ce2c0010b93680bdcb6619940a84f8602769b837
Submitter: "Zuul (22348)"
Branch: master

commit ce2c0010b93680bdcb6619940a84f8602769b837
Author: Lucas Alvares Gomes <email address hidden>
Date: Fri Apr 23 17:32:07 2021 +0100

    [OVN] MetadataProxyHandler to conditionally monitor both Chassis's tables

    If both Chassis and Chassis_Private tables are passed to the
    MetadataProxyHandler class we should conditionally monitor both of them.

    Change-Id: Iffd1deb977e92b9a600ab2603408ddf2eb387e18
    Co-Authored-By: Terry Wilson <email address hidden>
    Closes-Bug: #1925836
    Signed-off-by: Lucas Alvares Gomes <email address hidden>

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/787963

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/787964

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/787965

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/787965
Committed: https://opendev.org/openstack/neutron/commit/220d9875a02de8dc87fb9efc3fff904f511976b6
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 220d9875a02de8dc87fb9efc3fff904f511976b6
Author: Lucas Alvares Gomes <email address hidden>
Date: Fri Apr 23 17:32:07 2021 +0100

    [OVN] MetadataProxyHandler to conditionally monitor both Chassis's tables

    If both Chassis and Chassis_Private tables are passed to the
    MetadataProxyHandler class we should conditionally monitor both of them.

    Change-Id: Iffd1deb977e92b9a600ab2603408ddf2eb387e18
    Co-Authored-By: Terry Wilson <email address hidden>
    Closes-Bug: #1925836
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit ce2c0010b93680bdcb6619940a84f8602769b837)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/787963
Committed: https://opendev.org/openstack/neutron/commit/9758e72fcf17ee6d5e2cccba89b71bed00e21433
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 9758e72fcf17ee6d5e2cccba89b71bed00e21433
Author: Lucas Alvares Gomes <email address hidden>
Date: Fri Apr 23 17:32:07 2021 +0100

    [OVN] MetadataProxyHandler to conditionally monitor both Chassis's tables

    If both Chassis and Chassis_Private tables are passed to the
    MetadataProxyHandler class we should conditionally monitor both of them.

    Change-Id: Iffd1deb977e92b9a600ab2603408ddf2eb387e18
    Co-Authored-By: Terry Wilson <email address hidden>
    Closes-Bug: #1925836
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit ce2c0010b93680bdcb6619940a84f8602769b837)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/787964
Committed: https://opendev.org/openstack/neutron/commit/6f2615a244cba4f40b408c9650b2b3df40819f29
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 6f2615a244cba4f40b408c9650b2b3df40819f29
Author: Lucas Alvares Gomes <email address hidden>
Date: Fri Apr 23 17:32:07 2021 +0100

    [OVN] MetadataProxyHandler to conditionally monitor both Chassis's tables

    If both Chassis and Chassis_Private tables are passed to the
    MetadataProxyHandler class we should conditionally monitor both of them.

    Change-Id: Iffd1deb977e92b9a600ab2603408ddf2eb387e18
    Co-Authored-By: Terry Wilson <email address hidden>
    Closes-Bug: #1925836
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit ce2c0010b93680bdcb6619940a84f8602769b837)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-ovn 7.4.1

This issue was fixed in the openstack/networking-ovn 7.4.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 16.3.2

This issue was fixed in the openstack/neutron 16.3.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 17.1.2

This issue was fixed in the openstack/neutron 17.1.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 18.1.0

This issue was fixed in the openstack/neutron 18.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 19.0.0.0rc1

This issue was fixed in the openstack/neutron 19.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.